fix: invalid dock badge count #250

2026-06-09T16:10:56Z

talksik commented

2026-06-09 16:10:56 +00:00

(Migrated from github.com)

Closes #239

Summary by CodeRabbit

Bug Fixes

Improved notification badge behavior by refining how the unseen message count is tracked and displayed on the app icon.

Closes #239  ## Summary by CodeRabbit ## Bug Fixes * Improved notification badge behavior by refining how the unseen message count is tracked and displayed on the app icon.

coderabbitai[bot] commented

2026-06-09 16:11:10 +00:00

(Migrated from github.com)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 91f8df6a-643d-486d-97c9-c0ef6742f439

📥 Commits

Reviewing files that changed from the base of the PR and between c1f5b6c8c1 and df5495a8bd.

📒 Files selected for processing (1)

js/desktop/src/hooks/use-dock-badge.ts

💤 Files with no reviewable changes (1)

js/desktop/src/hooks/use-dock-badge.ts

📝 Walkthrough

Walkthrough

The useDockBadge hook updates the macOS dock badge count from Firestore-derived unseenCount via useEffect. The cleanup function that previously reset the badge to 0 on unmount or dependency changes has been removed.

Changes

Dock Badge Effect Behavior

Layer / File(s)	Summary
Dock badge effect cleanup removal `js/desktop/src/hooks/use-dock-badge.ts`	The `useEffect` hook that updates `platform.app.setDockBadge(unseenCount)` no longer includes a cleanup handler to reset the badge to `0` when the component unmounts or dependencies change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A badge that persists when the effect takes leave,
No reset in sight, quite bold to believe,
One line removed, a cleanup passed by,
The dock badge stands tall beneath the sky!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: fixing an invalid dock badge count by removing a problematic cleanup function in the useDockBadge hook.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 239-web-app-showing-inaccurate-badge-count

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/flowy-live/llink/pull/250?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)  No actionable comments were generated in the recent review. 🎉 <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `91f8df6a-643d-486d-97c9-c0ef6742f439` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between c1f5b6c8c1b5536279e839d35352be90d5bc8e28 and df5495a8bd6ef966cd9e3bed90c39bcd77c203b7. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `js/desktop/src/hooks/use-dock-badge.ts` </details> <details> <summary>💤 Files with no reviewable changes (1)</summary> * js/desktop/src/hooks/use-dock-badge.ts </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough The `useDockBadge` hook updates the macOS dock badge count from Firestore-derived `unseenCount` via `useEffect`. The cleanup function that previously reset the badge to `0` on unmount or dependency changes has been removed. ## Changes **Dock Badge Effect Behavior** | Layer / File(s) | Summary | |---|---| | **Dock badge effect cleanup removal** `js/desktop/src/hooks/use-dock-badge.ts` | The `useEffect` hook that updates `platform.app.setDockBadge(unseenCount)` no longer includes a cleanup handler to reset the badge to `0` when the component unmounts or dependencies change. | ## Estimated code review effort 🎯 1 (Trivial) | ⏱️ ~3 minutes ## Poem > 🐰 *A badge that persists when the effect takes leave,* > *No reset in sight, quite bold to believe,* > *One line removed, a cleanup passed by,* > *The dock badge stands tall beneath the sky!* </details>   <details> <summary>🚥 Pre-merge checks | ✅ 5</summary> <details> <summary>✅ Passed checks (5 passed)</summary> | Check name | Status | Explanation | | :------------------------: | :------- | :---------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title directly addresses the main change: fixing an invalid dock badge count by removing a problematic cleanup function in the useDockBadge hook. | | Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | </details> ✏️ Tip: You can configure your own custom pre-merge checks in the settings. </details>   <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ]  Create stacked PR - [ ]  Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Commit unit tests in branch `239-web-app-showing-inaccurate-badge-count` </details> </details>   --- Comment `@coderabbitai help` to get the list of available commands and usage tips.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FlowyLabs/llink#250