Shorter socket-timeouts after WebSocket::end() (#1245) (#1246)

src/WebSocket.h

@@ -167,10 +167,14 @@ public:
             }
         }
 
-        /* Emit close event */
         WebSocketContextData<SSL, USERDATA> *webSocketContextData = (WebSocketContextData<SSL, USERDATA> *) us_socket_context_ext(SSL,
             (us_socket_context_t *) us_socket_context(SSL, (us_socket_t *) this)
         );
+
+        /* Set shorter timeout (use ping-timeout) to avoid long hanging sockets after end() on broken connections */
+        Super::timeout(webSocketContextData->idleTimeoutComponents.second);
+
+        /* Emit close event */
         if (webSocketContextData->closeHandler) {
             webSocketContextData->closeHandler(this, code, message);
         }

src/WebSocketContext.h

@@ -364,7 +364,7 @@ private:
             auto *webSocketData = (WebSocketData *)(us_socket_ext(SSL, s));
             auto *webSocketContextData = (WebSocketContextData<SSL, USERDATA> *) us_socket_context_ext(SSL, us_socket_context(SSL, (us_socket_t *) s));
 
-            if (webSocketContextData->sendPingsAutomatically && !webSocketData->hasTimedOut) {
+            if (webSocketContextData->sendPingsAutomatically && !webSocketData->isShuttingDown && !webSocketData->hasTimedOut) {
                 webSocketData->hasTimedOut = true;
                 us_socket_timeout(SSL, s, webSocketContextData->idleTimeoutComponents.second);
                 /* Send ping without being corked */

src/WebSocketContextData.h

@@ -88,13 +88,9 @@ public:
         while ((int) idleTimeout - margin * 2 >= margin * 2 && margin < 16) {
             margin = (unsigned short) (margin << 1);
         }
-        /* We should have no margin if not using sendPingsAutomatically */
-        if (!sendPingsAutomatically) {
-            margin = 0;
-        }
         idleTimeoutComponents = {
-            idleTimeout - margin,
+            idleTimeout - (sendPingsAutomatically ? margin : 0), /* reduce normal idleTimeout if it is extended by ping-timeout */
-            margin
+            margin /* ping-timeout - also used for end() timeout */
         };
     }