Commit Graph
6 Commits
Author SHA1 Message Date
Tom BeckettandGitHub c0e142ab4c Merge pull request #2 from xsahil03x/bugfix/deleting_thread_messages
fix(llc): improve removeMessage logic.
2022-02-18 07:16:31 +00:00
Tom BeckettandGitHub 558845aabc chore(llc): version changelog bymp 2021-08-03 14:53:19 +01:00
Tom BeckettandGitHub 5f10220bce chore(llc): Moved entry to correct heading. 2021-08-03 14:52:41 +01:00
Tom Beckett dd5b9bb256 fix(llc): channel.markAllRead 2021-08-03 14:40:53 +01:00
Tom Beckett 8ba82e8931 chore(llc): add changelog entry 2021-08-03 14:40:16 +01:00
Tom BeckettandGitHub 7aafc405f1 fix: Add missing forward slash to markAllRead url
# Submit a pull request

## CLA

- [x] I have signed the [Stream CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform) (required).
- [x] The code changes follow best practices
- [ ] Code changes are tested (add some information if not applicable)

## Description of the pull request

Running latest GetStream SDK (from version 2.0.0) calling `channel.markAllRead()` will throw an error similar to this:

```bash
I/flutter (10572): ----------------FIREBASE CRASHLYTICS----------------
I/flutter (10572): StreamChatNetworkError(code: -1, message: SocketException: Failed host lookup: 'chat-us-east-1.stream-io-api.comchannels' (OS Error: No address associated with hostname, errno = 7))
I/flutter (10572): #0      StreamHttpClient.post (package:stream_chat/src/core/http/stream_http_client.dart:158:7)
I/flutter (10572): <asynchronous suspension>
I/flutter (10572): #1      ChannelApi.markAllRead (package:stream_chat/src/core/api/channel_api.dart:87:22)
I/flutter (10572): <asynchronous suspension>
I/flutter (10572): ----------------------------------------------------
```

Adding a `/` to the front of the called URL will resolve this - I've done this locally and it works.
2021-08-03 14:26:03 +01:00