Merge branch 'feat/update-spl' into feat/message-list-view-shrink-wrap

packages/stream_chat_flutter/test/scrollable_positioned_list/positioned_list_test.dart

@@ -391,12 +391,14 @@ void main() {
       ),
     ));
 
-    // Insert a new opaque OverlayEntry that would prevent the first OverlayEntry
-    // from doing re-layout. Since there's no relayout boundaries in the first
-    // OverlayEntry, no dirty RenderObjects in its render subtree can update
-    // layout.
-    final newOverlay =
-        OverlayEntry(builder: (context) => const SizedBox.expand(), opaque: true);
+    // Insert a new opaque OverlayEntry that would prevent the first
+    // OverlayEntry from doing re-layout. Since there's no relayout boundaries
+    // in the first OverlayEntry, no dirty RenderObjects in its render subtree
+    // can update layout.
+    final newOverlay = OverlayEntry(
+      builder: (context) => const SizedBox.expand(),
+      opaque: true,
+    );
     tester.state<OverlayState>(find.byType(Overlay)).insert(newOverlay);
     await tester.pump();
 

packages/stream_chat_flutter/test/scrollable_positioned_list/scrollable_positioned_list_test.dart

@@ -48,7 +48,10 @@ void main() {
           itemCount: itemCount,
           itemScrollController: itemScrollController,
           itemBuilder: (context, index) {
-            assert(index >= 0 && index <= itemCount - 1);
+            assert(
+              index >= 0 && index <= itemCount - 1,
+              'index must be in the range of 0 to itemCount - 1',
+            );
             return SizedBox(
               height:
                   variableHeight ? (itemHeight + (index % 13) * 5) : itemHeight,
@@ -1133,34 +1136,35 @@ void main() {
   }, skip: true);
 
   testWidgets(
-      'Jump to 400 at bottom, manually scroll, scroll to 100 at bottom and back',
-      (WidgetTester tester) async {
-    final itemScrollController = ItemScrollController();
-    final itemPositionsListener = ItemPositionsListener.create();
-    await setUpWidgetTest(tester,
-        itemScrollController: itemScrollController,
-        itemPositionsListener: itemPositionsListener);
+    'Jump to 400 at bottom, manually scroll, scroll to 100 at bottom and back',
+    (WidgetTester tester) async {
+      final itemScrollController = ItemScrollController();
+      final itemPositionsListener = ItemPositionsListener.create();
+      await setUpWidgetTest(tester,
+          itemScrollController: itemScrollController,
+          itemPositionsListener: itemPositionsListener);
 
-    itemScrollController.jumpTo(index: 400, alignment: 1);
-    await tester.pumpAndSettle();
+      itemScrollController.jumpTo(index: 400, alignment: 1);
+      await tester.pumpAndSettle();
 
-    final listFinder = find.byType(ScrollablePositionedList);
+      final listFinder = find.byType(ScrollablePositionedList);
 
-    await tester.drag(listFinder, const Offset(0, -screenHeight));
-    await tester.pumpAndSettle();
+      await tester.drag(listFinder, const Offset(0, -screenHeight));
+      await tester.pumpAndSettle();
 
-    unawaited(itemScrollController.scrollTo(
-        index: 100, alignment: 1, duration: scrollDuration));
-    await tester.pumpAndSettle();
+      unawaited(itemScrollController.scrollTo(
+          index: 100, alignment: 1, duration: scrollDuration));
+      await tester.pumpAndSettle();
 
-    unawaited(itemScrollController.scrollTo(
-        index: 400, alignment: 1, duration: scrollDuration));
-    await tester.pumpAndSettle();
+      unawaited(itemScrollController.scrollTo(
+          index: 400, alignment: 1, duration: scrollDuration));
+      await tester.pumpAndSettle();
 
-    final itemFinder = find.text('Item 399');
-    expect(itemFinder, findsOneWidget);
-    expect(tester.getBottomLeft(itemFinder).dy, screenHeight);
-  });
+      final itemFinder = find.text('Item 399');
+      expect(itemFinder, findsOneWidget);
+      expect(tester.getBottomLeft(itemFinder).dy, screenHeight);
+    },
+  );
 
   testWidgets('physics', (WidgetTester tester) async {
     final itemScrollController = ItemScrollController();
@@ -1652,70 +1656,71 @@ void main() {
   });
 
   testWidgets(
-      'Maintain programmatic and user position (9 half way off top) in page view',
-      (WidgetTester tester) async {
-    final itemPositionsListener = ItemPositionsListener.create();
-    final itemScrollController = ItemScrollController();
+    'Maintain programmatic and user position (9 half way off top) in page view',
+    (WidgetTester tester) async {
+      final itemPositionsListener = ItemPositionsListener.create();
+      final itemScrollController = ItemScrollController();
 
-    tester.binding.window.devicePixelRatioTestValue = 1.0;
-    tester.binding.window.physicalSizeTestValue =
-        const Size(screenWidth, screenHeight);
+      tester.binding.window.devicePixelRatioTestValue = 1.0;
+      tester.binding.window.physicalSizeTestValue =
+          const Size(screenWidth, screenHeight);
 
-    await tester.pumpWidget(
-      MaterialApp(
-        home: PageView(
-          children: [
-            KeyedSubtree(
-              key: const PageStorageKey('key'),
-              child: ScrollablePositionedList.builder(
-                itemCount: defaultItemCount,
-                itemScrollController: itemScrollController,
-                itemBuilder: (context, index) => SizedBox(
-                  height: itemHeight,
-                  child: Text('Item $index'),
+      await tester.pumpWidget(
+        MaterialApp(
+          home: PageView(
+            children: [
+              KeyedSubtree(
+                key: const PageStorageKey('key'),
+                child: ScrollablePositionedList.builder(
+                  itemCount: defaultItemCount,
+                  itemScrollController: itemScrollController,
+                  itemBuilder: (context, index) => SizedBox(
+                    height: itemHeight,
+                    child: Text('Item $index'),
+                  ),
+                  itemPositionsListener: itemPositionsListener,
                 ),
-                itemPositionsListener: itemPositionsListener,
               ),
-            ),
-            const Center(
-              child: Text('Test'),
-            )
-          ],
+              const Center(
+                child: Text('Test'),
+              )
+            ],
+          ),
         ),
-      ),
-    );
+      );
 
-    itemScrollController.jumpTo(index: 9);
-    await tester.pump();
+      itemScrollController.jumpTo(index: 9);
+      await tester.pump();
 
-    expect(tester.getBottomRight(find.text('Item 9')).dy, itemHeight);
+      expect(tester.getBottomRight(find.text('Item 9')).dy, itemHeight);
 
-    await tester.drag(
-        find.byType(ScrollablePositionedList), const Offset(0, -itemHeight));
-    await tester.pumpAndSettle();
+      await tester.drag(
+          find.byType(ScrollablePositionedList), const Offset(0, -itemHeight));
+      await tester.pumpAndSettle();
 
-    final item9Bottom = tester.getBottomRight(find.text('Item 9')).dy;
-    expect(item9Bottom, lessThan(itemHeight));
+      final item9Bottom = tester.getBottomRight(find.text('Item 9')).dy;
+      expect(item9Bottom, lessThan(itemHeight));
 
-    await tester.drag(find.byType(PageView), const Offset(-500, 0));
-    await tester.pumpAndSettle();
+      await tester.drag(find.byType(PageView), const Offset(-500, 0));
+      await tester.pumpAndSettle();
 
-    await tester.drag(find.byType(PageView), const Offset(500, 0));
-    await tester.pumpAndSettle();
+      await tester.drag(find.byType(PageView), const Offset(500, 0));
+      await tester.pumpAndSettle();
 
-    expect(tester.getBottomRight(find.text('Item 9')).dy, item9Bottom);
+      expect(tester.getBottomRight(find.text('Item 9')).dy, item9Bottom);
 
-    expect(
-        itemPositionsListener.itemPositions.value
-            .firstWhere((position) => position.index == 9)
-            .itemLeadingEdge,
-        -(itemHeight / screenHeight) / 2);
-    expect(
-        itemPositionsListener.itemPositions.value
-            .firstWhere((position) => position.index == 9)
-            .itemTrailingEdge,
-        (itemHeight / screenHeight) / 2);
-  });
+      expect(
+          itemPositionsListener.itemPositions.value
+              .firstWhere((position) => position.index == 9)
+              .itemLeadingEdge,
+          -(itemHeight / screenHeight) / 2);
+      expect(
+          itemPositionsListener.itemPositions.value
+              .firstWhere((position) => position.index == 9)
+              .itemTrailingEdge,
+          (itemHeight / screenHeight) / 2);
+    },
+  );
 
   testWidgets('List with no items', (WidgetTester tester) async {
     final itemScrollController = ItemScrollController();
@@ -1746,7 +1751,10 @@ void main() {
               itemScrollController: itemScrollController,
               itemPositionsListener: itemPositionsListener,
               itemBuilder: (context, index) {
-                assert(index >= 0 && index <= itemCount - 1);
+                assert(
+                  index >= 0 && index <= itemCount - 1,
+                  'index must be in the range of 0 to itemCount - 1',
+                );
                 return SizedBox(
                   height: itemHeight,
                   child: Text('Item $index'),
@@ -1788,7 +1796,10 @@ void main() {
               initialScrollIndex: min(100, itemCount - 1),
               itemCount: itemCount,
               itemBuilder: (context, index) {
-                assert(index >= 0 && index <= itemCount - 1);
+                assert(
+                  index >= 0 && index <= itemCount - 1,
+                  'index must be in the range of 0 to itemCount - 1',
+                );
                 return SizedBox(
                   height: itemHeight,
                   child: Text('Item $index'),
@@ -1827,7 +1838,10 @@ void main() {
               initialScrollIndex: itemCount - 1,
               itemCount: itemCount,
               itemBuilder: (context, index) {
-                assert(index >= 0 && index <= itemCount - 1);
+                assert(
+                  index >= 0 && index <= itemCount - 1,
+                  'index must be in the range of 0 to itemCount - 1',
+                );
                 return SizedBox(
                   height: itemHeight,
                   child: Text('Item $index'),

packages/stream_chat_flutter/test/scrollable_positioned_list/shrink_wrap_position_list_test.dart

@@ -31,12 +31,13 @@ void main() {
 
     await tester.pumpWidget(
       MaterialApp(
-        // Use flex layout to ensure that the minimum height is not limited to screenHeight
+        // Use flex layout to ensure that the minimum height is not limited to
+        // screenHeight.
         home: Column(children: [
           // Use Constrained to make max height not more than screenHeight
           ConstrainedBox(
-            constraints:
-                const BoxConstraints(maxHeight: screenHeight, maxWidth: screenWidth),
+            constraints: const BoxConstraints(
+                maxHeight: screenHeight, maxWidth: screenWidth),
             child: PositionedList(
               key: key,
               itemCount: itemCount,
@@ -292,73 +293,75 @@ void main() {
   });
 
   testWidgets(
-      'List positioned with 5 at top then scroll up 2 programatically and shrink wrap',
-      (WidgetTester tester) async {
-    final scrollController = ScrollController();
-    await setUpWidgetTest(tester,
-        topItem: 5, scrollController: scrollController);
+    '''List positioned with 5 at top then scroll up 2 programatically and shrink wrap''',
+    (WidgetTester tester) async {
+      final scrollController = ScrollController();
+      await setUpWidgetTest(tester,
+          topItem: 5, scrollController: scrollController);
 
-    scrollController.jumpTo(-2 * itemHeight);
-    await tester.pump();
+      scrollController.jumpTo(-2 * itemHeight);
+      await tester.pump();
 
-    expect(find.text('Item 2'), findsNothing);
-    expect(find.text('Item 3'), findsOneWidget);
-    expect(find.text('Item 12'), findsOneWidget);
-    expect(find.text('Item 13'), findsNothing);
+      expect(find.text('Item 2'), findsNothing);
+      expect(find.text('Item 3'), findsOneWidget);
+      expect(find.text('Item 12'), findsOneWidget);
+      expect(find.text('Item 13'), findsNothing);
 
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 2)
-            .itemLeadingEdge,
-        -1 / 10);
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 3)
-            .itemLeadingEdge,
-        0);
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 12)
-            .itemTrailingEdge,
-        1);
-  });
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 2)
+              .itemLeadingEdge,
+          -1 / 10);
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 3)
+              .itemLeadingEdge,
+          0);
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 12)
+              .itemTrailingEdge,
+          1);
+    },
+  );
 
   testWidgets(
-      'List positioned with 5 at top then scroll down 20 programatically and shrink wrap',
-      (WidgetTester tester) async {
-    final scrollController = ScrollController();
-    await setUpWidgetTest(tester,
-        topItem: 5, scrollController: scrollController);
+    '''List positioned with 5 at top then scroll down 20 programatically and shrink wrap''',
+    (WidgetTester tester) async {
+      final scrollController = ScrollController();
+      await setUpWidgetTest(tester,
+          topItem: 5, scrollController: scrollController);
 
-    scrollController.jumpTo(itemHeight * 20);
-    await tester.pump();
+      scrollController.jumpTo(itemHeight * 20);
+      await tester.pump();
 
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 23)
-            .itemLeadingEdge,
-        -2 / 10);
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 24)
-            .itemLeadingEdge,
-        -1 / 10);
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 25)
-            .itemLeadingEdge,
-        0);
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 4)
-            .itemLeadingEdge,
-        -21 / 10);
-    expect(
-        itemPositionsNotifier.itemPositions.value
-            .firstWhere((position) => position.index == 5)
-            .itemLeadingEdge,
-        -20 / 10);
-  });
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 23)
+              .itemLeadingEdge,
+          -2 / 10);
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 24)
+              .itemLeadingEdge,
+          -1 / 10);
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 25)
+              .itemLeadingEdge,
+          0);
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 4)
+              .itemLeadingEdge,
+          -21 / 10);
+      expect(
+          itemPositionsNotifier.itemPositions.value
+              .firstWhere((position) => position.index == 5)
+              .itemLeadingEdge,
+          -20 / 10);
+    },
+  );
 
   testWidgets(
       'List positioned with 5 at top and initial scroll offset and shrink wrap',
@@ -424,7 +427,8 @@ void main() {
 
     await tester.pumpWidget(
       MaterialApp(
-        // Use flex layout to ensure that the minimum height is not limited to screenHeight
+        // Use flex layout to ensure that the minimum height is not limited to
+        // screenHeight.
         home: PositionedList(
           itemCount: 5,
           itemBuilder: (context, index) {

packages/stream_chat_flutter/test/scrollable_positioned_list/shrink_wrap_scrollable_position_list_test.dart

@@ -27,12 +27,13 @@ void main() {
 
     await tester.pumpWidget(
       MaterialApp(
-        // Use flex layout to ensure that the minimum height is not limited to screenHeight
+        // Use flex layout to ensure that the minimum height is not limited to
+        // screenHeight.
         home: Column(children: [
           // Use Constrained to make max height not more than screenHeight
           ConstrainedBox(
-            constraints:
-                const BoxConstraints(maxHeight: screenHeight, maxWidth: screenWidth),
+            constraints: const BoxConstraints(
+                maxHeight: screenHeight, maxWidth: screenWidth),
             child: ScrollablePositionedList.builder(
               itemCount: itemCount,
               initialScrollIndex: initialIndex,