Merge branch 'develop' into S-ecki/develop

This commit is contained in:
Salvatore Giordano
2022-03-21 11:53:00 +01:00
4 changed files with 28 additions and 1 deletions
@@ -15,6 +15,7 @@ on:
jobs:
analyze:
timeout-minutes: 15
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- name: "Git Checkout"
@@ -45,6 +46,7 @@ jobs:
format:
runs-on: ubuntu-latest
if: github.event.pull_request.draft == false
timeout-minutes: 15
steps:
- name: "Git Checkout"
@@ -73,6 +75,7 @@ jobs:
test:
runs-on: macos-latest
if: github.event.pull_request.draft == false
timeout-minutes: 20
steps:
- name: "Git Checkout"
@@ -123,3 +126,12 @@ jobs:
with:
path: packages/stream_chat_flutter/coverage/lcov.info
min_coverage: 67
draft-build:
runs-on: ubuntu-latest
if: github.event.pull_request.draft == true
timeout-minutes: 1
steps:
- name: Run a one-line script
run: echo Draft PR, you are good.
@@ -11,6 +11,12 @@
- Mentions overlay now doesn't overflow when there is not enough height available
- Updated `stream_chat_flutter_core` dependency to [`3.5.1`](https://pub.dev/packages/stream_chat_flutter_core/changelog).
✅ Added
- `onLinkTap` for `MessageWidget` can now be passed down to `UrlAttachment`.
## 3.5.0
🐞 Fixed
@@ -14,6 +14,7 @@ class UrlAttachment extends StatelessWidget {
horizontal: 16,
vertical: 8,
),
this.onLinkTap,
}) : super(key: key);
/// Attachment to be displayed
@@ -28,13 +29,20 @@ class UrlAttachment extends StatelessWidget {
/// [MessageThemeData] for showing image title
final MessageThemeData messageTheme;
/// The function called when tapping on a link
final void Function(String)? onLinkTap;
@override
Widget build(BuildContext context) {
final chatThemeData = StreamChatTheme.of(context);
return GestureDetector(
onTap: () {
final titleLink = urlAttachment.titleLink;
if (titleLink != null) launchURL(context, titleLink);
if (titleLink != null) {
onLinkTap != null
? onLinkTap!(titleLink)
: launchURL(context, titleLink);
}
},
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
@@ -1013,6 +1013,7 @@ class _MessageWidgetState extends State<MessageWidget>
hostDisplayName: hostDisplayName,
textPadding: widget.textPadding,
messageTheme: widget.messageTheme,
onLinkTap: widget.onLinkTap,
);
}