talksik/stream-chat-flutter
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: tests

Browse Source
This commit is contained in:
Deven Joshi
2021-02-03 14:31:25 +05:30
parent 2cd5eed245
commit 4fa6581f19
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/stream_chat_flutter/lib/src/channel_media_display_screen.dart
+4 -4
View File
@@ -33,7 +33,7 @@ class ChannelMediaDisplayScreen extends StatefulWidget {
} }
class _ChannelMediaDisplayScreenState extends State<ChannelMediaDisplayScreen> { class _ChannelMediaDisplayScreenState extends State<ChannelMediaDisplayScreen> {
Map<String, VideoPlayerController> _controllerCache = {}; Map<String, VideoPlayerController> controllerCache = {};
@override @override
void initState() { void initState() {
@@ -149,12 +149,12 @@ class _ChannelMediaDisplayScreenState extends State<ChannelMediaDisplayScreen> {
.forEach((e) { .forEach((e) {
VideoPlayerController controller; VideoPlayerController controller;
if (e.type == 'video') { if (e.type == 'video') {
var cachedController = _controllerCache[e.assetUrl]; var cachedController = controllerCache[e.assetUrl];
if (cachedController == null) { if (cachedController == null) {
controller = VideoPlayerController.network(e.assetUrl); controller = VideoPlayerController.network(e.assetUrl);
controller.initialize(); controller.initialize();
_controllerCache[e.assetUrl] = controller; controllerCache[e.assetUrl] = controller;
} else { } else {
controller = cachedController; controller = cachedController;
} }
@@ -234,7 +234,7 @@ class _ChannelMediaDisplayScreenState extends State<ChannelMediaDisplayScreen> {
@override @override
void dispose() { void dispose() {
super.dispose(); super.dispose();
for (var c in _controllerCache.values) { for (var c in controllerCache.values) {
c.dispose(); c.dispose();
} }
} }
packages/stream_chat_flutter_core/test/stream_chat_core_test.dart
+3 -1
View File
@@ -86,7 +86,7 @@ void main() {
testWidgets( testWidgets(
'StreamChatCore should disconnect on background', 'StreamChatCore should disconnect on background',
(WidgetTester tester) async { (WidgetTester tester) async {
await fakeAsync((_async) { fakeAsync((_async) {
final client = MockClient(); final client = MockClient();
final clientState = MockClientState(); final clientState = MockClientState();
final channel = MockChannel(); final channel = MockChannel();
@@ -123,6 +123,7 @@ void main() {
_async.elapse(Duration(seconds: 5)); _async.elapse(Duration(seconds: 5));
verify(client.disconnect()).called(1); verify(client.disconnect()).called(1);
eventStreamController.close();
}); });
}, },
); );
@@ -174,6 +175,7 @@ void main() {
await untilCalled(showLocalNotificationMock(event)); await untilCalled(showLocalNotificationMock(event));
verify(showLocalNotificationMock(event)).called(1); verify(showLocalNotificationMock(event)).called(1);
eventStreamController.close();
}, },
); );
} }