From 4fa6581f190061862ac3ee3cbfe9ea46d3590054 Mon Sep 17 00:00:00 2001 From: Deven Joshi Date: Wed, 3 Feb 2021 14:31:25 +0530 Subject: [PATCH] fix: tests --- .../lib/src/channel_media_display_screen.dart | 8 ++++---- .../test/stream_chat_core_test.dart | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/channel_media_display_screen.dart b/packages/stream_chat_flutter/lib/src/channel_media_display_screen.dart index ba7291d6..8e9f566c 100644 --- a/packages/stream_chat_flutter/lib/src/channel_media_display_screen.dart +++ b/packages/stream_chat_flutter/lib/src/channel_media_display_screen.dart @@ -33,7 +33,7 @@ class ChannelMediaDisplayScreen extends StatefulWidget { } class _ChannelMediaDisplayScreenState extends State { - Map _controllerCache = {}; + Map controllerCache = {}; @override void initState() { @@ -149,12 +149,12 @@ class _ChannelMediaDisplayScreenState extends State { .forEach((e) { VideoPlayerController controller; if (e.type == 'video') { - var cachedController = _controllerCache[e.assetUrl]; + var cachedController = controllerCache[e.assetUrl]; if (cachedController == null) { controller = VideoPlayerController.network(e.assetUrl); controller.initialize(); - _controllerCache[e.assetUrl] = controller; + controllerCache[e.assetUrl] = controller; } else { controller = cachedController; } @@ -234,7 +234,7 @@ class _ChannelMediaDisplayScreenState extends State { @override void dispose() { super.dispose(); - for (var c in _controllerCache.values) { + for (var c in controllerCache.values) { c.dispose(); } } diff --git a/packages/stream_chat_flutter_core/test/stream_chat_core_test.dart b/packages/stream_chat_flutter_core/test/stream_chat_core_test.dart index a8d7e227..40880dfc 100644 --- a/packages/stream_chat_flutter_core/test/stream_chat_core_test.dart +++ b/packages/stream_chat_flutter_core/test/stream_chat_core_test.dart @@ -86,7 +86,7 @@ void main() { testWidgets( 'StreamChatCore should disconnect on background', (WidgetTester tester) async { - await fakeAsync((_async) { + fakeAsync((_async) { final client = MockClient(); final clientState = MockClientState(); final channel = MockChannel(); @@ -123,6 +123,7 @@ void main() { _async.elapse(Duration(seconds: 5)); verify(client.disconnect()).called(1); + eventStreamController.close(); }); }, ); @@ -174,6 +175,7 @@ void main() { await untilCalled(showLocalNotificationMock(event)); verify(showLocalNotificationMock(event)).called(1); + eventStreamController.close(); }, ); }