Reverting to slicebased memdb after checking benchmark.

ipe/db.go

@@ -18,50 +18,38 @@ type db interface {
 	AddApp(*app) error
 }
 
-// memdb is an in memory implementation of db interface
 type memdb struct {
-	IDMutex     sync.Mutex
-	KeyMutex    sync.Mutex
-	AppsByAppID map[string]*app
-	AppsByKey   map[string]*app
+	sync.Mutex
+	Apps []*app
 }
 
-func newMemdb() *memdb {
-	return &memdb{
-		AppsByAppID: make(map[string]*app),
-		AppsByKey:   make(map[string]*app),
-	}
+func newMemdb() db {
+	return &memdb{}
 }
 
 func (db *memdb) AddApp(a *app) error {
-	db.IDMutex.Lock()
-	db.AppsByAppID[a.AppID] = a
-	db.IDMutex.Unlock()
-
-	db.KeyMutex.Lock()
-	db.AppsByKey[a.Key] = a
-	db.KeyMutex.Unlock()
+	db.Lock()
+	db.Apps = append(db.Apps, a)
+	db.Unlock()
 	return nil
 }
 
 // GetAppByAppID returns an App with by appID
 func (db *memdb) GetAppByAppID(appID string) (*app, error) {
-	db.IDMutex.Lock()
-	a, ok := db.AppsByAppID[appID]
-	db.IDMutex.Unlock()
-	if ok {
-		return a, nil
+	for _, a := range db.Apps {
+		if a.AppID == appID {
+			return a, nil
+		}
 	}
 	return nil, errors.New("App not found")
 }
 
 // GetAppByKey returns an App with by key
 func (db *memdb) GetAppByKey(key string) (*app, error) {
-	db.KeyMutex.Lock()
-	a, ok := db.AppsByKey[key]
-	db.KeyMutex.Unlock()
-	if ok {
-		return a, nil
+	for _, a := range db.Apps {
+		if a.Key == key {
+			return a, nil
+		}
 	}
 	return nil, errors.New("App not found")
 }

ipe/db_test.go

@@ -6,6 +6,19 @@ package ipe
 
 import "testing"
 
+func Benchmark_memdb_GetAppByAppID(b *testing.B) {
+	db := newMemdb()
+	db.AddApp(&app{AppID: "123456", Name: "Example"})
+	db.AddApp(&app{AppID: "654321", Name: "Example2"})
+	db.AddApp(&app{AppID: "678901", Name: "Example3"})
+
+	b.ResetTimer()
+
+	for i := 0; i < b.N; i++ {
+		db.GetAppByAppID("123456")
+	}
+}
+
 func Test_db_GetAppByAppID(t *testing.T) {
 	app := &app{AppID: "123456", Name: "Example"}