Commit Graph
11 Commits
Author SHA1 Message Date
Ben KraftandGitHub 700392315a Enable golangci-lint (#49)
## Summary:
It would be nice to have some linting beyond `go vet`!  Now we do.  I
started by copying the config from Khan/webapp.  I did remove a couple
of staticcheck checks that I didn't feel were useful.  (Note also that
exportloopref is the replacement for scopelint in newer golangci-lint.)

Included are all the needed lint fixes; most are stylistic but the
changes in the example are a (minor) bugfix.

Fixes #22.
Issue: https://github.com/Khan/genqlient/issues/22

## Test plan:
make check

Author: benjaminjkraft

Reviewers: aberkan, dnerdy, benjaminjkraft, csilvers, MiguelCastillo

Required Reviewers: 

Approved by: aberkan, dnerdy

Checks:  Test (1.17),  Test (1.16),  Test (1.15),  Test (1.14),  Test (1.13),  Lint,  Test (1.17),  Test (1.16),  Test (1.15),  Test (1.14),  Test (1.13),  Lint

Pull request URL: https://github.com/Khan/genqlient/pull/49
2021-08-20 10:39:12 -07:00
Ben Kraft c34c5ff505 Turn on test coverage in Makefile/actions 2021-04-23 18:18:07 -07:00
Ben Kraft 77804e3475 naming things 2021-04-02 18:13:10 -07:00
Ben Kraft 9c8cf02181 proper test wiring for example test in github actions 2021-04-02 18:04:05 -07:00
Ben Kraft efc6549d7e fix example args in github actions 2021-04-02 17:18:37 -07:00
Ben Kraft 5ab592ac18 try example in github actions again 2021-04-02 17:17:38 -07:00
Ben Kraft 088ec53ad5 fix branch name in github actions 2021-03-22 18:14:16 -07:00
Ben Kraft a42c9b8166 clean up various TODOs and comments 2021-03-22 18:11:51 -07:00
Ben Kraft 6caa3fc6c4 Give up on running example in GitHub Actions for now 2020-03-27 16:27:08 -07:00
Ben Kraft 654a5c6795 Explicitly pass envvar in github workflow 2020-03-27 16:10:48 -07:00
Ben KraftandGitHub 7b03ec7a83 Set up github actions 2020-03-27 16:05:00 -07:00