talksik/fl-query
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

QueryObserver bug-hunt ongoing

Browse Source
This commit is contained in:
Kingkor Roy Tirtho
2022-04-28 13:14:37 +06:00
parent 421aa85bce
commit fe558c0cb7
2 changed files with 27 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/fl_query/lib/src/core/query_observer.dart
+1 -2
View File
@@ -237,8 +237,7 @@ class QueryObserver<
if (!result.isFetching) {
unsubscribe?.call();
if (result.isError && throwOnError == true) {
if (!completer.isCompleted)
completer.completeError(result.error as Object);
if (!completer.isCompleted) completer.completeError(result.error);
} else {
if (!completer.isCompleted)
completer.complete(
packages/fl_query/test/src/core/query_observer_test.dart
+26 -22
View File
@@ -148,7 +148,6 @@ void main() {
}
select2(_data) {
print(StackTrace.current);
count++;
return {"myCount": 99};
}
@@ -514,37 +513,42 @@ void main() {
enabled: false,
));
var error;
observer.getNextResult(true).catchError((e) {
await observer.getNextResult(true).catchError((e) async {
error = e;
return e;
});
queryClient
await queryClient
.prefetchQuery<Map<String, dynamic>, dynamic, Map<String, dynamic>>(
queryKey: key, queryFn: (_) => Future.error('reject'));
await sleep(50);
expect(error, 'reject');
});
}, skip: true);
test('should stop retry when unsubscribing', () async {
final key = queryKey();
int count = 0;
final observer = new QueryObserver<Map<String, dynamic>, dynamic,
Map<String, dynamic>, Map<String, dynamic>>(
queryClient,
QueryObserverOptions<Map<String, dynamic>, dynamic,
try {
final key = queryKey();
final observer = new QueryObserver<Map<String, dynamic>, dynamic,
Map<String, dynamic>, Map<String, dynamic>>(
queryKey: key,
queryFn: (_) {
count++;
return Future.error({"data": 'reject'});
},
retry: (_, __) => 10,
retryDelay: (_, __) => 50,
),
);
final unsubscribe = observer.subscribe();
await sleep(70);
unsubscribe();
await sleep(200);
queryClient,
QueryObserverOptions<Map<String, dynamic>, dynamic,
Map<String, dynamic>, Map<String, dynamic>>(
queryKey: key,
queryFn: (_) {
count++;
return Future.error({"data": 'reject'});
},
retry: (_, __) => 10,
retryDelay: (_, __) => 50,
),
);
final unsubscribe = observer.subscribe();
await sleep(70);
unsubscribe();
await sleep(200);
} catch (e) {
print("ERROR OCCURRED $e");
}
expect(count, 2);
});