deadlock comment

crates/livekit-core/src/rtc_engine/mod.rs

@@ -66,15 +66,12 @@ pub enum EngineEvent {
         rtp_receiver: RtpReceiver,
         streams: Vec<MediaStream>,
     },
-    Connected,
     Resuming,
     Resumed,
-    SignalResumed,
     Restarting,
     Restarted,
 }
 
-//
 // TODO(theomonnom): Smarter retry intervals
 pub(crate) const RECONNECT_ATTEMPTS: u32 = 10;
 pub(crate) const RECONNECT_INTERVAL: Duration = Duration::from_millis(300);

crates/livekit-core/src/rtc_engine/rtc_session.rs

@@ -220,6 +220,7 @@ impl RTCSession {
     }
 
     /// Close the PeerConnections and the SignalClient
+    #[tracing::instrument]
     pub async fn close(self) {
         // Close the tasks
         self.close_emitter.send(true);
@@ -468,13 +469,14 @@ impl SessionInner {
         });
     }
 
+    #[tracing::instrument]
     async fn close(&self) {
         self.signal_client.close().await;
         self.publisher_pc.lock().await.close();
         self.subscriber_pc.lock().await.close();
     }
 
-    #[tracing::instrument]
+    #[tracing::instrument(skip(data))]
     async fn publish_data(
         &self,
         data: &DataPacket,
@@ -577,6 +579,7 @@ impl SessionInner {
             }
         };
 
+        // TODO(theomonnom) Avoid 15 seconds deadlock on the RTCEngine by recv close here
         tokio::select! {
             _ = wait_connected => Ok(()),
             _ = sleep(MAX_ICE_CONNECT_TIMEOUT) => {