fix(desktop): keep Escape inside compose instead of exiting the stream #294

Merged
talksik merged 1 commits from claude/escape-key-compose-review-a496b2 into main 2026-06-21 15:32:59 +00:00

1 Commits

Author SHA1 Message Date
Claude 4f7fee538b fix(desktop): keep Escape inside compose instead of exiting the stream
While recording or reviewing a compose, Escape both cancelled the compose
and exited the stream. The stream's window-level navigation handler skips
keys when an input is focused (isTypingTarget), which is why the text path
was unaffected, but recording/reviewing have no focused input so Escape
leaked through to the exit handler.

Fix it at the compose layer rather than teaching the navigation pipe about
compose: the compose key handler now consumes (preventDefault +
stopPropagation) any key it handles and listens in the capture phase, so it
reliably wins over the stream's bubble-phase navigation/action handlers
regardless of listener registration order. Pure pause states (hold-space)
are untouched, so Escape still exits the stream there.

This leaves the typing/task/configuring paths equivalent (their onCancel is
the same cancel() the handler invokes) while ⌘+Enter / ⌘+M still fall
through to the text editor.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DapjFX1MhYPZeJv4s56K5L
2026-06-21 01:23:09 +00:00