fix: remove settings option from stream-view #277

Merged
talksik merged 2 commits from cleanup-stream-view-options into main 2026-06-11 23:51:37 +00:00
talksik commented 2026-06-11 23:25:34 +00:00 (Migrated from github.com)

Summary by CodeRabbit

  • Changes
    • Removed the "Settings" option from the stream top-bar dropdown menu.
    • Stream top-bar menu simplified—fewer actions displayed in the dropdown.
    • Access to settings remains available through other parts of the app, so workflow for managing preferences is unchanged.
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Changes** * Removed the "Settings" option from the stream top-bar dropdown menu. * Stream top-bar menu simplified—fewer actions displayed in the dropdown. * Access to settings remains available through other parts of the app, so workflow for managing preferences is unchanged. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
coderabbitai[bot] commented 2026-06-11 23:25:49 +00:00 (Migrated from github.com)

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 541a80ab-e111-4f06-bee4-88c633aed0d5

📥 Commits

Reviewing files that changed from the base of the PR and between 202c7180da and 6ebf4abc72.

📒 Files selected for processing (1)
  • js/desktop/src/features/particles/stream-top-bar.tsx
💤 Files with no reviewable changes (1)
  • js/desktop/src/features/particles/stream-top-bar.tsx

📝 Walkthrough

Walkthrough

The stream top-bar actions dropdown no longer includes a Settings entry; the Settings icon import, the useNavigate hook usage, and the dropdown item linking to /settings were removed from the component.

Changes

Stream Top Bar Settings Removal

Layer / File(s) Summary
Remove Settings menu item
js/desktop/src/features/particles/stream-top-bar.tsx
Settings icon import from lucide-react is removed, useNavigate and its initialization are deleted, and the dropdown menu item navigating to /settings is removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops past code tonight,
A cog removed, the menu light,
No gear to turn, no path to roam,
The top bar finds a quieter home. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the settings option from the stream-view dropdown menu, which is clearly reflected in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup-stream-view-options

Comment @coderabbitai help to get the list of available commands and usage tips.

<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- review_stack_entry_start --> [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/flowy-live/llink/pull/277?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> No actionable comments were generated in the recent review. 🎉 <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `541a80ab-e111-4f06-bee4-88c633aed0d5` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 202c7180dacf8ec646b82e7bf6eea6e34139191b and 6ebf4abc72ca759385dc3edb4911ca48293d5826. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `js/desktop/src/features/particles/stream-top-bar.tsx` </details> <details> <summary>💤 Files with no reviewable changes (1)</summary> * js/desktop/src/features/particles/stream-top-bar.tsx </details> </details> --- <!-- walkthrough_start --> <details> <summary>📝 Walkthrough</summary> ## Walkthrough The stream top-bar actions dropdown no longer includes a Settings entry; the Settings icon import, the `useNavigate` hook usage, and the dropdown item linking to `/settings` were removed from the component. ## Changes **Stream Top Bar Settings Removal** |Layer / File(s)|Summary| |---|---| |**Remove Settings menu item** <br> `js/desktop/src/features/particles/stream-top-bar.tsx`|Settings icon import from `lucide-react` is removed, `useNavigate` and its initialization are deleted, and the dropdown menu item navigating to `/settings` is removed.| ## Estimated code review effort 🎯 1 (Trivial) | ⏱️ ~2 minutes ## Poem > A rabbit hops past code tonight, > A cog removed, the menu light, > No gear to turn, no path to roam, > The top bar finds a quieter home. 🐰✨ </details> <!-- walkthrough_end --> <!-- pre_merge_checks_walkthrough_start --> <details> <summary>🚥 Pre-merge checks | ✅ 5</summary> <details> <summary>✅ Passed checks (5 passed)</summary> | Check name | Status | Explanation | | :------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------ | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title accurately describes the main change: removing the settings option from the stream-view dropdown menu, which is clearly reflected in the changeset. | | Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | </details> <sub>✏️ Tip: You can configure your own custom pre-merge checks in the settings.</sub> </details> <!-- pre_merge_checks_walkthrough_end --> <!-- finishing_touch_checkbox_start --> <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> Create stacked PR - [ ] <!-- {"checkboxId": "3e1879ae-f29b-4d0d-8e06-d12b7ba33d98"} --> Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Create PR with unit tests - [ ] <!-- {"checkboxId": "6ba7b810-9dad-11d1-80b4-00c04fd430c8", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Commit unit tests in branch `cleanup-stream-view-options` </details> </details> <!-- finishing_touch_checkbox_end --> <!-- tips_start --> --- <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub> <!-- tips_end --> <!-- internal state start --> <!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEejqANiS4AzeAA8uFEs3xTIiErnEYiyfNzi+Fg2FCweuM5ozGAS8CQA7gYActjMApRcAEwA7DkGAKoASgAyXLDe3IgcAPQ1ROqw2AIaTMw1Nhb4CbJgFpIkNRb9GADWNdzYwzW5+QWeFFy4aBajiPCjBgDK+NgUDCSQAlQYDLBcDFaY2NxgiJEk0bHxCWABQRiIBtBoFKS4RxOZy4zG0GG2y1w2Gq/G4ZAMRRIcUSlBhBhKKhIFjRAGEojR6NRsgAGLIANjAxIpAEZqdAsgBmDhZACsHAZABYAFpGfTGcBQMj0fA2HAEYhkZQEhSsdhcXj8YSicRSGTyJhKKiqdRaHR8kxQOCoVCYMWEUjkKjStpsDCcSBUBIeNKgijyOQKTUqNSabS6MCGfmmAxCRA1JSIUYEbg1RD7DqPKHOMPcX7iS7SWMPJ7RsACX4aXCIRwGABE5YMAGJK5AAIIASQlluodGdrF+8hFjFgmFIXwM9awAANQ+HpFGArH4zZE3tM6mKOmrGH7lEYrn8xRC8WhwAaSC4WCHVePZgHgJ537oMTwYLIWhhbi0bpYDD4SBdXyUfg2GcUZBoJAgA4BFsXg+H4gC4BLCHwaDAR6eocziuKqB7wUOoHePAviIEOKBMCEYRnoehxDhY2AMPAShgFEYi4fAzDcPgi4ARg9BKFYNDIMRkAPgEz4JFg6guKh1A8M4cS7IgFjyBgaBxEQLb0AQkBDrGYFYX4Q6wTiTHJoxrEadJ+7cXYViAJgEyBDtCJDJHJ8AKTQdEMUxAKYPQQ6yfJLa4bA+D4KMkDQmgpDoM4DouG4dAaEYRjVnWFg0Fat6fOeqGHEoly/NQyX+KKJD2Ixi6tkxPDNP0DCQOw6jxP2yTBCQ0Xolh0jdr2dBcAA1MSNRgPkBgAKL3PRikIeFyJOiQv4uVwACydDwGkZYVgYfIGAalWsT+ZpNlKrY2nKDpoE6iAuh2Rzqooyjar6eoBmtApwcaLHbRau30PtdpcEoyzwFY72XUcXQMAFJ3tm6h1fmqCFaj6ur+oGADaADepYnKQ9a0KWHCo21AD6HK0NSNhkgyACcAAcHIEyypa7qWqaHljpajhGE4xnGDAJtQc4pmm8AZiu2brhem7bvYtOlvcaYlM1WPUnTQoy+Qct06DrqyEziLIS13FWZ4tleY5KDOYukChOEQ40bg1G7IlYDPswuFoMg6goMgb4fsEpB8OQdCtmgNiJeFyEaWlwEYeBiBQWgN7BBoEsaiQABCQOjDpDFWPY6ga9jXQJKWAC+u4o2jJAY0zpe47kZIsiQWQMAIDBklkxISwzsBMyz47RlOnMztzyYTHzAtZmuYAbgWRbi6ryyLkrJBY1k8ulorsvMlkqunW6TMACKPlxaERxpOF4cEZuEWHpHkZRJDUY8tHG4VAL9Pc8d04nKf4MD6fcJn2dM3nQuxccZfnLtjSuDByZoByNSBgM4MgchpnTduncwysx7hzLmSZ5zD2XKPU848RaT2LBLKWc8145AZArVi88saUM3mDHOpYtaRQPiRayBt7ItgABQAEo6IYGqiseAAAvbKZ9uEeTsg5EguEJC/HgCoKwvCUCfBvipaAAQk6/C0gnS6n9v4sF/vlf+uduhAJLm1MBIDSC4xZAyBx1IchoFruTXIbdqAd2xl3SMGDpyzkHguJcmYTw5iIVuKepDZ64FoevFk1DaCxKyLkBh6td5Yi8DreCvEnwvkgLabAG1IjyBsCVEC6lsIQX3FhS42BaCh3UJZNSmFsK4U8lwj4RwSA9gkluPRSgDFpyMX/XATC2D1LSIXAAukGQUm0uxoDwOaSUVo9osFtPab62g/qjQEKnNs6sIZ9nOtDb0Oo/T6gejadQuNKKIFxuJF4dBcZkIBKtdaLd64wPJsSWgMcbDk1EGSDkZIBBuJIDkAQxMSCPDJCQTk1IybUlJtSAQ8N7oQEgHCqFHIVAMByPXaBLJSYMnJiyWgDAGR0AEByFFsC0AcjcSS2gLI3FknRRiqA1zcC3NoPcx5KJaC4yFOi9avASC4zYH8CVZxRBrBedEjlSMDCQEgKWJAAAFIogy6Dpw2Rq/A9w6BYzNisTwu4VVqqQAAeSkBQCglElAYBNTYM1JALWqtLM+Bgq4NI6TtcFMudpKCyQsFsSEC8uBIyLpa0sicihnNwAAdTCDQDVFBzC4CsC6t1Hq1WIF8lMWggytU5uxO62N9TaBFGwBgHeX9w0OuwjiI8wMTWRGwBWz1Vaa0YEzVYFtcr20UE7Xmr1lFe072kAwB1gRkqDrbbYXNsaRijDoPWRAJ1pCNpNeWMdFhna4AXaMREJ0EqIBNQjS1qrlWqrvWq2VwNbJsF3VOxAM74BzrPse2m1672S0hNCYdo6/2evyr/TA4jnVcFLMejwoxP1wnoFAHSSgE3XQspABARBYB9CRFiA5Z1UBkCUVFX997PWuCULuhIvxBG+HIxR0sTF7JYRWMe59ka1URg/V+51f6Y33tvUxx9oxOO7v7YcUTjH70Ae5hepYI6u1MfAwe2SHwJPwXEFmw4McGB7BbNJHi06HUZDYfksErUvxOAinEXwYdPAtL8NBZK59wjcVCTEcaPFHz8SwAU/cCQEBnDdowK4FAjPOE6MqVsWEw5nDao5t+oG1XJnwGRDTXAMBTAsHm2TVGuOlloxQejRAZP/ucPhOwRA5xlvNSl5jDqGiho49EQr2ns0Cby5AYTsnRPiZg/Wn1kRQ7+uUKQcrnqpZQgUweJT3WwMFTU1B3ddUza1tjilUptb6Bxe4glr89BTI63fEiFY2AWw8S/r6+zTAA2kFglsBD3BuCh29TdogCh7tSdbaMZLFHUvSHS3gZKu6U1CSu8NptznSl8BMhtj4yBmBIHWPZ4iRF3yIGyogGw8h9uRSoCFQ8yZfIWFoP9pjBWaN0Y0pNtVLHmvsd+wN7j12RvYVLF1v9vX/39ba7upWa76Abq3cgaTC382Admx25TsnVOQcy2quDkZEOtgyAwRZnhIAe1XbFzdnbkAJEoIcbbm1YeoVQJMYY4UACOBvNB09LFTmDxXSuO4Z2xiwrWX0wd17QEXBvaybukIgDZnP72CbvTzz1fOfdqutXgLaWwmBwkgC2xL3Yh0S7kzN4Dsv/3y/U6DmDyvntIa6Rr6y2v3x+7dqLyARuwqm6OyVQ8lucu2/txT/Ll1qcldp9nj3LXmf85g7ba1Nhk8BBIOnyGQfPCbrDwJy1Uz92Hq1ZJ3dLI4E74ZLQWg5MWX4oODkFkORAUCAZJAtA5MyQErJMCzkDJVA5D+TYDkTjaCkzQLQR/OR8XUi0C0qkwCD/4Mic4FyzJiQSpSq2Kib3IiqXKYqLIEC4ypjWQKotiYGmyrQowHr3Aaqa50C1i4CIjjS6rrLqA6S1q4BYzEiQGcpmhoFEGYE0DCqbRIFQBYSJShqsESqPLrDBDYFvJ3QGAowJAOo0DWLEjIokACCkxUhgCILkw5C9Q5CPBgCkwMDUgUiAoqH2JoAMg2CkoLwMHrTcEhorB8EPJIhIDJTsHIYBhAA=== --> <!-- internal state end -->
Sign in to join this conversation.