show private indicator for appropriate streams #255

2026-06-09T18:49:54Z

talksik commented

2026-06-09 18:49:54 +00:00

(Migrated from github.com)

Summary by CodeRabbit

New Features
- Enhanced visibility indicators with clearer visual distinction between "Everyone" (globe icon) and "Private" (lock icon) states.
- Updated main button behavior to show "Everyone", "Private", or member avatars/overflow in non-private cases.
- Improved tooltip text to display accurate member counts and network-wide labeling based on visibility.

## Summary by CodeRabbit * **New Features** * Enhanced visibility indicators with clearer visual distinction between "Everyone" (globe icon) and "Private" (lock icon) states. * Updated main button behavior to show "Everyone", "Private", or member avatars/overflow in non-private cases. * Improved tooltip text to display accurate member counts and network-wide labeling based on visibility.

coderabbitai[bot] commented

2026-06-09 18:50:14 +00:00

(Migrated from github.com)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c0ad0a5-ec60-49c5-a070-7b96b8ec59dd

📥 Commits

Reviewing files that changed from the base of the PR and between 1725a44f9b and f90b81acfd.

📒 Files selected for processing (1)

js/desktop/src/features/particles/stream-top-bar.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

js/desktop/src/features/particles/stream-top-bar.tsx

📝 Walkthrough

Walkthrough

MembersIndicator now excludes the current user when computing visible members, classifies visibility as network-wide, private (only current user), or multi-member, and renders a globe, lock, or avatar group plus updated tooltip text accordingly.

Changes

MembersIndicator Visibility States

Layer / File(s)	Summary
Member visibility computation `js/desktop/src/features/particles/stream-top-bar.tsx`	Import of `Lock` and refactored member-id computation: builds `allMemberIds` from visibility, computes `othersIds` by excluding the current user, determines `isPrivate` from `othersIds` emptiness, and recalculates `shownMembers`/`overflow` from `othersIds`.
Visibility rendering and tooltip `js/desktop/src/features/particles/stream-top-bar.tsx`	Button renders "Everyone" with globe icon for network-wide, "Private" with lock icon when no other members, or avatar group with overflow otherwise. Tooltip keeps network name for Everyone and uses `allMemberIds.length` for non-network cases.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped along the stream and peeked inside the view,
Was it Everyone or Private? A lock or globe to cue.
The avatars arranged in rows, the counts now clear and bright,
A little rabbit clapped its paws and nodded with delight. 🌐🔒

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a private indicator to the MembersIndicator component for streams that should be marked as private.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch show-private-for-personal-streams

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/flowy-live/llink/pull/255?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)  No actionable comments were generated in the recent review. 🎉 <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `4c0ad0a5-ec60-49c5-a070-7b96b8ec59dd` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 1725a44f9b128d4048b0fb1d1a9ed0e910fa4c7a and f90b81acfdfa9d8b112629c31ee0cf72ca4fb080. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `js/desktop/src/features/particles/stream-top-bar.tsx` </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary> * js/desktop/src/features/particles/stream-top-bar.tsx </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough MembersIndicator now excludes the current user when computing visible members, classifies visibility as network-wide, private (only current user), or multi-member, and renders a globe, lock, or avatar group plus updated tooltip text accordingly. ## Changes **MembersIndicator Visibility States** |Layer / File(s)|Summary| |---|---| |**Member visibility computation** `js/desktop/src/features/particles/stream-top-bar.tsx`|Import of `Lock` and refactored member-id computation: builds `allMemberIds` from visibility, computes `othersIds` by excluding the current user, determines `isPrivate` from `othersIds` emptiness, and recalculates `shownMembers`/`overflow` from `othersIds`.| |**Visibility rendering and tooltip** `js/desktop/src/features/particles/stream-top-bar.tsx`|Button renders "Everyone" with globe icon for network-wide, "Private" with lock icon when no other members, or avatar group with overflow otherwise. Tooltip keeps network name for Everyone and uses `allMemberIds.length` for non-network cases.| ## Estimated code review effort 🎯 3 (Moderate) | ⏱️ ~20 minutes ## Poem > 🐰 I hopped along the stream and peeked inside the view, > Was it Everyone or Private? A lock or globe to cue. > The avatars arranged in rows, the counts now clear and bright, > A little rabbit clapped its paws and nodded with delight. 🌐🔒 </details>   <details> <summary>🚥 Pre-merge checks | ✅ 4 | ❌ 1</summary> ### ❌ Failed checks (1 warning) | Check name | Status | Explanation | Resolution | | :----------------: | :--------- | :----------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------- | | Docstring Coverage | ⚠️ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. | <details> <summary>✅ Passed checks (4 passed)</summary> | Check name | Status | Explanation | | :------------------------: | :------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title accurately describes the main change: adding a private indicator to the MembersIndicator component for streams that should be marked as private. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | </details> ✏️ Tip: You can configure your own custom pre-merge checks in the settings. </details>   <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ]  Create stacked PR - [ ]  Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Commit unit tests in branch `show-private-for-personal-streams` </details> </details>   --- Comment `@coderabbitai help` to get the list of available commands and usage tips.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FlowyLabs/llink#255