infra: cleanup tsconfig and add typecheck to desktop #253

2026-06-09T17:43:41Z

talksik commented

2026-06-09 17:43:41 +00:00

(Migrated from github.com)

Summary by CodeRabbit

Chores
- Updated TypeScript configuration for improved module resolution and compilation settings.
- Enhanced CI/CD quality gate workflow with additional type-checking step for desktop builds.
- Updated build script configuration for type-checking processes.

## Summary by CodeRabbit * **Chores** * Updated TypeScript configuration for improved module resolution and compilation settings. * Enhanced CI/CD quality gate workflow with additional type-checking step for desktop builds. * Updated build script configuration for type-checking processes.

coderabbitai[bot] commented

2026-06-09 17:43:55 +00:00

(Migrated from github.com)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 65216441-ec00-4771-9e62-aed159801632

📥 Commits

Reviewing files that changed from the base of the PR and between 92894c4af8 and 10c2fbe65f.

📒 Files selected for processing (4)

.github/workflows/pr-quality-gate-js.yml
js/desktop/forge.config.ts
js/desktop/package.json
js/desktop/tsconfig.json

📝 Walkthrough

Walkthrough

The PR updates the TypeScript configuration to use ESNext modules and bundler resolution strategy, replaces the compile npm script with a typecheck script, updates forge.config.ts to remove an unused type import and work with the new configuration, and adds a yarn typecheck step to the desktop workflow.

Changes

TypeScript Typecheck Integration

Layer / File(s)	Summary
TypeScript compiler configuration `js/desktop/tsconfig.json`	Module system changed from `commonjs` to `ESNext` and moduleResolution changed from `node` to `bundler`.
Typecheck script and forge config cleanup `js/desktop/package.json`, `js/desktop/forge.config.ts`	The `compile` script is replaced with `typecheck` that runs `tsc --noEmit`; the unused `SignToolOptions` import is removed from forge config and `hashes` is cast to `any` type.
Workflow typecheck step `.github/workflows/pr-quality-gate-js.yml`	The desktop job adds a "Typecheck" step that runs `yarn typecheck` after dependency installation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A typecheck hop in TypeScript's way,
ESNext bounds and bundler's play,
The workflow guards with zealous care,
While forge trims fat from config's air. ✨🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: adding a typecheck step to the workflow and cleaning up the tsconfig with module/moduleResolution updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch add-typecheck

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/flowy-live/llink/pull/253?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)  No actionable comments were generated in the recent review. 🎉 <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `65216441-ec00-4771-9e62-aed159801632` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 92894c4af88fa3bfec278193417cd0da93b89942 and 10c2fbe65f5e904b7f7f77f5dede1e29dbabcea1. </details> <details> <summary>📒 Files selected for processing (4)</summary> * `.github/workflows/pr-quality-gate-js.yml` * `js/desktop/forge.config.ts` * `js/desktop/package.json` * `js/desktop/tsconfig.json` </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough The PR updates the TypeScript configuration to use ESNext modules and bundler resolution strategy, replaces the `compile` npm script with a `typecheck` script, updates `forge.config.ts` to remove an unused type import and work with the new configuration, and adds a `yarn typecheck` step to the desktop workflow. ## Changes **TypeScript Typecheck Integration** | Layer / File(s) | Summary | |---|---| | **TypeScript compiler configuration** `js/desktop/tsconfig.json` | Module system changed from `commonjs` to `ESNext` and moduleResolution changed from `node` to `bundler`. | | **Typecheck script and forge config cleanup** `js/desktop/package.json`, `js/desktop/forge.config.ts` | The `compile` script is replaced with `typecheck` that runs `tsc --noEmit`; the unused `SignToolOptions` import is removed from forge config and `hashes` is cast to `any` type. | | **Workflow typecheck step** `.github/workflows/pr-quality-gate-js.yml` | The desktop job adds a "Typecheck" step that runs `yarn typecheck` after dependency installation. | ## Estimated code review effort 🎯 2 (Simple) | ⏱️ ~10 minutes ## Poem > A typecheck hop in TypeScript's way, > ESNext bounds and bundler's play, > The workflow guards with zealous care, > While forge trims fat from config's air. ✨🐰 </details>   <details> <summary>🚥 Pre-merge checks | ✅ 5</summary> <details> <summary>✅ Passed checks (5 passed)</summary> | Check name | Status | Explanation | | :------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title accurately summarizes the main changes: adding a typecheck step to the workflow and cleaning up the tsconfig with module/moduleResolution updates. | | Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | </details> ✏️ Tip: You can configure your own custom pre-merge checks in the settings. </details>   <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ]  Create stacked PR - [ ]  Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Commit unit tests in branch `add-typecheck` </details> </details>   --- Comment `@coderabbitai help` to get the list of available commands and usage tips.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FlowyLabs/llink#253