paginate open streams #252

2026-06-09T17:11:08Z

talksik commented

2026-06-09 17:11:08 +00:00

(Migrated from github.com)

paginate for open and closed streams
fix: add platform abstraction for deeplink (#251)
cleanup

Summary by CodeRabbit

Bug Fixes
- More reliable deep-link navigation with improved error handling and cleanup.
- Status filter query parameter is now consistently preserved when switching views.
New Features
- Unified pagination for stream lists, providing more consistent “load more” behavior and smoother loading across filters.

- **paginate for open and closed streams** - **fix: add platform abstraction for deeplink (#251)** - **cleanup**  ## Summary by CodeRabbit * **Bug Fixes** * More reliable deep-link navigation with improved error handling and cleanup. * Status filter query parameter is now consistently preserved when switching views. * **New Features** * Unified pagination for stream lists, providing more consistent “load more” behavior and smoother loading across filters.

coderabbitai[bot] commented

2026-06-09 17:11:28 +00:00

(Migrated from github.com)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ab5069d-93dd-41b7-9c58-fcb43e4241c4

📥 Commits

Reviewing files that changed from the base of the PR and between 0604b260d2 and 89d78246d3.

📒 Files selected for processing (1)

js/desktop/src/App.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

js/desktop/src/App.tsx

📝 Walkthrough

Walkthrough

Adds a portable platform.deepLink API (getPending, onNavigate) with Electron and web implementations; App uses it to fetch pending deep links and subscribe to navigation with error logging. Unifies stream pagination to a single limit state for both statuses. NetworkRoot now always writes the status query parameter.

Changes

Platform and feature updates

Layer / File(s)	Summary
Platform deepLink interface contract `js/desktop/src/lib/platform/types.ts`	`Platform` interface extended with `deepLink` capability providing `getPending(): Promise<string \| null>` and `onNavigate(callback): () => void`.
Platform implementations for deepLink `js/desktop/src/lib/platform/electron.ts`, `js/desktop/src/lib/platform/web.ts`	Electron wires `getPending` and `onNavigate` to `window.electronDeepLink` methods; web implementation stubs `getPending` to resolve `null` and `onNavigate` to return a no-op unsubscribe.
Deep-link navigation listener via platform abstraction `js/desktop/src/App.tsx`	`DeepLinkNavigationListener` now calls `platform.deepLink.getPending()` and navigates only when a path exists, logs errors via `logError`, and subscribes via `platform.deepLink.onNavigate()` with cleanup.
Stream pagination refactoring to unified limit model `js/desktop/src/hooks/use-stream-particles.ts`	Replaces closed-tab-specific pagination constants and gating with shared `INITIAL_PAGE_SIZE` / `PAGE_INCREMENT` and a single `limit` state; `canLoadMore` uses `streams.length >= limit` and `loadMore` increments `limit`.
Network status tab query parameter handling `js/desktop/src/features/network-root.tsx`	`setStatusTab` now always sets the `status` query parameter (including `open`) instead of deleting it; two inline layout comments were removed.

Sequence Diagram

sequenceDiagram
  participant App as App (DeepLinkNavigationListener)
  participant Platform as platform.deepLink
  participant Electron as window.electronDeepLink

  App->>Platform: getPending()
  Platform->>Electron: getPending()
  Electron-->>Platform: Promise<string|null>
  Platform-->>App: pending path or null
  alt pending path exists
    App->>App: navigate(pendingPath)
  end
  App->>Platform: onNavigate(callback)
  Platform->>Electron: onNavigate(callback)
  Electron-->>Platform: unsubscribe function
  Platform-->>App: unsubscribe function

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

flowy-live/llink#251: Modifies deep-link flow in App.tsx and related platform API usage; overlaps with the platform.deepLink consumption.
flowy-live/llink#246: Adds Electron-side electronDeepLink IPC/preload/main routing that complements the renderer changes in this PR.

Poem

🐰 I hopped between platforms, brave and spry,
Deep-links now whisper where they lie.
Streams stretch longer with a single goal,
Query strings set, the route feels whole.
🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'paginate open streams' directly describes the main feature added in this PR—unified pagination for both open and closed streams via the use-stream-particles hook refactor.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch paginate-open-streams

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/flowy-live/llink/pull/252?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)  No actionable comments were generated in the recent review. 🎉 <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `4ab5069d-93dd-41b7-9c58-fcb43e4241c4` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 0604b260d21f5b9dc539e3400d7aceb97e8940e7 and 89d78246d3cb7d515aefecfff3c895915d2885b9. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `js/desktop/src/App.tsx` </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary> * js/desktop/src/App.tsx </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough Adds a portable platform.deepLink API (getPending, onNavigate) with Electron and web implementations; App uses it to fetch pending deep links and subscribe to navigation with error logging. Unifies stream pagination to a single limit state for both statuses. NetworkRoot now always writes the `status` query parameter. ## Changes **Platform and feature updates** | Layer / File(s) | Summary | |---|---| | **Platform deepLink interface contract** `js/desktop/src/lib/platform/types.ts` | `Platform` interface extended with `deepLink` capability providing `getPending(): Promise<string \| null>` and `onNavigate(callback): () => void`. | | **Platform implementations for deepLink** `js/desktop/src/lib/platform/electron.ts`, `js/desktop/src/lib/platform/web.ts` | Electron wires `getPending` and `onNavigate` to `window.electronDeepLink` methods; web implementation stubs `getPending` to resolve `null` and `onNavigate` to return a no-op unsubscribe. | | **Deep-link navigation listener via platform abstraction** `js/desktop/src/App.tsx` | `DeepLinkNavigationListener` now calls `platform.deepLink.getPending()` and navigates only when a path exists, logs errors via `logError`, and subscribes via `platform.deepLink.onNavigate()` with cleanup. | | **Stream pagination refactoring to unified limit model** `js/desktop/src/hooks/use-stream-particles.ts` | Replaces closed-tab-specific pagination constants and gating with shared `INITIAL_PAGE_SIZE` / `PAGE_INCREMENT` and a single `limit` state; `canLoadMore` uses `streams.length >= limit` and `loadMore` increments `limit`. | | **Network status tab query parameter handling** `js/desktop/src/features/network-root.tsx` | `setStatusTab` now always sets the `status` query parameter (including `open`) instead of deleting it; two inline layout comments were removed. | ## Sequence Diagram ```mermaid sequenceDiagram participant App as App (DeepLinkNavigationListener) participant Platform as platform.deepLink participant Electron as window.electronDeepLink App->>Platform: getPending() Platform->>Electron: getPending() Electron-->>Platform: Promise<string|null> Platform-->>App: pending path or null alt pending path exists App->>App: navigate(pendingPath) end App->>Platform: onNavigate(callback) Platform->>Electron: onNavigate(callback) Electron-->>Platform: unsubscribe function Platform-->>App: unsubscribe function ``` ## Estimated code review effort 🎯 3 (Moderate) | ⏱️ ~20 minutes ## Possibly related PRs - [flowy-live/llink#251](https://github.com/flowy-live/llink/pull/251): Modifies deep-link flow in `App.tsx` and related platform API usage; overlaps with the platform.deepLink consumption. - [flowy-live/llink#246](https://github.com/flowy-live/llink/pull/246): Adds Electron-side `electronDeepLink` IPC/preload/main routing that complements the renderer changes in this PR. ## Poem > 🐰 I hopped between platforms, brave and spry, > Deep-links now whisper where they lie. > Streams stretch longer with a single goal, > Query strings set, the route feels whole. > 🥕✨ </details>   <details> <summary>🚥 Pre-merge checks | ✅ 4 | ❌ 1</summary> ### ❌ Failed checks (1 warning) | Check name | Status | Explanation | Resolution | | :----------------: | :--------- | :------------------------------------------------------------------------------------ | :--------------------------------------------------------------------------------- | | Docstring Coverage | ⚠️ Warning | Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. | <details> <summary>✅ Passed checks (4 passed)</summary> | Check name | Status | Explanation | | :------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title 'paginate open streams' directly describes the main feature added in this PR—unified pagination for both open and closed streams via the use-stream-particles hook refactor. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | </details> ✏️ Tip: You can configure your own custom pre-merge checks in the settings. </details>   <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ]  Create stacked PR - [ ]  Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Commit unit tests in branch `paginate-open-streams` </details> </details>   --- Comment `@coderabbitai help` to get the list of available commands and usage tips.

coderabbitai[bot] (Migrated from github.com) reviewed 2026-06-09 17:15:44 +00:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@js/desktop/src/App.tsx`:
- Around line 59-66: The call to logError inside the deep link handler
(platform.deepLink.getPending().catch(...)) is missing its import and will fail;
add an import for logError from the desktop errors module (import { logError }
from '`@/lib/errors`';) at the top of js/desktop/src/App.tsx so the catch handler
inside the DeepLinkNavigationListener / platform.deepLink.getPending() block can
call logError correctly.

In `@js/desktop/src/hooks/use-stream-particles.ts`:
- Line 53: The pagination limit (state variables limit and setLimit initialized
from INITIAL_PAGE_SIZE in use-stream-particles.ts) isn't reset when the
filter/status changes, causing over-fetching; add an effect that watches the
status value and calls setLimit(INITIAL_PAGE_SIZE) whenever status changes so
pagination starts fresh on tab switches (keep existing useState for limit, just
add a useEffect targeting status to reset it).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 83437b28-ff74-41ed-8b53-30374668f0be

📥 Commits

Reviewing files that changed from the base of the PR and between f38835ceee and 0604b260d2.

📒 Files selected for processing (6)

js/desktop/src/App.tsx
js/desktop/src/features/network-root.tsx
js/desktop/src/hooks/use-stream-particles.ts
js/desktop/src/lib/platform/electron.ts
js/desktop/src/lib/platform/types.ts
js/desktop/src/lib/platform/web.ts

**Actionable comments posted: 2** <details> <summary>🤖 Prompt for all review comments with AI agents</summary> ``` Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In `@js/desktop/src/App.tsx`: - Around line 59-66: The call to logError inside the deep link handler (platform.deepLink.getPending().catch(...)) is missing its import and will fail; add an import for logError from the desktop errors module (import { logError } from '`@/lib/errors`';) at the top of js/desktop/src/App.tsx so the catch handler inside the DeepLinkNavigationListener / platform.deepLink.getPending() block can call logError correctly. In `@js/desktop/src/hooks/use-stream-particles.ts`: - Line 53: The pagination limit (state variables limit and setLimit initialized from INITIAL_PAGE_SIZE in use-stream-particles.ts) isn't reset when the filter/status changes, causing over-fetching; add an effect that watches the status value and calls setLimit(INITIAL_PAGE_SIZE) whenever status changes so pagination starts fresh on tab switches (keep existing useState for limit, just add a useEffect targeting status to reset it). ``` </details> <details> <summary>🪄 Autofix (Beta)</summary> Fix all unresolved CodeRabbit comments on this PR: - [ ]  Push a commit to this branch (recommended) - [ ]  Create a new PR with the fixes </details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `83437b28-ff74-41ed-8b53-30374668f0be` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between f38835ceeefe5bd1afebe4d063140b0cd4807142 and 0604b260d21f5b9dc539e3400d7aceb97e8940e7. </details> <details> <summary>📒 Files selected for processing (6)</summary> * `js/desktop/src/App.tsx` * `js/desktop/src/features/network-root.tsx` * `js/desktop/src/hooks/use-stream-particles.ts` * `js/desktop/src/lib/platform/electron.ts` * `js/desktop/src/lib/platform/types.ts` * `js/desktop/src/lib/platform/web.ts` </details> </details>

js/desktop/src/App.tsx

coderabbitai[bot] (Migrated from github.com) commented

2026-06-09 17:15:43 +00:00

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find logError definition and check if it's globally available

# Search for logError exports
echo "=== Searching for logError exports ==="
rg -n --type=ts --type=tsx 'export.*logError' js/

# Search for logError declarations
echo -e "\n=== Searching for logError declarations ==="
rg -n --type=ts --type=tsx 'function logError|const logError|let logError' js/

# Check if logError is used elsewhere in the codebase
echo -e "\n=== Other usages of logError ==="
rg -n --type=ts --type=tsx 'logError\(' js/ -A1 -B1

Repository: flowy-live/llink

Length of output: 280

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Inspect js/desktop/src/App.tsx (imports + deepLink catch) ==="
sed -n '1,120p' js/desktop/src/App.tsx | nl -ba | sed -n '1,120p'

echo -e "\n=== Find logError usage in App.tsx ==="
rg -n "logError\(" js/desktop/src/App.tsx || true

echo -e "\n=== Find logError definitions across js/ ==="
rg -n "export\s+(function|const|let)\s+logError|function\s+logError|const\s+logError|let\s+logError" js/ || true

echo -e "\n=== Find logError imports across js/ ==="
rg -n "import\s+\{[^}]*\blogError\b[^}]*\}\s+from|from\s+['\"][^'\"]+['\"];\s*$" js/ || true

echo -e "\n=== Find all logError(...) callsites across js/ ==="
rg -n "logError\(" js/ -S || true

Repository: flowy-live/llink

Length of output: 187

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Check target file exists ==="
ls -la js/desktop/src/App.tsx || true

echo -e "\n=== App.tsx imports + deepLink block (line-numbered) ==="
# Use cat -n since nl isn't available
cat -n js/desktop/src/App.tsx | sed -n '1,140p'

echo -e "\n=== Find logError usage in App.tsx ==="
rg -n "logError\s*\(" js/desktop/src/App.tsx || true

echo -e "\n=== Find logError imports in App.tsx ==="
rg -n "import\s+\{[^}]*\blogError\b[^}]*\}\s+from" js/desktop/src/App.tsx || true

echo -e "\n=== Find logError definitions/exports across js/ ==="
rg -n "export\s+(function|const|let)\s+logError|function\s+logError|const\s+logError|let\s+logError" js/ || true

echo -e "\n=== Find all logError(...) callsites across js/ ==="
rg -n "logError\s*\(" js/ || true

Repository: flowy-live/llink

Length of output: 9928

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Inspect js/desktop/src/lib/errors.ts around logError ==="
sed -n '1,140p' js/desktop/src/lib/errors.ts | cat -n

echo -e "\n=== Check for barrel exports (desktop src/lib index) ==="
for f in js/desktop/src/lib/index.ts js/desktop/src/lib/index.tsx js/desktop/src/lib.ts js/desktop/src/lib/index.js js/desktop/src/lib/index.ts; do
  if [ -f "$f" ]; then
    echo "--- $f ---"
    sed -n '1,200p' "$f" | cat -n
  fi
done

echo -e "\n=== Search for re-export of logError in desktop lib ==="
rg -n "export\s+\*\s+from|export\s+\{[^}]*\blogError\b[^}]*\}" js/desktop/src/lib/ || true

echo -e "\n=== Search for logError exports outside lib/errors.ts (desktop) ==="
rg -n "export\s+function\s+logError|export\s+\{\s*logError\s*\}" js/desktop/src/ || true

Repository: flowy-live/llink

Length of output: 4013

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo -e "=== logError import usages in desktop ==="
rg -n "import\s+\{[^}]*\blogError\b[^}]*\}\s+from" js/desktop/src || true

echo -e "\n=== Possible global declarations ==="
rg -n "declare\s+(const|function)\s+logError|globalThis\.logError|window\.logError" js/ || true

echo -e "\n=== Does App.tsx import '`@/lib/errors`' or similar? ==="
rg -n "from\s+['\"]`@/lib/`(errors|error|logger)['\"]" js/desktop/src/App.tsx || true

echo -e "\n=== Any re-export barrel that could make logError available without local import? ==="
rg -n "export\s+\*\s+from\s+['\"][^'\"]*errors['\"]|export\s+\{\s*logError\s*\}" js/desktop/src/lib js/desktop/src || true

Repository: flowy-live/llink

Length of output: 942

🏁 Script executed:

#!/bin/bash
set -euo pipefail
rg -n "declare\s+(var|const|let|function)\s+logError|globalThis\[['\"]logError['\"]\]|globalThis\.(logError)|window\[['\"]logError['\"]\]|window\.(logError)" js/ || true

Repository: flowy-live/llink

Length of output: 42

🏁 Script executed:

#!/bin/bash
set -euo pipefail
rg -n "declare\s+(var|const|let|function)\s+logError|globalThis\.(logError)|window\.(logError)|global\s+logError|logError:\s*\(.*\)\s*=>" . || true

Repository: flowy-live/llink

Length of output: 42

Fix missing logError import in DeepLinkNavigationListener

platform.deepLink
  .getPending()
  .then((path) => {
    if (path) navigate(path);
  })
  .catch((err) => {
    logError(err, { scope: 'deepLink.getPending' });
  });

js/desktop/src/App.tsx (line 65) calls logError, but the file has no import. logError is exported from @/lib/errors (js/desktop/src/lib/errors.ts), and other desktop files import it from there—so this call will fail at runtime (and/or typecheck).

Add:

import { logError } from '@/lib/errors';

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@js/desktop/src/App.tsx` around lines 59 - 66, The call to logError inside the
deep link handler (platform.deepLink.getPending().catch(...)) is missing its
import and will fail; add an import for logError from the desktop errors module
(import { logError } from '`@/lib/errors`';) at the top of js/desktop/src/App.tsx
so the catch handler inside the DeepLinkNavigationListener /
platform.deepLink.getPending() block can call logError correctly.

✅ Addressed in commit 89d7824

_⚠️ Potential issue_ | _🔴 Critical_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Description: Find logError definition and check if it's globally available # Search for logError exports echo "=== Searching for logError exports ===" rg -n --type=ts --type=tsx 'export.*logError' js/ # Search for logError declarations echo -e "\n=== Searching for logError declarations ===" rg -n --type=ts --type=tsx 'function logError|const logError|let logError' js/ # Check if logError is used elsewhere in the codebase echo -e "\n=== Other usages of logError ===" rg -n --type=ts --type=tsx 'logError\(' js/ -A1 -B1 ``` Repository: flowy-live/llink Length of output: 280 --- 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail echo "=== Inspect js/desktop/src/App.tsx (imports + deepLink catch) ===" sed -n '1,120p' js/desktop/src/App.tsx | nl -ba | sed -n '1,120p' echo -e "\n=== Find logError usage in App.tsx ===" rg -n "logError\(" js/desktop/src/App.tsx || true echo -e "\n=== Find logError definitions across js/ ===" rg -n "export\s+(function|const|let)\s+logError|function\s+logError|const\s+logError|let\s+logError" js/ || true echo -e "\n=== Find logError imports across js/ ===" rg -n "import\s+\{[^}]*\blogError\b[^}]*\}\s+from|from\s+['\"][^'\"]+['\"];\s*$" js/ || true echo -e "\n=== Find all logError(...) callsites across js/ ===" rg -n "logError\(" js/ -S || true ``` Repository: flowy-live/llink Length of output: 187 --- 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail echo "=== Check target file exists ===" ls -la js/desktop/src/App.tsx || true echo -e "\n=== App.tsx imports + deepLink block (line-numbered) ===" # Use cat -n since nl isn't available cat -n js/desktop/src/App.tsx | sed -n '1,140p' echo -e "\n=== Find logError usage in App.tsx ===" rg -n "logError\s*\(" js/desktop/src/App.tsx || true echo -e "\n=== Find logError imports in App.tsx ===" rg -n "import\s+\{[^}]*\blogError\b[^}]*\}\s+from" js/desktop/src/App.tsx || true echo -e "\n=== Find logError definitions/exports across js/ ===" rg -n "export\s+(function|const|let)\s+logError|function\s+logError|const\s+logError|let\s+logError" js/ || true echo -e "\n=== Find all logError(...) callsites across js/ ===" rg -n "logError\s*\(" js/ || true ``` Repository: flowy-live/llink Length of output: 9928 --- 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail echo "=== Inspect js/desktop/src/lib/errors.ts around logError ===" sed -n '1,140p' js/desktop/src/lib/errors.ts | cat -n echo -e "\n=== Check for barrel exports (desktop src/lib index) ===" for f in js/desktop/src/lib/index.ts js/desktop/src/lib/index.tsx js/desktop/src/lib.ts js/desktop/src/lib/index.js js/desktop/src/lib/index.ts; do if [ -f "$f" ]; then echo "--- $f ---" sed -n '1,200p' "$f" | cat -n fi done echo -e "\n=== Search for re-export of logError in desktop lib ===" rg -n "export\s+\*\s+from|export\s+\{[^}]*\blogError\b[^}]*\}" js/desktop/src/lib/ || true echo -e "\n=== Search for logError exports outside lib/errors.ts (desktop) ===" rg -n "export\s+function\s+logError|export\s+\{\s*logError\s*\}" js/desktop/src/ || true ``` Repository: flowy-live/llink Length of output: 4013 --- 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail echo -e "=== logError import usages in desktop ===" rg -n "import\s+\{[^}]*\blogError\b[^}]*\}\s+from" js/desktop/src || true echo -e "\n=== Possible global declarations ===" rg -n "declare\s+(const|function)\s+logError|globalThis\.logError|window\.logError" js/ || true echo -e "\n=== Does App.tsx import '`@/lib/errors`' or similar? ===" rg -n "from\s+['\"]`@/lib/`(errors|error|logger)['\"]" js/desktop/src/App.tsx || true echo -e "\n=== Any re-export barrel that could make logError available without local import? ===" rg -n "export\s+\*\s+from\s+['\"][^'\"]*errors['\"]|export\s+\{\s*logError\s*\}" js/desktop/src/lib js/desktop/src || true ``` Repository: flowy-live/llink Length of output: 942 --- 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail rg -n "declare\s+(var|const|let|function)\s+logError|globalThis\[['\"]logError['\"]\]|globalThis\.(logError)|window\[['\"]logError['\"]\]|window\.(logError)" js/ || true ``` Repository: flowy-live/llink Length of output: 42 --- 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail rg -n "declare\s+(var|const|let|function)\s+logError|globalThis\.(logError)|window\.(logError)|global\s+logError|logError:\s*$.*$\s*=>" . || true ``` Repository: flowy-live/llink Length of output: 42 --- </details> **Fix missing `logError` import in `DeepLinkNavigationListener`** ```ts platform.deepLink .getPending() .then((path) => { if (path) navigate(path); }) .catch((err) => { logError(err, { scope: 'deepLink.getPending' }); }); ``` `js/desktop/src/App.tsx` (line 65) calls `logError`, but the file has no import. `logError` is exported from `@/lib/errors` (`js/desktop/src/lib/errors.ts`), and other desktop files import it from there—so this call will fail at runtime (and/or typecheck). Add: - `import { logError } from '`@/lib/errors`';` <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@js/desktop/src/App.tsx` around lines 59 - 66, The call to logError inside the deep link handler (platform.deepLink.getPending().catch(...)) is missing its import and will fail; add an import for logError from the desktop errors module (import { logError } from '`@/lib/errors`';) at the top of js/desktop/src/App.tsx so the catch handler inside the DeepLinkNavigationListener / platform.deepLink.getPending() block can call logError correctly. ``` </details>    ✅ Addressed in commit 89d7824

js/desktop/src/hooks/use-stream-particles.ts

coderabbitai[bot] (Migrated from github.com) commented

2026-06-09 17:15:43 +00:00

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Pagination limit does not reset when status changes.

When the user switches between the "open" and "closed" tabs, the limit state persists. If a user loads several pages of closed streams (e.g., limit reaches 60), then switches to the open tab, the hook will immediately query for 60 open streams instead of starting fresh at 12. This causes unnecessary over-fetching and changes the previous behavior that reset pagination on tab switch.

🛠️ Proposed fix to reset limit on status change

+import { useCallback, useEffect, useMemo, useState } from 'react';
-import { useCallback, useMemo, useState } from 'react';

Then add a reset effect after the useState:

  const [limit, setLimit] = useState(INITIAL_PAGE_SIZE);

+  // Reset pagination when switching between open/closed tabs
+  useEffect(() => {
+    setLimit(INITIAL_PAGE_SIZE);
+  }, [status]);
+

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  const [limit, setLimit] = useState(INITIAL_PAGE_SIZE);

  // Reset pagination when switching between open/closed tabs
  useEffect(() => {
    setLimit(INITIAL_PAGE_SIZE);
  }, [status]);

import { useCallback, useEffect, useMemo, useState } from 'react';

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@js/desktop/src/hooks/use-stream-particles.ts` at line 53, The pagination
limit (state variables limit and setLimit initialized from INITIAL_PAGE_SIZE in
use-stream-particles.ts) isn't reset when the filter/status changes, causing
over-fetching; add an effect that watches the status value and calls
setLimit(INITIAL_PAGE_SIZE) whenever status changes so pagination starts fresh
on tab switches (keep existing useState for limit, just add a useEffect
targeting status to reset it).

_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Pagination `limit` does not reset when `status` changes.** When the user switches between the "open" and "closed" tabs, the `limit` state persists. If a user loads several pages of closed streams (e.g., limit reaches 60), then switches to the open tab, the hook will immediately query for 60 open streams instead of starting fresh at 12. This causes unnecessary over-fetching and changes the previous behavior that reset pagination on tab switch. <details> <summary>🛠️ Proposed fix to reset limit on status change</summary> ```diff +import { useCallback, useEffect, useMemo, useState } from 'react'; -import { useCallback, useMemo, useState } from 'react'; ``` Then add a reset effect after the `useState`: ```diff const [limit, setLimit] = useState(INITIAL_PAGE_SIZE); + // Reset pagination when switching between open/closed tabs + useEffect(() => { + setLimit(INITIAL_PAGE_SIZE); + }, [status]); + ``` </details>  <details> <summary>📝 Committable suggestion</summary> > ‼️ **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. ```suggestion const [limit, setLimit] = useState(INITIAL_PAGE_SIZE); // Reset pagination when switching between open/closed tabs useEffect(() => { setLimit(INITIAL_PAGE_SIZE); }, [status]); ``` ```suggestion import { useCallback, useEffect, useMemo, useState } from 'react'; ``` </details>  <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@js/desktop/src/hooks/use-stream-particles.ts` at line 53, The pagination limit (state variables limit and setLimit initialized from INITIAL_PAGE_SIZE in use-stream-particles.ts) isn't reset when the filter/status changes, causing over-fetching; add an effect that watches the status value and calls setLimit(INITIAL_PAGE_SIZE) whenever status changes so pagination starts fresh on tab switches (keep existing useState for limit, just add a useEffect targeting status to reset it). ``` </details>

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FlowyLabs/llink#252