fix: add platform abstraction for deeplink #251

2026-06-09T16:34:37Z

talksik commented

2026-06-09 16:34:37 +00:00

(Migrated from github.com)

This was crashing App.tsx due to the deep link listener calling methods on window which do not exist.

Summary by CodeRabbit

New Features
- Unified deep-link handling across desktop and web for more consistent navigation and a matching platform interface.
Bug Fixes
- Network status query parameter is now consistently preserved (explicitly shows "open" when applicable).
- Improved initial and ongoing deep-link navigation handling, with more robust error handling for pending deep links.

This was crashing App.tsx due to the deep link listener calling methods on window which do not exist.  ## Summary by CodeRabbit * **New Features** * Unified deep-link handling across desktop and web for more consistent navigation and a matching platform interface. * **Bug Fixes** * Network status query parameter is now consistently preserved (explicitly shows "open" when applicable). * Improved initial and ongoing deep-link navigation handling, with more robust error handling for pending deep links.

coderabbitai[bot] commented

2026-06-09 16:34:52 +00:00

(Migrated from github.com)

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d8e5e91-eae0-4cb5-85d8-5753aabe69a8

📥 Commits

Reviewing files that changed from the base of the PR and between 5275f382b4 and 5013975f18.

📒 Files selected for processing (1)

js/desktop/src/App.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

js/desktop/src/App.tsx

📝 Walkthrough

Walkthrough

Adds a platform.deepLink API (types, Electron wiring, web stub) and migrates App's deep-link listener to use it; NetworkRoot's setStatusTab now always writes status to the URL and two render-only JSX comments were removed.

Changes

Deep-Link Platform Abstraction and URL Parameter Updates

Layer / File(s)	Summary
Deep-link platform abstraction `js/desktop/src/lib/platform/types.ts`, `js/desktop/src/lib/platform/electron.ts`, `js/desktop/src/lib/platform/web.ts`, `js/desktop/src/App.tsx`	Adds `Platform.app.deepLink` with `getPending()` and `onNavigate()`. Electron wires these to `window.electronDeepLink`; web provides inert stubs. App's `DeepLinkNavigationListener` uses `platform.deepLink.getPending()` and `platform.deepLink.onNavigate(...)`, with added error logging for pending resolution.
NetworkRoot status parameter and cleanup `js/desktop/src/features/network-root.tsx`	`setStatusTab` now always sets the `status` query parameter (`open` or `closed`) instead of deleting it for `open`. Two render-only JSX comments were removed.

Sequence Diagram

sequenceDiagram
  participant App as DeepLinkNavigationListener
  participant Platform as platform.deepLink
  participant Electron as window.electronDeepLink
  App->>Platform: getPending()
  Platform->>Electron: read pending deep link
  Electron-->>Platform: pending path or null
  Platform-->>App: resolves path
  App->>Platform: onNavigate(callback)
  Electron->>Platform: emits navigate(path)
  Platform-->>App: invoke callback(path)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

flowy-live/llink#246: Implements the Electron deep-link preload/main IPC API that this PR's platform abstraction wraps and routes through.

Poem

🐰 A rabbit hops from web to shell,
Deep links find a platform well,
Status stays in query land,
Comments trimmed by careful hand,
Hooray — the routes now understand! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: add platform abstraction for deeplink' accurately summarizes the main change: adding a platform abstraction layer for deep link handling to resolve the crash.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-web-deep-link

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/flowy-live/llink/pull/251?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)  No actionable comments were generated in the recent review. 🎉 <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `0d8e5e91-eae0-4cb5-85d8-5753aabe69a8` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 5275f382b43ca2328b5676002c0a15076fc37d8e and 5013975f18babb7a9dc92a5ff5a2cc201761f9dd. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `js/desktop/src/App.tsx` </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (1)</summary> * js/desktop/src/App.tsx </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough Adds a platform.deepLink API (types, Electron wiring, web stub) and migrates App's deep-link listener to use it; NetworkRoot's setStatusTab now always writes `status` to the URL and two render-only JSX comments were removed. ## Changes **Deep-Link Platform Abstraction and URL Parameter Updates** |Layer / File(s)|Summary| |---|---| |**Deep-link platform abstraction** `js/desktop/src/lib/platform/types.ts`, `js/desktop/src/lib/platform/electron.ts`, `js/desktop/src/lib/platform/web.ts`, `js/desktop/src/App.tsx`|Adds `Platform.app.deepLink` with `getPending()` and `onNavigate()`. Electron wires these to `window.electronDeepLink`; web provides inert stubs. App's `DeepLinkNavigationListener` uses `platform.deepLink.getPending()` and `platform.deepLink.onNavigate(...)`, with added error logging for pending resolution.| |**NetworkRoot status parameter and cleanup** `js/desktop/src/features/network-root.tsx`|`setStatusTab` now always sets the `status` query parameter (`open` or `closed`) instead of deleting it for `open`. Two render-only JSX comments were removed.| ### Sequence Diagram ```mermaid sequenceDiagram participant App as DeepLinkNavigationListener participant Platform as platform.deepLink participant Electron as window.electronDeepLink App->>Platform: getPending() Platform->>Electron: read pending deep link Electron-->>Platform: pending path or null Platform-->>App: resolves path App->>Platform: onNavigate(callback) Electron->>Platform: emits navigate(path) Platform-->>App: invoke callback(path) ``` ## Estimated code review effort 🎯 3 (Moderate) | ⏱️ ~20 minutes ## Possibly related PRs - [flowy-live/llink#246](https://github.com/flowy-live/llink/pull/246): Implements the Electron deep-link preload/main IPC API that this PR's platform abstraction wraps and routes through. ## Poem > 🐰 A rabbit hops from web to shell, > Deep links find a platform well, > Status stays in query land, > Comments trimmed by careful hand, > Hooray — the routes now understand! 🐇 </details>   <details> <summary>🚥 Pre-merge checks | ✅ 4 | ❌ 1</summary> ### ❌ Failed checks (1 warning) | Check name | Status | Explanation | Resolution | | :----------------: | :--------- | :------------------------------------------------------------------------------------ | :--------------------------------------------------------------------------------- | | Docstring Coverage | ⚠️ Warning | Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. | <details> <summary>✅ Passed checks (4 passed)</summary> | Check name | Status | Explanation | | :------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title 'fix: add platform abstraction for deeplink' accurately summarizes the main change: adding a platform abstraction layer for deep link handling to resolve the crash. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | </details> ✏️ Tip: You can configure your own custom pre-merge checks in the settings. </details>   <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ]  Create stacked PR - [ ]  Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Commit unit tests in branch `fix-web-deep-link` </details> </details>   --- Comment `@coderabbitai help` to get the list of available commands and usage tips.

coderabbitai[bot] (Migrated from github.com) reviewed 2026-06-09 16:37:31 +00:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
js/desktop/src/features/network-root.tsx (1)
29-38: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

URL hygiene for status=open in NetworkRoot

setStatusTab currently always does params.set('status', next), so selecting the 'open' tab will produce ?status=open (even though the default logic treats missing/non-closed as 'open'). If cleaner URLs are desired, omit the param for the default state.
♻️ Omit `status` when it’s `'open'`
 const setStatusTab = (next: 'open' | 'closed') => {
   setSearchParams(
     (prev) => {
       const params = new URLSearchParams(prev);
-      params.set('status', next);
+      if (next === 'open') {
+        params.delete('status');
+      } else {
+        params.set('status', next);
+      }
       return params;
     },
     { replace: true },
   );
 };
Is the intent to always keep status explicit in the URL, including the default 'open' state?
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@js/desktop/src/features/network-root.tsx` around lines 29 - 38, setStatusTab
always writes status=open into the URL even though the app treats
missing/non-closed as open; update setStatusTab in NetworkRoot so when next ===
'open' it removes the status param (params.delete('status')) instead of
params.set, and keep params.set('status', next) for 'closed', ensuring you call
setSearchParams with the same replace: true behavior; touch the setStatusTab
function to implement this conditional param deletion.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@js/desktop/src/App.tsx`:
- Around line 59-61: The call to platform.deepLink.getPending() lacks rejection
handling; wrap the promise usage so errors are caught and logged or handled
(e.g., add a .catch handler or await inside a try/catch) around
platform.deepLink.getPending() and ensure failures do not block navigation;
specifically update the block that calls platform.deepLink.getPending() (the
call site referencing platform.deepLink.getPending and navigate) to catch errors
and call an appropriate error handler or logger instead of leaving the promise
unhandled.

---

Outside diff comments:
In `@js/desktop/src/features/network-root.tsx`:
- Around line 29-38: setStatusTab always writes status=open into the URL even
though the app treats missing/non-closed as open; update setStatusTab in
NetworkRoot so when next === 'open' it removes the status param
(params.delete('status')) instead of params.set, and keep params.set('status',
next) for 'closed', ensuring you call setSearchParams with the same replace:
true behavior; touch the setStatusTab function to implement this conditional
param deletion.

🪄 Autofix (Beta)

✅ Autofix completed

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3cf2cd46-c9e1-45a8-9e6e-a22427a49fa6

📥 Commits

Reviewing files that changed from the base of the PR and between a94a986fbf and 198add3931.

📒 Files selected for processing (5)

js/desktop/src/App.tsx
js/desktop/src/features/network-root.tsx
js/desktop/src/lib/platform/electron.ts
js/desktop/src/lib/platform/types.ts
js/desktop/src/lib/platform/web.ts

**Actionable comments posted: 1** > [!CAUTION] > Some comments are outside the diff and can’t be posted inline due to platform limitations. > > > > <details> > <summary>⚠️ Outside diff range comments (1)</summary><blockquote> > > <details> > <summary>js/desktop/src/features/network-root.tsx (1)</summary><blockquote> > > `29-38`: _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ > > **URL hygiene for `status=open` in `NetworkRoot`** > > `setStatusTab` currently always does `params.set('status', next)`, so selecting the `'open'` tab will produce `?status=open` (even though the default logic treats missing/non-`closed` as `'open'`). If cleaner URLs are desired, omit the param for the default state. > > <details> > <summary>♻️ Omit `status` when it’s `'open'`</summary> > > ```diff > const setStatusTab = (next: 'open' | 'closed') => { > setSearchParams( > (prev) => { > const params = new URLSearchParams(prev); > - params.set('status', next); > + if (next === 'open') { > + params.delete('status'); > + } else { > + params.set('status', next); > + } > return params; > }, > { replace: true }, > ); > }; > ``` > </details> > > > Is the intent to always keep `status` explicit in the URL, including the default `'open'` state? > > <details> > <summary>🤖 Prompt for AI Agents</summary> > > ``` > Verify each finding against current code. Fix only still-valid issues, skip the > rest with a brief reason, keep changes minimal, and validate. > > In `@js/desktop/src/features/network-root.tsx` around lines 29 - 38, setStatusTab > always writes status=open into the URL even though the app treats > missing/non-closed as open; update setStatusTab in NetworkRoot so when next === > 'open' it removes the status param (params.delete('status')) instead of > params.set, and keep params.set('status', next) for 'closed', ensuring you call > setSearchParams with the same replace: true behavior; touch the setStatusTab > function to implement this conditional param deletion. > ``` > > </details> > >  > > </blockquote></details> > > </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary> ``` Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In `@js/desktop/src/App.tsx`: - Around line 59-61: The call to platform.deepLink.getPending() lacks rejection handling; wrap the promise usage so errors are caught and logged or handled (e.g., add a .catch handler or await inside a try/catch) around platform.deepLink.getPending() and ensure failures do not block navigation; specifically update the block that calls platform.deepLink.getPending() (the call site referencing platform.deepLink.getPending and navigate) to catch errors and call an appropriate error handler or logger instead of leaving the promise unhandled. --- Outside diff comments: In `@js/desktop/src/features/network-root.tsx`: - Around line 29-38: setStatusTab always writes status=open into the URL even though the app treats missing/non-closed as open; update setStatusTab in NetworkRoot so when next === 'open' it removes the status param (params.delete('status')) instead of params.set, and keep params.set('status', next) for 'closed', ensuring you call setSearchParams with the same replace: true behavior; touch the setStatusTab function to implement this conditional param deletion. ``` </details> <details> <summary>🪄 Autofix (Beta)</summary> ✅ Autofix completed </details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `3cf2cd46-c9e1-45a8-9e6e-a22427a49fa6` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between a94a986fbf9e38c8397f1e2b0e2435a32bcd8042 and 198add393135af6c021d2be33ca080e86a9366fa. </details> <details> <summary>📒 Files selected for processing (5)</summary> * `js/desktop/src/App.tsx` * `js/desktop/src/features/network-root.tsx` * `js/desktop/src/lib/platform/electron.ts` * `js/desktop/src/lib/platform/types.ts` * `js/desktop/src/lib/platform/web.ts` </details> </details>

js/desktop/src/App.tsx

						
				@@ -56,10 +56,16 @@ function DeepLinkNavigationListener() {

				  const navigate = useNavigate();

coderabbitai[bot] (Migrated from github.com) commented

2026-06-09 16:37:30 +00:00

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add error handling for getPending() promise.

The getPending() call has no error handler. If the underlying Electron IPC or platform implementation throws or rejects, this will result in an unhandled promise rejection that could crash the app or surface console errors.

🛡️ Proposed fix to add error handling

-    platform.deepLink.getPending().then((path) => {
-      if (path) navigate(path);
-    });
+    platform.deepLink
+      .getPending()
+      .then((path) => {
+        if (path) navigate(path);
+      })
+      .catch((error) => {
+        console.error('Failed to retrieve pending deep link:', error);
+      });

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    platform.deepLink
      .getPending()
      .then((path) => {
        if (path) navigate(path);
      })
      .catch((error) => {
        console.error('Failed to retrieve pending deep link:', error);
      });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@js/desktop/src/App.tsx` around lines 59 - 61, The call to
platform.deepLink.getPending() lacks rejection handling; wrap the promise usage
so errors are caught and logged or handled (e.g., add a .catch handler or await
inside a try/catch) around platform.deepLink.getPending() and ensure failures do
not block navigation; specifically update the block that calls
platform.deepLink.getPending() (the call site referencing
platform.deepLink.getPending and navigate) to catch errors and call an
appropriate error handler or logger instead of leaving the promise unhandled.

✅ Addressed in commit 5275f38

_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Add error handling for `getPending()` promise.** The `getPending()` call has no error handler. If the underlying Electron IPC or platform implementation throws or rejects, this will result in an unhandled promise rejection that could crash the app or surface console errors. <details> <summary>🛡️ Proposed fix to add error handling</summary> ```diff - platform.deepLink.getPending().then((path) => { - if (path) navigate(path); - }); + platform.deepLink + .getPending() + .then((path) => { + if (path) navigate(path); + }) + .catch((error) => { + console.error('Failed to retrieve pending deep link:', error); + }); ``` </details>  <details> <summary>📝 Committable suggestion</summary> > ‼️ **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. ```suggestion platform.deepLink .getPending() .then((path) => { if (path) navigate(path); }) .catch((error) => { console.error('Failed to retrieve pending deep link:', error); }); ``` </details>  <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@js/desktop/src/App.tsx` around lines 59 - 61, The call to platform.deepLink.getPending() lacks rejection handling; wrap the promise usage so errors are caught and logged or handled (e.g., add a .catch handler or await inside a try/catch) around platform.deepLink.getPending() and ensure failures do not block navigation; specifically update the block that calls platform.deepLink.getPending() (the call site referencing platform.deepLink.getPending and navigate) to catch errors and call an appropriate error handler or logger instead of leaving the promise unhandled. ``` </details>    ✅ Addressed in commit 5275f38

coderabbitai[bot] commented

2026-06-09 16:44:59 +00:00

(Migrated from github.com)

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

js/desktop/src/App.tsx

Commit: 5275f382b43ca2328b5676002c0a15076fc37d8e

The changes have been pushed to the fix-web-deep-link branch.

Time taken: 1m 29s

> [!NOTE] > Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. ## Fixes Applied Successfully Fixed 1 file(s) based on 1 unresolved review comment. **Files modified:** - `js/desktop/src/App.tsx` **Commit:** `5275f382b43ca2328b5676002c0a15076fc37d8e` The changes have been pushed to the `fix-web-deep-link` branch. **Time taken:** `1m 29s`

talksik (Migrated from github.com) reviewed 2026-06-09 16:47:54 +00:00

js/desktop/src/App.tsx

						
				@@ -56,10 +56,16 @@ function DeepLinkNavigationListener() {

				  const navigate = useNavigate();

talksik (Migrated from github.com) commented

2026-06-09 16:47:54 +00:00

Shouldn't your fix use either reportError or logError?

coderabbitai[bot] (Migrated from github.com) reviewed 2026-06-09 16:48:41 +00:00

js/desktop/src/App.tsx

						
				@@ -56,10 +56,16 @@ function DeepLinkNavigationListener() {

				  const navigate = useNavigate();

coderabbitai[bot] (Migrated from github.com) commented

2026-06-09 16:48:41 +00:00

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for reportError and logError definitions and usages
rg -n "reportError|logError" --type ts --type tsx -C2

Length of output: 397

🏁 Script executed:

#!/bin/bash
# Search for reportError and logError definitions and usages
rg -n "reportError|logError" -C2

Length of output: 28070

@talksik — you're right. The codebase has a clear distinction in js/desktop/src/lib/errors.ts:

logError — "Expected-but-recordable failures. Breadcrumb only — never pages anyone." (dev-only console output)
reportError — "Unexpected failures the user may not see. Always captured." (always sent to the observability sink)

For getPending(), a rejection is recoverable (navigation simply doesn't happen) and low-impact, which fits logError's contract. This also matches the pattern used for similar call-site errors like autoplay.beep and soundEffects.preload. Updated suggestion:

+import { logError } from '`@/lib/errors`';

     platform.deepLink
       .getPending()
       .then((path) => {
         if (path) navigate(path);
       })
-      .catch((error) => {
-        console.error('Failed to retrieve pending deep link:', error);
-      });
+      .catch((err) => {
+        logError(err, { scope: 'deepLink.getPending' });
+      });

That said, if the team treats any IPC rejection as unexpected (similar to how ipc-utils.ts uses reportError for IPC handler errors on the main-process side), reportError would also be justified. The call is yours based on the severity convention you want to apply here.

<details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Search for reportError and logError definitions and usages rg -n "reportError|logError" --type ts --type tsx -C2 ``` Length of output: 397 --- 🏁 Script executed: ```shell #!/bin/bash # Search for reportError and logError definitions and usages rg -n "reportError|logError" -C2 ``` Length of output: 28070 --- </details> --- `@talksik` — you're right. The codebase has a clear distinction in `js/desktop/src/lib/errors.ts`: - **`logError`** — _"Expected-but-recordable failures. Breadcrumb only — never pages anyone."_ (dev-only console output) - **`reportError`** — _"Unexpected failures the user may not see. Always captured."_ (always sent to the observability sink) For `getPending()`, a rejection is recoverable (navigation simply doesn't happen) and low-impact, which fits `logError`'s contract. This also matches the pattern used for similar call-site errors like `autoplay.beep` and `soundEffects.preload`. Updated suggestion: ```diff +import { logError } from '`@/lib/errors`'; platform.deepLink .getPending() .then((path) => { if (path) navigate(path); }) - .catch((error) => { - console.error('Failed to retrieve pending deep link:', error); - }); + .catch((err) => { + logError(err, { scope: 'deepLink.getPending' }); + }); ``` That said, if the team treats any IPC rejection as unexpected (similar to how `ipc-utils.ts` uses `reportError` for IPC handler errors on the main-process side), `reportError` would also be justified. The call is yours based on the severity convention you want to apply here.

talksik (Migrated from github.com) reviewed 2026-06-09 16:49:52 +00:00

js/desktop/src/App.tsx

						
				@@ -56,10 +56,16 @@ function DeepLinkNavigationListener() {

				  const navigate = useNavigate();

talksik (Migrated from github.com) commented

2026-06-09 16:49:52 +00:00

@coderabbitai help

coderabbitai[bot] commented

2026-06-09 16:49:58 +00:00

(Migrated from github.com)

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai rate limit to show your current review rate limit status.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
@coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
@coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai emit path instructions to emit generated path-specific review instructions for this repository.
@coderabbitai resolve merge conflict to automatically resolve merge conflicts.
@coderabbitai autofix to automatically fix issues identified in unresolved review comments.
@coderabbitai resolve to resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit configuration file (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, support, documentation and community

Visit our status page to check the current availability of CodeRabbit.
Create a ticket on our support page for assistance with any issues or questions.
Visit our documentation site for detailed information on how to use CodeRabbit.
Join our Discord community to connect with other users and get help from the community.
Follow us on X/Twitter for updates and announcements.

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=flowy-live/llink&utm_content=251): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` ### CodeRabbit commands > These commands are invoked using PR/Issue comments. - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai rate limit` to show your current review rate limit status. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>]` to validate the custom pre-merge checks instructions. Defaults to `error` when `--mode` is omitted. - `@coderabbitai ignore pre-merge checks` to override pre-merge checks and get an approval on PR. - `@coderabbitai run pre-merge checks` to run pre-merge checks on the pull request. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. - `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR. - `@coderabbitai generate unit tests` to generate unit tests for this PR. - `@coderabbitai emit path instructions` to emit generated path-specific review instructions for this repository. - `@coderabbitai resolve merge conflict` to automatically resolve merge conflicts. - `@coderabbitai autofix` to automatically fix issues identified in unresolved review comments. - `@coderabbitai resolve` to resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai generate configuration` to create a PR that adds the current resolved configuration as `.coderabbit.yaml` (or show it if already present). - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` or `@coderabbit ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit configuration file (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - You can also validate your configuration using the [online YAML validator](https://docs.coderabbit.ai/configuration/yaml-validator). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Status, support, documentation and community - Visit our [status page](https://status.coderabbit.ai) to check the current availability of CodeRabbit. - Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions. - Visit our [documentation site](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord community](http://discord.gg/coderabbit) to connect with other users and get help from the community. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FlowyLabs/llink#251

				`@@ -56,10 +56,16 @@ function DeepLinkNavigationListener() {`
				`const navigate = useNavigate();`

fix: add platform abstraction for deeplink #251

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Fixes Applied Successfully

Chat

CodeRabbit commands

Other keywords and placeholders

CodeRabbit configuration file (.coderabbit.yaml)

Status, support, documentation and community

CodeRabbit configuration file (`.coderabbit.yaml`)