Revert "feat(errors): fallback handlers for unhandled rejections and errors"

This reverts commit ed84b29c6b.
This commit is contained in:
Arjun Patel
2026-04-20 19:21:38 -07:00
parent ed84b29c6b
commit 13fd6cbbad
2 changed files with 37 additions and 59 deletions
+18 -31
View File
@@ -1,41 +1,28 @@
import * as Sentry from "@sentry/electron/renderer";
import { appConfig } from "@/config/env";
import { installErrorSinks, reportError } from "@/lib/errors";
import { installErrorSinks } from "@/lib/errors";
/**
* Initialise renderer error handling. When a DSN is configured, Sentry's
* own global handlers capture uncaught exceptions and unhandled promise
* rejections. Otherwise we install a minimal fallback so stray rejections
* aren't silent in dev / unconfigured envs.
* Initialise Sentry for a renderer process. No-ops when `sentryDsn` is empty
* so dev builds and unconfigured envs stay quiet.
*/
export function initSentryRenderer(): void {
if (appConfig.sentryDsn) {
Sentry.init({
dsn: appConfig.sentryDsn,
tracesSampleRate: 0,
});
if (!appConfig.sentryDsn) return;
installErrorSinks({
capture: (err, context) =>
Sentry.captureException(err, { extra: context }),
breadcrumb: (err, context) =>
Sentry.addBreadcrumb({
category: "error",
level: "error",
message: err instanceof Error ? err.message : String(err),
data: context,
}),
});
return;
}
window.addEventListener("unhandledrejection", (event) => {
reportError(event.reason, { scope: "unhandledrejection" });
Sentry.init({
dsn: appConfig.sentryDsn,
tracesSampleRate: 0,
});
window.addEventListener("error", (event) => {
reportError(event.error ?? new Error(event.message), {
scope: "window.error",
});
installErrorSinks({
capture: (err, context) =>
Sentry.captureException(err, { extra: context }),
breadcrumb: (err, context) =>
Sentry.addBreadcrumb({
category: "error",
level: "error",
message: err instanceof Error ? err.message : String(err),
data: context,
}),
});
}
+19 -28
View File
@@ -1,39 +1,30 @@
import { app } from "electron";
import * as Sentry from "@sentry/electron/main";
import { appConfig } from "@/config/env";
import { installErrorSinks, reportError } from "@/lib/errors";
import { installErrorSinks } from "@/lib/errors";
/**
* Initialise main-process error handling. Sentry owns uncaught-exception
* capture when a DSN is configured; otherwise we install a minimal Node
* fallback so rejections aren't silent. Safe to call before `app.whenReady`.
* Initialise Sentry for the main process. Captures uncaught exceptions from
* the Node side and the crash reporter. Safe to call before `app.whenReady`.
*/
export function initSentryMain(): void {
if (appConfig.sentryDsn) {
Sentry.init({
dsn: appConfig.sentryDsn,
tracesSampleRate: 0,
release: app.getVersion(),
});
if (!appConfig.sentryDsn) return;
installErrorSinks({
capture: (err, context) =>
Sentry.captureException(err, { extra: context }),
breadcrumb: (err, context) =>
Sentry.addBreadcrumb({
category: "error",
level: "error",
message: err instanceof Error ? err.message : String(err),
data: context,
}),
});
return;
}
process.on("uncaughtException", (err) => {
reportError(err, { scope: "uncaughtException" });
Sentry.init({
dsn: appConfig.sentryDsn,
tracesSampleRate: 0,
release: app.getVersion(),
});
process.on("unhandledRejection", (reason) => {
reportError(reason, { scope: "unhandledRejection" });
installErrorSinks({
capture: (err, context) =>
Sentry.captureException(err, { extra: context }),
breadcrumb: (err, context) =>
Sentry.addBreadcrumb({
category: "error",
level: "error",
message: err instanceof Error ? err.message : String(err),
data: context,
}),
});
}