Merge pull request #6 from TNkemdilim/hotfix/minor-cleanup

Chore(Cleanup): Resolve Warnings

src/hotspot/mod.rs

@@ -2,16 +2,19 @@ mod providers;
 
 use self::providers::prelude::HotspotConfig;
 use crate::platforms::{WifiError, WifiInterface};
-use std::{fmt, io};
+use std::fmt;
 
 /// Error that might occur when interacting managing wireless hotspot.
 #[derive(Debug)]
 pub enum WifiHotspotError {
     /// Failed to ceate wireless hotspot.
+    #[cfg(target_os = "linux")]
+    #[cfg(target_os = "windows")]
     CreationFailed,
     /// Failed to stop wireless hotspot service. Try turning off
     /// the wireless interface via ```wifi.turn_off()```.
-  FailedToStop(io::Error),
+    #[cfg(target_os = "linux")]
+    FailedToStop(std::io::Error),
     /// A wireless interface error occurred.
     Other { kind: WifiError },
 }

src/hotspot/providers/linux.rs

@@ -26,7 +26,6 @@ pub enum HotspotBand {
     Bg,
 }
 
-#[allow(dead_code)]
 #[derive(Debug, Clone, Copy)]
 /// Channel to broadcast wireless hotspot on.
 pub enum Channel {

src/hotspot/providers/osx.rs

@@ -1,9 +1,8 @@
-use hotspot::{WifiHotspot, WifiHotspotError};
+use hotspot::WifiHotspot;
-use connectivity::{Connectivity, WifiConnectionError};
 use platforms::WiFi;
-use std::process::Command;
 
 /// Configuration for a wireless hotspot.
+#[allow(dead_code)]
 pub struct HotspotConfig {}
 
 /// Wireless hotspot functionality for a wifi interface.

src/platforms/linux.rs

@@ -42,7 +42,7 @@ impl WifiInterface for Linux {
 
     /// Turn on the wireless network adapter.
     fn turn_on() -> Result<(), WifiError> {
-        let _output = Command::new("nmcli")
+        Command::new("nmcli")
             .args(&["radio", "wifi", "on"])
             .output()
             .map_err(|err| WifiError::IoError(err))?;
@@ -52,7 +52,7 @@ impl WifiInterface for Linux {
 
     /// Turn off the wireless network adapter.
     fn turn_off() -> Result<(), WifiError> {
-        let _output = Command::new("nmcli")
+        Command::new("nmcli")
             .args(&["radio", "wifi", "off"])
             .output()
             .map_err(|err| WifiError::IoError(err))?;

src/platforms/osx.rs

@@ -33,15 +33,12 @@ impl WifiInterface for Osx {
             .output()
             .map_err(|err| WifiError::IoError(err))?;
 
-        Ok(String::from_utf8_lossy(&output.stdout)
+        Ok(String::from_utf8_lossy(&output.stdout).contains("enabled"))
-            .replace(" ", "")
-            .replace("\n", "")
-            .contains("enabled"))
     }
 
     /// Turn on the wireless network adapter.
     fn turn_on() -> Result<(), WifiError> {
-        let output = Command::new("networksetup")
+        Command::new("networksetup")
             .args(&["-setairportpower", "en0", "on"])
             .output()
             .map_err(|err| WifiError::IoError(err))?;
@@ -51,7 +48,7 @@ impl WifiInterface for Osx {
 
     /// Turn off the wireless adapter.
     fn turn_off() -> Result<(), WifiError> {
-        let output = Command::new("networksetup")
+        Command::new("networksetup")
             .args(&["-setairportpower", "en0", "off"])
             .output()
             .map_err(|err| WifiError::IoError(err))?;

src/platforms/windows.rs

@@ -48,7 +48,7 @@ impl WifiInterface for Windows {
 
     /// Turn on the wireless network adapter.
     fn turn_on() -> Result<(), WifiError> {
-        let _output = Command::new("netsh")
+        Command::new("netsh")
             .args(&[
                 "interface",
                 "set",