From facd80b30c92d56bccd0931b77b3fec3d611fdd0 Mon Sep 17 00:00:00 2001 From: Alex Hultman Date: Sun, 28 Feb 2021 12:41:06 +0100 Subject: [PATCH] Use "mocked zlib" (not really) when fuzzing --- fuzzing/Makefile | 10 +++------- src/PerMessageDeflate.h | 5 ++--- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/fuzzing/Makefile b/fuzzing/Makefile index 7a8704f..3b02eb2 100644 --- a/fuzzing/Makefile +++ b/fuzzing/Makefile @@ -9,10 +9,6 @@ OUT ?= . WRAPPED_SYSCALLS = -Wl,--wrap=getpeername,--wrap=sendto,--wrap=send,--wrap=recv,--wrap=read,--wrap=listen,--wrap=getaddrinfo,--wrap=freeaddrinfo,--wrap=setsockopt,--wrap=fcntl,--wrap=bind,--wrap=socket,--wrap=epoll_wait,--wrap=epoll_create1,--wrap=timerfd_settime,--wrap=close,--wrap=accept4,--wrap=eventfd,--wrap=timerfd_create,--wrap=epoll_ctl,--wrap=shutdown oss-fuzz: -# Build zlib (it listens to CFLAGS, CC and CXX) - we need our fork to pass MemorySanitizer - rm -rf zlib - git clone https://github.com/alexhultman/zlib - cd zlib && ./configure && make # Copy dictionaries cp *.dict $(OUT) # libEpollFuzzer cases @@ -20,15 +16,15 @@ oss-fuzz: rm -rf *.o $(CC) $(CFLAGS) -DLIBUS_NO_SSL -std=c11 -I../uSockets/src -O3 -c ../uSockets/src/*.c ../uSockets/src/eventing/*.c ../uSockets/src/crypto/*.c # Link against object files - $(CXX) $(CXXFLAGS) $(WRAPPED_SYSCALLS) -std=c++17 -O2 -DUWS_NO_ZLIB -I../src -I../uSockets/src EpollHelloWorld.cpp -o $(OUT)/EpollHelloWorld $(LIB_FUZZING_ENGINE) *.o + $(CXX) $(CXXFLAGS) $(WRAPPED_SYSCALLS) -std=c++17 -O3 -DUWS_MOCK_ZLIB -I../src -I../uSockets/src EpollHelloWorld.cpp -o $(OUT)/EpollHelloWorld $(LIB_FUZZING_ENGINE) *.o rm -f EpollHelloWorld.o - $(CXX) $(CXXFLAGS) $(WRAPPED_SYSCALLS) -std=c++17 -O2 -DUWS_NO_ZLIB -I../src -I../uSockets/src EpollEchoServer.cpp -o $(OUT)/EpollEchoServer $(LIB_FUZZING_ENGINE) *.o + $(CXX) $(CXXFLAGS) $(WRAPPED_SYSCALLS) -std=c++17 -O3 -DUWS_MOCK_ZLIB -I../src -I../uSockets/src EpollEchoServer.cpp -o $(OUT)/EpollEchoServer $(LIB_FUZZING_ENGINE) *.o # "Unit tests" $(CXX) $(CXXFLAGS) -std=c++17 -O3 Extensions.cpp -o $(OUT)/Extensions $(LIB_FUZZING_ENGINE) $(CXX) $(CXXFLAGS) -std=c++17 -O3 QueryParser.cpp -o $(OUT)/QueryParser $(LIB_FUZZING_ENGINE) $(CXX) $(CXXFLAGS) -std=c++17 -O3 WebSocket.cpp -o $(OUT)/WebSocket $(LIB_FUZZING_ENGINE) $(CXX) $(CXXFLAGS) -std=c++17 -O3 Http.cpp -o $(OUT)/Http $(LIB_FUZZING_ENGINE) $(CXX) $(CXXFLAGS) -DUWS_WITH_PROXY -std=c++17 -O3 Http.cpp -o $(OUT)/HttpWithProxy $(LIB_FUZZING_ENGINE) - $(CXX) $(CXXFLAGS) -Izlib -std=c++17 -O3 PerMessageDeflate.cpp -o $(OUT)/PerMessageDeflate $(LIB_FUZZING_ENGINE) zlib/libz.a + $(CXX) $(CXXFLAGS) -DUWS_MOCK_ZLIB -std=c++17 -O3 PerMessageDeflate.cpp -o $(OUT)/PerMessageDeflate $(LIB_FUZZING_ENGINE) $(CXX) $(CXXFLAGS) -std=c++17 -O3 TopicTree.cpp -o $(OUT)/TopicTree $(LIB_FUZZING_ENGINE) diff --git a/src/PerMessageDeflate.h b/src/PerMessageDeflate.h index d47a07d..a7eb8ed 100644 --- a/src/PerMessageDeflate.h +++ b/src/PerMessageDeflate.h @@ -54,12 +54,11 @@ namespace uWS { namespace uWS { /* Do not compile this module if we don't want it */ -#ifdef UWS_NO_ZLIB +#if defined(UWS_NO_ZLIB) || defined(UWS_MOCK_ZLIB) struct ZlibContext {}; struct InflationStream { std::optional inflate(ZlibContext *zlibContext, std::string_view compressed, size_t maxPayloadLength) { - /* Anything here goes, it is never going to be called */ - return std::nullopt; + return compressed; } }; struct DeflationStream {