From cd33cd20bac52d385bf2fb98fc256de2b5abbd56 Mon Sep 17 00:00:00 2001 From: Robert Nagy Date: Wed, 23 Dec 2020 23:00:35 +0100 Subject: [PATCH] replace goto with loop (#1151) --- src/TopicTree.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/TopicTree.h b/src/TopicTree.h index 80dd180..43f3db5 100644 --- a/src/TopicTree.h +++ b/src/TopicTree.h @@ -80,8 +80,7 @@ private: /* Cull or trim unused Topic nodes from leaf to root */ void trimTree(Topic *topic) { - repeat: - if (!topic->subs.size() && !topic->children.size() && !topic->terminatingWildcardChild && !topic->wildcardChild) { + while (!topic->subs.size() && !topic->children.size() && !topic->terminatingWildcardChild && !topic->wildcardChild) { Topic *parent = topic->parent; if (topic->length == 1) { @@ -114,11 +113,11 @@ private: delete [] topic->name; delete topic; - if (parent != root) { - topic = parent; - goto repeat; - //trimTree(parent); + if (parent == root) { + break; } + + topic = parent; } }