talksik/tonic
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(build): Remove default impl for Server traits (#229)

Browse Source 
BREAKING CHANGE: remove default implementations for server traits.
This commit is contained in:
Juan Alvarez
2020-01-13 09:42:14 -05:00
committed by Lucio Franco
parent dadc8186c2
commit a41f55ab9d
3 changed files with 48 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/src/multiplex/server.rs
+22
View File
@@ -68,5 +68,27 @@ impl Echo for MyEcho {
} }
type ServerStreamingEchoStream = ResponseStream; type ServerStreamingEchoStream = ResponseStream;
async fn server_streaming_echo(
&self,
_: Request<EchoRequest>,
) -> Result<Response<Self::ServerStreamingEchoStream>, Status> {
Err(Status::unimplemented("Not yet implemented"))
}
async fn client_streaming_echo(
&self,
_: Request<tonic::Streaming<EchoRequest>>,
) -> Result<Response<EchoResponse>, Status> {
Err(Status::unimplemented("Not yet implemented"))
}
type BidirectionalStreamingEchoStream = ResponseStream; type BidirectionalStreamingEchoStream = ResponseStream;
async fn bidirectional_streaming_echo(
&self,
_: Request<tonic::Streaming<EchoRequest>>,
) -> Result<Response<Self::BidirectionalStreamingEchoStream>, Status> {
Err(Status::unimplemented("Not yet implemented"))
}
} }
examples/src/tls_client_auth/server.rs
+22
View File
@@ -26,7 +26,29 @@ impl pb::echo_server::Echo for EchoServer {
} }
type ServerStreamingEchoStream = ResponseStream; type ServerStreamingEchoStream = ResponseStream;
async fn server_streaming_echo(
&self,
_: Request<EchoRequest>,
) -> Result<Response<Self::ServerStreamingEchoStream>, Status> {
Err(Status::unimplemented("Not yet implemented"))
}
async fn client_streaming_echo(
&self,
_: Request<tonic::Streaming<EchoRequest>>,
) -> Result<Response<EchoResponse>, Status> {
Err(Status::unimplemented("Not yet implemented"))
}
type BidirectionalStreamingEchoStream = ResponseStream; type BidirectionalStreamingEchoStream = ResponseStream;
async fn bidirectional_streaming_echo(
&self,
_: Request<tonic::Streaming<EchoRequest>>,
) -> Result<Response<Self::BidirectionalStreamingEchoStream>, Status> {
Err(Status::unimplemented("Not yet implemented"))
}
} }
#[tokio::main] #[tokio::main]
tonic-build/src/server.rs
+4 -12
View File
@@ -108,18 +108,14 @@ fn generate_trait_methods(service: &Service, proto_path: &str) -> TokenStream {
quote! { quote! {
#method_doc #method_doc
async fn #name(&self, request: tonic::Request<#req_message>) async fn #name(&self, request: tonic::Request<#req_message>)
-> Result<tonic::Response<#res_message>, tonic::Status> { -> Result<tonic::Response<#res_message>, tonic::Status>;
Err(tonic::Status::unimplemented("Not yet implemented"))
}
} }
} }
(true, false) => { (true, false) => {
quote! { quote! {
#method_doc #method_doc
async fn #name(&self, request: tonic::Request<tonic::Streaming<#req_message>>) async fn #name(&self, request: tonic::Request<tonic::Streaming<#req_message>>)
-> Result<tonic::Response<#res_message>, tonic::Status> { -> Result<tonic::Response<#res_message>, tonic::Status>;
Err(tonic::Status::unimplemented("Not yet implemented"))
}
} }
} }
(false, true) => { (false, true) => {
@@ -135,9 +131,7 @@ fn generate_trait_methods(service: &Service, proto_path: &str) -> TokenStream {
#method_doc #method_doc
async fn #name(&self, request: tonic::Request<#req_message>) async fn #name(&self, request: tonic::Request<#req_message>)
-> Result<tonic::Response<Self::#stream>, tonic::Status> { -> Result<tonic::Response<Self::#stream>, tonic::Status>;
Err(tonic::Status::unimplemented("Not yet implemented"))
}
} }
} }
(true, true) => { (true, true) => {
@@ -153,9 +147,7 @@ fn generate_trait_methods(service: &Service, proto_path: &str) -> TokenStream {
#method_doc #method_doc
async fn #name(&self, request: tonic::Request<tonic::Streaming<#req_message>>) async fn #name(&self, request: tonic::Request<tonic::Streaming<#req_message>>)
-> Result<tonic::Response<Self::#stream>, tonic::Status> { -> Result<tonic::Response<Self::#stream>, tonic::Status>;
Err(tonic::Status::unimplemented("Not yet implemented"))
}
} }
} }
}; };