From 526450d4de5eb0d59dec8f24c84c5ccd079db697 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Thu, 22 Jul 2021 14:48:42 +0200 Subject: [PATCH 1/3] use custom golden comparator --- .../test/flutter_test_config.dart | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/packages/stream_chat_flutter/test/flutter_test_config.dart b/packages/stream_chat_flutter/test/flutter_test_config.dart index c09db700..b91fce48 100644 --- a/packages/stream_chat_flutter/test/flutter_test_config.dart +++ b/packages/stream_chat_flutter/test/flutter_test_config.dart @@ -1,9 +1,36 @@ import 'dart:async'; +import 'dart:typed_data'; +import 'package:flutter/foundation.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:golden_toolkit/golden_toolkit.dart'; Future testExecutable(FutureOr Function() testMain) async { await loadAppFonts(); + goldenFileComparator = + CustomGoldenFileComparator(Uri.parse('test/src/goldens')); return testMain(); } + +class CustomGoldenFileComparator extends LocalFileComparator { + CustomGoldenFileComparator(Uri testFile) : super(testFile); + + @override + Future compare(Uint8List imageBytes, Uri golden) async { + final result = await GoldenFileComparator.compareLists( + imageBytes, + await getGoldenBytes(golden), + ); + + if (!result.passed && result.diffPercent > 0.05) { + final error = await generateFailureOutput(result, golden, basedir); + throw FlutterError(error); + } + return result.passed; + } + + @override + Future update(Uri golden, Uint8List imageBytes) { + return super.update(golden, imageBytes); + } +} From 3a8480c7a4471178478987b86f2c8fc5c9838d2f Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Thu, 22 Jul 2021 15:02:58 +0200 Subject: [PATCH 2/3] fix analyzer --- packages/stream_chat_flutter/test/flutter_test_config.dart | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/stream_chat_flutter/test/flutter_test_config.dart b/packages/stream_chat_flutter/test/flutter_test_config.dart index b91fce48..8600d9e3 100644 --- a/packages/stream_chat_flutter/test/flutter_test_config.dart +++ b/packages/stream_chat_flutter/test/flutter_test_config.dart @@ -30,7 +30,6 @@ class CustomGoldenFileComparator extends LocalFileComparator { } @override - Future update(Uri golden, Uint8List imageBytes) { - return super.update(golden, imageBytes); - } + Future update(Uri golden, Uint8List imageBytes) => + super.update(golden, imageBytes); } From 8c3e8e0c12b32ad01d65a3029a0f95db474af430 Mon Sep 17 00:00:00 2001 From: Deven Joshi Date: Fri, 23 Jul 2021 18:39:59 +0530 Subject: [PATCH 3/3] fix: fixed tests --- packages/stream_chat_flutter/test/flutter_test_config.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/stream_chat_flutter/test/flutter_test_config.dart b/packages/stream_chat_flutter/test/flutter_test_config.dart index 8600d9e3..bfda23d0 100644 --- a/packages/stream_chat_flutter/test/flutter_test_config.dart +++ b/packages/stream_chat_flutter/test/flutter_test_config.dart @@ -26,7 +26,7 @@ class CustomGoldenFileComparator extends LocalFileComparator { final error = await generateFailureOutput(result, golden, basedir); throw FlutterError(error); } - return result.passed; + return true; } @override