From ea336a4d98f67ff23aa2af03ce7cae087d0bede8 Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Mon, 29 Nov 2021 22:13:11 +0530 Subject: [PATCH 1/3] ci(repo): fix melos bs for transitive deps --- .github/workflows/stream_flutter_workflow.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/stream_flutter_workflow.yml b/.github/workflows/stream_flutter_workflow.yml index b91dcb85..e3d7d231 100644 --- a/.github/workflows/stream_flutter_workflow.yml +++ b/.github/workflows/stream_flutter_workflow.yml @@ -3,6 +3,7 @@ name: stream_flutter_workflow env: ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true' flutter_version: "2.5.1" + melos_version: "1.0.0-dev.10" on: pull_request: @@ -31,7 +32,7 @@ jobs: flutter-version: ${{ env.flutter_version }} - name: "Install Tools" run: | - flutter pub global activate melos 1.0.0-dev.10 + flutter pub global activate melos ${{ env.melos_version }} - name: "Bootstrap Workspace" run: melos bootstrap - name: "Dart Analyze" @@ -60,7 +61,8 @@ jobs: with: flutter-version: ${{ env.flutter_version }} - name: "Install Tools" - run: flutter pub global activate melos + run: | + flutter pub global activate melos ${{ env.melos_version }} - name: "Bootstrap Workspace" run: melos bootstrap - name: "Melos Format" @@ -88,7 +90,7 @@ jobs: flutter-version: ${{ env.flutter_version }} - name: "Install Tools" run: | - flutter pub global activate melos + flutter pub global activate melos ${{ env.melos_version }} pub global activate remove_from_coverage - name: "Bootstrap Workspace" run: melos bootstrap @@ -120,4 +122,4 @@ jobs: uses: VeryGoodOpenSource/very_good_coverage@v1.1.1 with: path: packages/stream_chat_flutter/coverage/lcov.info - min_coverage: 67 \ No newline at end of file + min_coverage: 67 From 1e49156618f2ea20e3d593500e06e6764479146d Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Mon, 29 Nov 2021 22:56:02 +0530 Subject: [PATCH 2/3] test(core): fix failing tests Signed-off-by: xsahil03x --- .../stream_chat_flutter_core/lib/src/channel_list_core.dart | 5 +---- .../test/channel_list_core_test.dart | 4 ++-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart b/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart index 51467ca3..d807091c 100644 --- a/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart +++ b/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart @@ -157,10 +157,7 @@ class ChannelListCoreState extends State { presence: widget.presence, memberLimit: widget.memberLimit, messageLimit: widget.messageLimit, - paginationParams: PaginationParams( - limit: widget.limit, - offset: 0, - ), + paginationParams: PaginationParams(limit: widget.limit, offset: 0), ); /// Fetches more channels with updated pagination and updates the widget diff --git a/packages/stream_chat_flutter_core/test/channel_list_core_test.dart b/packages/stream_chat_flutter_core/test/channel_list_core_test.dart index 88711647..5f7c0e03 100644 --- a/packages/stream_chat_flutter_core/test/channel_list_core_test.dart +++ b/packages/stream_chat_flutter_core/test/channel_list_core_test.dart @@ -9,7 +9,7 @@ import 'package:stream_chat_flutter_core/stream_chat_flutter_core.dart'; import 'mocks.dart'; void main() { - const pagination = PaginationParams(limit: 3); + const pagination = PaginationParams(limit: 3, offset: 0); List _generateChannels( StreamChatClient client, { @@ -476,7 +476,7 @@ void main() { _stateSetter?.call(() => limit = 6); final updatedChannels = _generateChannels(mockClient, count: limit); - final updatedPagination = PaginationParams(limit: limit); + final updatedPagination = PaginationParams(limit: limit, offset: 0); when(() => mockClient.queryChannels( filter: any(named: 'filter'), sort: any(named: 'sort'), From 05a9bfeb02d5cd3c69664f2f659ccc9af449e07b Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Mon, 29 Nov 2021 23:33:20 +0530 Subject: [PATCH 3/3] ci(repo): increase test timeout Signed-off-by: xsahil03x --- .github/workflows/stream_flutter_workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stream_flutter_workflow.yml b/.github/workflows/stream_flutter_workflow.yml index e3d7d231..cc093a31 100644 --- a/.github/workflows/stream_flutter_workflow.yml +++ b/.github/workflows/stream_flutter_workflow.yml @@ -73,7 +73,7 @@ jobs: test: runs-on: macos-latest - timeout-minutes: 15 + timeout-minutes: 20 steps: - name: "Git Checkout" uses: actions/checkout@v2