Merge pull request #517 from GetStream/fix/messageListView

fix!: remove proxy properties from `MessageListView` [CDS-341]
This commit is contained in:
Salvatore Giordano
2021-07-08 09:42:07 +02:00
committed by GitHub
4 changed files with 17 additions and 60 deletions
@@ -269,7 +269,7 @@ class _MessageScreenState extends State<MessageScreen> {
},
);
},
errorWidgetBuilder: (BuildContext context, error) {
errorBuilder: (BuildContext context, error) {
print(error.toString());
return Center(
child: SizedBox(
@@ -40,7 +40,7 @@ import 'package:stream_chat_flutter_core/src/typedef.dart';
/// messageListBuilder: (context, list) {
/// return MessagesPage(list);
/// },
/// errorWidgetBuilder: (context, err) {
/// errorBuilder: (context, err) {
/// return Center(
/// child: Text('Error'),
/// );
@@ -67,7 +67,7 @@ class MessageListCore extends StatefulWidget {
required this.loadingBuilder,
required this.emptyBuilder,
required this.messageListBuilder,
required this.errorWidgetBuilder,
required this.errorBuilder,
this.parentMessage,
this.messageListController,
this.messageFilter,
@@ -91,7 +91,7 @@ class MessageListCore extends StatefulWidget {
///
/// This parameter can be used to display an error message to users in the
/// event of a connection failure.
final ErrorBuilder errorWidgetBuilder;
final ErrorBuilder errorBuilder;
/// If the current message belongs to a `thread`, this property represents the
/// first message or the parent of the conversation.
@@ -144,7 +144,7 @@ class MessageListCoreState extends State<MessageListCore> {
growable: false,
),
),
errorBuilder: widget.errorWidgetBuilder,
errorBuilder: widget.errorBuilder,
loadingBuilder: widget.loadingBuilder,
builder: (context, data) {
final messageList = data?.reversed.toList(growable: false) ?? [];
@@ -72,7 +72,7 @@ void main() {
messageListBuilder: (_, __) => Offstage(),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
);
await tester.pumpWidget(messageListCore);
@@ -91,7 +91,7 @@ void main() {
messageListBuilder: (_, __) => Offstage(),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
);
final mockChannel = MockChannel();
@@ -123,7 +123,7 @@ void main() {
messageListBuilder: (_, __) => Offstage(),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
messageListController: controller,
);
@@ -159,7 +159,7 @@ void main() {
messageListBuilder: (_, __) => Offstage(),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
messageListController: controller,
);
@@ -210,7 +210,7 @@ void main() {
messageListBuilder: (_, __) => Offstage(),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(
errorBuilder: (BuildContext context, Object error) => Offstage(
key: errorWidgetKey,
),
);
@@ -252,7 +252,7 @@ void main() {
messageListBuilder: (_, __) => Offstage(),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(key: emptyWidgetKey),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
);
final mockChannel = MockChannel();
@@ -292,7 +292,7 @@ void main() {
messageListBuilder: (_, __) => Offstage(key: listWidgetKey),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
);
final mockChannel = MockChannel();
@@ -346,7 +346,7 @@ void main() {
),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
);
final mockChannel = MockChannel();
@@ -393,7 +393,7 @@ void main() {
),
loadingBuilder: (BuildContext context) => Offstage(),
emptyBuilder: (BuildContext context) => Offstage(),
errorWidgetBuilder: (BuildContext context, Object error) => Offstage(),
errorBuilder: (BuildContext context, Object error) => Offstage(),
parentMessage: parentMessage,
);