chore: use isConnected flag instead of checking db value.

Signed-off-by: xsahil03x <[email protected]>
This commit is contained in:
Sahil Kumar
2023-05-19 01:36:35 +05:30
committed by xsahil03x
parent 4c47145ba5
commit 96c538a4c1
3 changed files with 11 additions and 9 deletions
@@ -12,6 +12,9 @@ import 'package:stream_chat/src/db/chat_persistence_client.dart';
import 'package:test/test.dart'; import 'package:test/test.dart';
class TestPersistenceClient extends ChatPersistenceClient { class TestPersistenceClient extends ChatPersistenceClient {
@override
bool get isConnected => throw UnimplementedError();
@override @override
Future<void> connect(String userId) => throw UnimplementedError(); Future<void> connect(String userId) => throw UnimplementedError();
@@ -58,7 +58,7 @@ class StreamChatPersistenceClient extends ChatPersistenceClient {
bool get _debugIsConnected { bool get _debugIsConnected {
assert(() { assert(() {
if (db == null) { if (!isConnected) {
throw StateError(''' throw StateError('''
$runtimeType hasn't been connected yet or used after `disconnect` $runtimeType hasn't been connected yet or used after `disconnect`
was called. Consider calling `connect` to create a connection. was called. Consider calling `connect` to create a connection.
@@ -408,7 +408,7 @@ class StreamChatPersistenceClient extends ChatPersistenceClient {
@override @override
Future<void> disconnect({bool flush = false}) async { Future<void> disconnect({bool flush = false}) async {
_logger.info('disconnect'); _logger.info('disconnect');
if (db != null) { if (isConnected) {
_logger.info('Disconnecting'); _logger.info('Disconnecting');
if (flush) { if (flush) {
_logger.info('Flushing'); _logger.info('Flushing');
@@ -16,9 +16,9 @@ void main() {
const userId = 'testUserId'; const userId = 'testUserId';
test('successfully connects with the Database', () async { test('successfully connects with the Database', () async {
final client = StreamChatPersistenceClient(logLevel: Level.ALL); final client = StreamChatPersistenceClient(logLevel: Level.ALL);
expect(client.db, isNull); expect(client.isConnected, false);
await client.connect(userId, databaseProvider: testDatabaseProvider); await client.connect(userId, databaseProvider: testDatabaseProvider);
expect(client.db, isNotNull); expect(client.isConnected, true);
expect(client.db, isA<DriftChatDatabase>()); expect(client.db, isA<DriftChatDatabase>());
expect(client.db!.userId, userId); expect(client.db!.userId, userId);
@@ -29,10 +29,9 @@ void main() {
test('throws if already connected', () async { test('throws if already connected', () async {
final client = StreamChatPersistenceClient(logLevel: Level.ALL); final client = StreamChatPersistenceClient(logLevel: Level.ALL);
expect(client.db, isNull); expect(client.isConnected, false);
await client.connect(userId, databaseProvider: testDatabaseProvider); await client.connect(userId, databaseProvider: testDatabaseProvider);
expect(client.db, isNotNull); expect(client.isConnected, true);
expect(client.db, isNotNull);
expect(client.db, isA<DriftChatDatabase>()); expect(client.db, isA<DriftChatDatabase>());
expect(client.db!.userId, userId); expect(client.db!.userId, userId);
expect( expect(
@@ -50,9 +49,9 @@ void main() {
const userId = 'testUserId'; const userId = 'testUserId';
final client = StreamChatPersistenceClient(logLevel: Level.ALL); final client = StreamChatPersistenceClient(logLevel: Level.ALL);
await client.connect(userId, databaseProvider: testDatabaseProvider); await client.connect(userId, databaseProvider: testDatabaseProvider);
expect(client.db, isNotNull); expect(client.isConnected, true);
await client.disconnect(flush: true); await client.disconnect(flush: true);
expect(client.db, isNull); expect(client.isConnected, false);
}); });
test('client function throws stateError if db is not yet connected', () { test('client function throws stateError if db is not yet connected', () {