From 8cb95cfd7ccafa96320ddb88200e08066a1782eb Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 20 Sep 2021 15:54:50 +0200 Subject: [PATCH] Revert "fix(ui): fix `MessageListView` header and footer while reverse: false" This reverts commit 59ded0e033ba315239466b4a9a1ff8544aa46e10. --- .../lib/src/message_list_view.dart | 36 +++++++------------ 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/message_list_view.dart b/packages/stream_chat_flutter/lib/src/message_list_view.dart index 77938032..61053106 100644 --- a/packages/stream_chat_flutter/lib/src/message_list_view.dart +++ b/packages/stream_chat_flutter/lib/src/message_list_view.dart @@ -494,18 +494,14 @@ class _MessageListViewState extends State { return _buildThreadSeparator(); } if (i == itemCount - 3) { - if (widget.reverse - ? widget.headerBuilder == null - : widget.footerBuilder == null) { + if (widget.headerBuilder == null) { if (_isThreadConversation) return const Offstage(); return const SizedBox(height: 52); } return const SizedBox(height: 8); } if (i == 0) { - if (widget.reverse - ? widget.footerBuilder == null - : widget.headerBuilder == null) { + if (widget.footerBuilder == null) { return const SizedBox(height: 30); } return const SizedBox(height: 8); @@ -564,13 +560,8 @@ class _MessageListViewState extends State { } if (i == itemCount - 2) { - if (widget.reverse) { - return widget.headerBuilder?.call(context) ?? - const Offstage(); - } else { - return widget.footerBuilder?.call(context) ?? - const Offstage(); - } + return widget.headerBuilder?.call(context) ?? + const Offstage(); } if (i == itemCount - 3) { @@ -588,13 +579,8 @@ class _MessageListViewState extends State { } if (i == 0) { - if (widget.reverse) { - return widget.footerBuilder?.call(context) ?? - const Offstage(); - } else { - return widget.headerBuilder?.call(context) ?? - const Offstage(); - } + return widget.footerBuilder?.call(context) ?? + const Offstage(); } const bottomMessageIndex = 2; // 1 -> loader // 0 -> footer @@ -1213,10 +1199,12 @@ class _MessageListViewState extends State { initialAlignment = _initialAlignment; WidgetsBinding.instance!.addPostFrameCallback((timeStamp) { - _scrollController?.jumpTo( - index: initialIndex, - alignment: initialAlignment, - ); + if (_scrollController?.isAttached == true) { + _scrollController?.jumpTo( + index: initialIndex, + alignment: initialAlignment, + ); + } }); _messageNewListener =