From 525380bddd5805e30a4d023e3b89228d370ab2b6 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Tue, 31 May 2022 10:45:03 +0200 Subject: [PATCH 1/3] fix(ui): fix file download --- .../app/src/main/kotlin/com/example/example/Application.kt | 4 ++-- packages/stream_chat_flutter/lib/src/utils.dart | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/stream_chat_flutter/example/android/app/src/main/kotlin/com/example/example/Application.kt b/packages/stream_chat_flutter/example/android/app/src/main/kotlin/com/example/example/Application.kt index f1bd7610..97b327c1 100644 --- a/packages/stream_chat_flutter/example/android/app/src/main/kotlin/com/example/example/Application.kt +++ b/packages/stream_chat_flutter/example/android/app/src/main/kotlin/com/example/example/Application.kt @@ -10,8 +10,8 @@ class Application : FlutterApplication(), PluginRegistrantCallback { super.onCreate() } - override fun registerWith(registry: PluginRegistry?) { - PathProviderPlugin.registerWith(registry?.registrarFor( + override fun registerWith(registry: PluginRegistry) { + PathProviderPlugin.registerWith(registry.registrarFor( "io.flutter.plugins.pathprovider.PathProviderPlugin")) } } \ No newline at end of file diff --git a/packages/stream_chat_flutter/lib/src/utils.dart b/packages/stream_chat_flutter/lib/src/utils.dart index 86357803..04800e98 100644 --- a/packages/stream_chat_flutter/lib/src/utils.dart +++ b/packages/stream_chat_flutter/lib/src/utils.dart @@ -9,7 +9,10 @@ import 'package:url_launcher/url_launcher.dart'; /// Launch URL Future launchURL(BuildContext context, String url) async { try { - await launchUrl(Uri.parse(url).withScheme); + await launchUrl( + Uri.parse(url).withScheme, + mode: LaunchMode.externalApplication, + ); } catch (e) { ScaffoldMessenger.of(context).showSnackBar( SnackBar(content: Text(context.translations.launchUrlError)), From a3285c340e0aef7d7abdd10ab319efb077c934cf Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Tue, 31 May 2022 10:46:13 +0200 Subject: [PATCH 2/3] chore(ui): update changelog --- packages/stream_chat_flutter/CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/stream_chat_flutter/CHANGELOG.md b/packages/stream_chat_flutter/CHANGELOG.md index 3f9509fb..8aefa739 100644 --- a/packages/stream_chat_flutter/CHANGELOG.md +++ b/packages/stream_chat_flutter/CHANGELOG.md @@ -1,3 +1,9 @@ +## Upcoming + +🐞 Fixed + +-[[#1180]](https://github.com/GetStream/stream-chat-flutter/issues/1180) Fix file download + ## 4.2.0 🐞 Fixed From f3b2926492894e0d667be4d4511e96e5825a2443 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Tue, 31 May 2022 15:09:12 +0200 Subject: [PATCH 3/3] make workflow run on pr update --- .github/workflows/stream_flutter_workflow.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/stream_flutter_workflow.yml b/.github/workflows/stream_flutter_workflow.yml index e9138e36..8b2d2481 100644 --- a/.github/workflows/stream_flutter_workflow.yml +++ b/.github/workflows/stream_flutter_workflow.yml @@ -7,6 +7,7 @@ env: on: pull_request: + types: [opened, synchronize, reopened, ready_for_review, converted_to_draft] push: branches: - master