From 73d652772518bb089aa8d421843b8f90cb018e11 Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Thu, 17 Jun 2021 17:09:50 +0530 Subject: [PATCH] fix analyzer warnings Signed-off-by: Sahil Kumar --- packages/stream_chat/lib/src/client/client.dart | 2 ++ packages/stream_chat/lib/src/core/models/event.dart | 2 -- packages/stream_chat/test/src/matchers.dart | 1 - packages/stream_chat/test/src/mocks.dart | 3 --- packages/stream_chat_flutter/analysis_options.yaml | 2 +- .../stream_chat_flutter/lib/src/channel_list_view.dart | 4 ++++ .../lib/src/channel_list_core.dart | 10 ++++------ 7 files changed, 11 insertions(+), 13 deletions(-) diff --git a/packages/stream_chat/lib/src/client/client.dart b/packages/stream_chat/lib/src/client/client.dart index ecadfe3b..b9e1c5d7 100644 --- a/packages/stream_chat/lib/src/client/client.dart +++ b/packages/stream_chat/lib/src/client/client.dart @@ -1373,6 +1373,7 @@ class ClientState { _userController.add(user); } + /// Update all the [users] with the provided [userList] void updateUsers(List userList) { final newUsers = { ...users, @@ -1382,6 +1383,7 @@ class ClientState { _usersController.add(newUsers); } + /// Update the passed [user] in state void updateUser(User? user) => updateUsers([user]); /// The current user diff --git a/packages/stream_chat/lib/src/core/models/event.dart b/packages/stream_chat/lib/src/core/models/event.dart index 21dd069c..26831555 100644 --- a/packages/stream_chat/lib/src/core/models/event.dart +++ b/packages/stream_chat/lib/src/core/models/event.dart @@ -1,5 +1,3 @@ -import 'dart:convert'; - import 'package:json_annotation/json_annotation.dart'; import 'package:stream_chat/src/core/models/channel_model.dart'; import 'package:stream_chat/src/core/models/message.dart'; diff --git a/packages/stream_chat/test/src/matchers.dart b/packages/stream_chat/test/src/matchers.dart index c039b416..27cfa43d 100644 --- a/packages/stream_chat/test/src/matchers.dart +++ b/packages/stream_chat/test/src/matchers.dart @@ -1,7 +1,6 @@ import 'package:collection/collection.dart'; import 'package:dio/dio.dart' show MultipartFile; import 'package:stream_chat/src/client/channel.dart'; -import 'package:stream_chat/src/core/models/channel_model.dart'; import 'package:stream_chat/src/core/models/channel_state.dart'; import 'package:stream_chat/src/core/models/event.dart'; import 'package:stream_chat/src/core/models/message.dart'; diff --git a/packages/stream_chat/test/src/mocks.dart b/packages/stream_chat/test/src/mocks.dart index 528c8a91..c4a5d64f 100644 --- a/packages/stream_chat/test/src/mocks.dart +++ b/packages/stream_chat/test/src/mocks.dart @@ -3,7 +3,6 @@ import 'package:logging/logging.dart'; import 'package:mocktail/mocktail.dart'; import 'package:stream_chat/src/client/channel.dart'; import 'package:stream_chat/src/client/client.dart'; -import 'package:stream_chat/src/client/retry_policy.dart'; import 'package:stream_chat/src/core/api/attachment_file_uploader.dart'; import 'package:stream_chat/src/core/api/channel_api.dart'; import 'package:stream_chat/src/core/api/device_api.dart'; @@ -16,12 +15,10 @@ import 'package:stream_chat/src/core/http/connection_id_manager.dart'; import 'package:stream_chat/src/core/http/stream_http_client.dart'; import 'package:stream_chat/src/core/http/token_manager.dart'; import 'package:stream_chat/src/core/models/channel_config.dart'; -import 'package:stream_chat/src/core/models/channel_model.dart'; import 'package:stream_chat/src/db/chat_persistence_client.dart'; import 'package:stream_chat/src/ws/websocket.dart'; import 'package:web_socket_channel/web_socket_channel.dart'; -import 'db/chat_persistence_client_test.dart'; class MockWebSocketChannel extends Mock implements WebSocketChannel {} diff --git a/packages/stream_chat_flutter/analysis_options.yaml b/packages/stream_chat_flutter/analysis_options.yaml index f0a87ea5..ed0ce983 100644 --- a/packages/stream_chat_flutter/analysis_options.yaml +++ b/packages/stream_chat_flutter/analysis_options.yaml @@ -6,7 +6,7 @@ analyzer: - example/** - lib/src/emoji - lib/**/*.freezed.dart - - test/** +# - test/** linter: rules: diff --git a/packages/stream_chat_flutter/lib/src/channel_list_view.dart b/packages/stream_chat_flutter/lib/src/channel_list_view.dart index f6acf35e..d131c33b 100644 --- a/packages/stream_chat_flutter/lib/src/channel_list_view.dart +++ b/packages/stream_chat_flutter/lib/src/channel_list_view.dart @@ -113,9 +113,13 @@ class ChannelListView extends StatefulWidget { /// If true listen to changes to this Channel in real time. final bool watch; + /// If true you’ll receive user presence updates via the websocket events final bool presence; + /// Number of members to fetch in each channel final int? memberLimit; + + /// Number of messages to fetch in each channel final int? messageLimit; /// Pagination parameters diff --git a/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart b/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart index 684fd630..6dc52647 100644 --- a/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart +++ b/packages/stream_chat_flutter_core/lib/src/channel_list_core.dart @@ -98,12 +98,6 @@ class ChannelListCore extends StatefulWidget { /// You can also filter other built-in channel fields. final Filter? filter; - // bool state = true, - // bool watch = true, - // bool presence = false, - // int? memberLimit, - // int? messageLimit, - /// The sorting used for the channels matching the filters. /// Sorting is based on field and direction, multiple sorting options can be /// provided. @@ -117,9 +111,13 @@ class ChannelListCore extends StatefulWidget { /// If true listen to changes to this Channel in real time. final bool watch; + /// If true you’ll receive user presence updates via the websocket events final bool presence; + /// Number of members to fetch in each channel final int? memberLimit; + + /// Number of messages to fetch in each channel final int? messageLimit; /// Pagination parameters