From 64bf65491ddb273da9372d8280052f6eab0b7177 Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Mon, 13 Jun 2022 14:10:21 +0530 Subject: [PATCH] fix(ui): video breaks bottom photo carousel. Signed-off-by: xsahil03x --- .../lib/src/gallery_footer.dart | 5 +++-- .../lib/src/video_thumbnail_image.dart | 21 ++++++++++++------- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/gallery_footer.dart b/packages/stream_chat_flutter/lib/src/gallery_footer.dart index 1b78f262..6a94f804 100644 --- a/packages/stream_chat_flutter/lib/src/gallery_footer.dart +++ b/packages/stream_chat_flutter/lib/src/gallery_footer.dart @@ -225,11 +225,12 @@ class _StreamGalleryFooterState extends State { if (attachment.type == 'video') { media = InkWell( onTap: () => widget.mediaSelectedCallBack!(index), - child: FittedBox( - fit: BoxFit.cover, + child: AspectRatio( + aspectRatio: 1, child: StreamVideoThumbnailImage( video: (attachment.file?.path ?? attachment.assetUrl)!, + fit: BoxFit.cover, ), ), ); diff --git a/packages/stream_chat_flutter/lib/src/video_thumbnail_image.dart b/packages/stream_chat_flutter/lib/src/video_thumbnail_image.dart index 9f778278..de00d14e 100644 --- a/packages/stream_chat_flutter/lib/src/video_thumbnail_image.dart +++ b/packages/stream_chat_flutter/lib/src/video_thumbnail_image.dart @@ -97,8 +97,9 @@ class _StreamVideoThumbnailImageState extends State { ); } if (!snapshot.hasData) { - return Container( - constraints: const BoxConstraints.expand(), + return SizedBox( + height: double.maxFinite, + width: double.maxFinite, child: widget.placeholderBuilder?.call(context) ?? Shimmer.fromColors( baseColor: _streamChatTheme.colorTheme.disabled, @@ -106,16 +107,22 @@ class _StreamVideoThumbnailImageState extends State { child: Image.asset( 'images/placeholder.png', fit: BoxFit.cover, + height: widget.height, + width: widget.width, package: 'stream_chat_flutter', ), ), ); } - return Image.memory( - snapshot.data!, - fit: widget.fit, - height: widget.height, - width: widget.width, + return SizedBox( + height: double.maxFinite, + width: double.maxFinite, + child: Image.memory( + snapshot.data!, + fit: widget.fit, + height: widget.height, + width: widget.width, + ), ); }, ),