From 701559fcdddf5f287ec663c9a52e47e3d8f7beef Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 25 Apr 2022 11:57:42 +0200 Subject: [PATCH 1/3] fix(ui): remove check for launchUrl --- .../lib/src/attachment/file_attachment.dart | 1 + packages/stream_chat_flutter/lib/src/utils.dart | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart b/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart index 0b5d580f..a6ed3ed8 100644 --- a/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart +++ b/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart @@ -259,6 +259,7 @@ class FileAttachment extends AttachmentWidget { splashRadius: 16, onPressed: () { final assetUrl = attachment.assetUrl; + print('assetUrl: $assetUrl'); if (assetUrl != null) launchURL(context, assetUrl); }, ); diff --git a/packages/stream_chat_flutter/lib/src/utils.dart b/packages/stream_chat_flutter/lib/src/utils.dart index 2d661fbc..af2ac0c0 100644 --- a/packages/stream_chat_flutter/lib/src/utils.dart +++ b/packages/stream_chat_flutter/lib/src/utils.dart @@ -8,9 +8,9 @@ import 'package:url_launcher/url_launcher.dart'; /// Launch URL Future launchURL(BuildContext context, String url) async { - if (await canLaunch(url)) { + try { await launch(url); - } else { + } catch (e) { ScaffoldMessenger.of(context).showSnackBar( SnackBar(content: Text(context.translations.launchUrlError)), ); From 277c5a37b143910d6530dd58ddee0378ef438ed4 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 25 Apr 2022 11:58:47 +0200 Subject: [PATCH 2/3] chore(ui): update changelog --- packages/stream_chat_flutter/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/stream_chat_flutter/CHANGELOG.md b/packages/stream_chat_flutter/CHANGELOG.md index 16650f88..f7ff2d6c 100644 --- a/packages/stream_chat_flutter/CHANGELOG.md +++ b/packages/stream_chat_flutter/CHANGELOG.md @@ -4,6 +4,7 @@ - [[#1067]](https://github.com/GetStream/stream-chat-flutter/issues/1067): Fix name text overflow in reaction card. - [[#842]](https://github.com/GetStream/stream-chat-flutter/issues/842): show date divider for first message. +- Loosen up url check for attachment download. ## 3.6.1 From 76f6ce6d0f1b972ccb831757a0cbb8da2a00b156 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 25 Apr 2022 12:09:50 +0200 Subject: [PATCH 3/3] remove print --- .../stream_chat_flutter/lib/src/attachment/file_attachment.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart b/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart index a6ed3ed8..0b5d580f 100644 --- a/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart +++ b/packages/stream_chat_flutter/lib/src/attachment/file_attachment.dart @@ -259,7 +259,6 @@ class FileAttachment extends AttachmentWidget { splashRadius: 16, onPressed: () { final assetUrl = attachment.assetUrl; - print('assetUrl: $assetUrl'); if (assetUrl != null) launchURL(context, assetUrl); }, );