From b3f51115d5e94d12f6f28b6af3515ea771b153ce Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 12:51:19 +0100 Subject: [PATCH 01/16] remove future once it's completed --- packages/stream_chat/lib/src/client.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/stream_chat/lib/src/client.dart b/packages/stream_chat/lib/src/client.dart index 2c36f4f6..c5d5322f 100644 --- a/packages/stream_chat/lib/src/client.dart +++ b/packages/stream_chat/lib/src/client.dart @@ -611,7 +611,9 @@ class StreamChatClient { options: options, paginationParams: paginationParams, messageLimit: messageLimit, - ); + ).whenComplete(() { + _queryChannelsStreams.remove(hash); + }); _queryChannelsStreams[hash] = newQueryChannelsFuture; From c0271b2cb2833b7f1aa1f217197f7cc565dee4d1 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 12:56:27 +0100 Subject: [PATCH 02/16] bump version --- packages/stream_chat/CHANGELOG.md | 4 ++++ packages/stream_chat/lib/version.dart | 2 +- packages/stream_chat/pubspec.yaml | 2 +- packages/stream_chat_flutter/CHANGELOG.md | 5 +++++ packages/stream_chat_flutter/lib/src/channel_name.dart | 4 +++- packages/stream_chat_flutter/pubspec.yaml | 4 ++-- packages/stream_chat_flutter_core/CHANGELOG.md | 4 ++++ packages/stream_chat_flutter_core/pubspec.yaml | 4 ++-- 8 files changed, 22 insertions(+), 7 deletions(-) diff --git a/packages/stream_chat/CHANGELOG.md b/packages/stream_chat/CHANGELOG.md index 30ae46f7..c688d4f6 100644 --- a/packages/stream_chat/CHANGELOG.md +++ b/packages/stream_chat/CHANGELOG.md @@ -1,3 +1,7 @@ +## 1.3.2-beta + +- Fixed queryChannels bug + ## 1.3.1-beta - Debounced frequent db calls diff --git a/packages/stream_chat/lib/version.dart b/packages/stream_chat/lib/version.dart index 8af293af..2c9c2639 100644 --- a/packages/stream_chat/lib/version.dart +++ b/packages/stream_chat/lib/version.dart @@ -2,4 +2,4 @@ import 'package:stream_chat/src/client.dart'; /// Current package version /// Used in [StreamChatClient] to build the `x-stream-client` header -const PACKAGE_VERSION = '1.3.1-beta'; +const PACKAGE_VERSION = '1.3.2-beta'; diff --git a/packages/stream_chat/pubspec.yaml b/packages/stream_chat/pubspec.yaml index 63d41615..197c3f54 100644 --- a/packages/stream_chat/pubspec.yaml +++ b/packages/stream_chat/pubspec.yaml @@ -1,7 +1,7 @@ name: stream_chat homepage: https://getstream.io/ description: The official Dart client for Stream Chat, a service for building chat applications. -version: 1.3.1-beta +version: 1.3.2-beta repository: https://github.com/GetStream/stream-chat-flutter issue_tracker: https://github.com/GetStream/stream-chat-flutter/issues diff --git a/packages/stream_chat_flutter/CHANGELOG.md b/packages/stream_chat_flutter/CHANGELOG.md index 967536dd..73ac6d4b 100644 --- a/packages/stream_chat_flutter/CHANGELOG.md +++ b/packages/stream_chat_flutter/CHANGELOG.md @@ -1,3 +1,8 @@ +## 1.3.2-beta + +- Updated `stream_chat_core` dependency +- Fixed minor bugs + ## 1.3.1-beta - Updated `stream_chat_core` dependency diff --git a/packages/stream_chat_flutter/lib/src/channel_name.dart b/packages/stream_chat_flutter/lib/src/channel_name.dart index 7907de9a..53817563 100644 --- a/packages/stream_chat_flutter/lib/src/channel_name.dart +++ b/packages/stream_chat_flutter/lib/src/channel_name.dart @@ -42,7 +42,9 @@ class ChannelName extends StatelessWidget { if (extraData['name'] == null) { final otherMembers = members.where((member) => member.userId != client.user.id); - if (otherMembers.isNotEmpty) { + if (otherMembers.length == 1) { + title = otherMembers.first.user.name; + } else if (otherMembers.isNotEmpty) { final maxWidth = constraints.maxWidth; final maxChars = maxWidth / textStyle.fontSize; var currentChars = 0; diff --git a/packages/stream_chat_flutter/pubspec.yaml b/packages/stream_chat_flutter/pubspec.yaml index b0192aa1..a1880163 100644 --- a/packages/stream_chat_flutter/pubspec.yaml +++ b/packages/stream_chat_flutter/pubspec.yaml @@ -1,7 +1,7 @@ name: stream_chat_flutter homepage: https://github.com/GetStream/stream-chat-flutter description: Stream Chat official Flutter SDK. Build your own chat experience using Dart and Flutter. -version: 1.3.1-beta +version: 1.3.2-beta repository: https://github.com/GetStream/stream-chat-flutter issue_tracker: https://github.com/GetStream/stream-chat-flutter/issues @@ -11,7 +11,7 @@ environment: dependencies: flutter: sdk: flutter - stream_chat_flutter_core: ^1.3.0-beta + stream_chat_flutter_core: ^1.3.2-beta flutter_app_badger: ^1.1.2 photo_view: ^0.10.3 rxdart: ^0.25.0 diff --git a/packages/stream_chat_flutter_core/CHANGELOG.md b/packages/stream_chat_flutter_core/CHANGELOG.md index bbf8b9f5..ff7160ac 100644 --- a/packages/stream_chat_flutter_core/CHANGELOG.md +++ b/packages/stream_chat_flutter_core/CHANGELOG.md @@ -1,3 +1,7 @@ +## 1.3.2-beta + +* Update llc dependency + ## 1.3.1-beta * Update llc dependency diff --git a/packages/stream_chat_flutter_core/pubspec.yaml b/packages/stream_chat_flutter_core/pubspec.yaml index bbb58a13..b289193f 100644 --- a/packages/stream_chat_flutter_core/pubspec.yaml +++ b/packages/stream_chat_flutter_core/pubspec.yaml @@ -1,7 +1,7 @@ name: stream_chat_flutter_core homepage: https://github.com/GetStream/stream-chat-flutter description: Stream Chat official Flutter SDK Core. Build your own chat experience using Dart and Flutter. -version: 1.3.1-beta +version: 1.3.2-beta repository: https://github.com/GetStream/stream-chat-flutter issue_tracker: https://github.com/GetStream/stream-chat-flutter/issues @@ -10,7 +10,7 @@ environment: flutter: ">=1.17.0" dependencies: - stream_chat: ^1.3.1-beta + stream_chat: ^1.3.2-beta flutter: sdk: flutter rxdart: ^0.25.0 From 3d43c84fbbb6fb1481c5c5c413df243d1ce2f6e6 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 13:15:39 +0100 Subject: [PATCH 03/16] fix update channel debounce --- packages/stream_chat/CHANGELOG.md | 2 +- packages/stream_chat/lib/src/api/channel.dart | 13 ++++++++----- packages/stream_chat/pubspec.yaml | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/stream_chat/CHANGELOG.md b/packages/stream_chat/CHANGELOG.md index c688d4f6..02825f58 100644 --- a/packages/stream_chat/CHANGELOG.md +++ b/packages/stream_chat/CHANGELOG.md @@ -1,4 +1,4 @@ -## 1.3.2-beta +## 1.3.2+1-beta - Fixed queryChannels bug diff --git a/packages/stream_chat/lib/src/api/channel.dart b/packages/stream_chat/lib/src/api/channel.dart index 97ce9a96..8814bfb0 100644 --- a/packages/stream_chat/lib/src/api/channel.dart +++ b/packages/stream_chat/lib/src/api/channel.dart @@ -1692,11 +1692,14 @@ class ChannelClientState { set _channelState(ChannelState v) { _channelStateController.add(v); - debounce( - timeout: Duration(milliseconds: 500), - target: _channel._client.chatPersistenceClient?.updateChannelState, - positionalArguments: [v], - ); + + if (_channel._client.persistenceEnabled) { + debounce( + timeout: Duration(milliseconds: 500), + target: _channel._client.chatPersistenceClient?.updateChannelState, + positionalArguments: [v], + ); + } } /// The channel threads related to this channel diff --git a/packages/stream_chat/pubspec.yaml b/packages/stream_chat/pubspec.yaml index 197c3f54..927a997e 100644 --- a/packages/stream_chat/pubspec.yaml +++ b/packages/stream_chat/pubspec.yaml @@ -1,7 +1,7 @@ name: stream_chat homepage: https://getstream.io/ description: The official Dart client for Stream Chat, a service for building chat applications. -version: 1.3.2-beta +version: 1.3.2+1-beta repository: https://github.com/GetStream/stream-chat-flutter issue_tracker: https://github.com/GetStream/stream-chat-flutter/issues From b442bc55d3de201c45acb638dd062dbd3f4b93f6 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 14:42:39 +0100 Subject: [PATCH 04/16] add pana check gh action --- .github/workflows/pana.yml | 102 ++++++++++++++++++ .github/workflows/stream_flutter_workflow.yml | 8 +- 2 files changed, 106 insertions(+), 4 deletions(-) create mode 100644 .github/workflows/pana.yml diff --git a/.github/workflows/pana.yml b/.github/workflows/pana.yml new file mode 100644 index 00000000..95e628aa --- /dev/null +++ b/.github/workflows/pana.yml @@ -0,0 +1,102 @@ +name: pana + +env: + ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true' + +on: + # pull_request: + # branches: + # - master + # paths-ignore: + # - 'docs/**' + push: + # branches: + # - master + # paths-ignore: + # - 'docs/**' + +jobs: + stream_chat: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: axel-op/dart-package-analyzer@v3 + id: analysis + with: + githubToken: ${{ secrets.GITHUB_TOKEN }} + relativePath: packages/stream_chat + - name: Check scores + env: + # NB: "analysis" is the id set above. Replace it with the one you used if different. + TOTAL: ${{ steps.analysis.outputs.total }} + TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} + run: | + PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) + if (( $PERCENTAGE < 90 )) + then + echo Score too low! + exit 1 + fi + stream_chat_persistence: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: axel-op/dart-package-analyzer@v3 + id: analysis + with: + githubToken: ${{ secrets.GITHUB_TOKEN }} + relativePath: packages/stream_chat_persistence + - name: Check scores + env: + # NB: "analysis" is the id set above. Replace it with the one you used if different. + TOTAL: ${{ steps.analysis.outputs.total }} + TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} + run: | + PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) + if (( $PERCENTAGE < 90 )) + then + echo Score too low! + exit 1 + fi + stream_chat_flutter_core: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: axel-op/dart-package-analyzer@v3 + id: analysis + with: + githubToken: ${{ secrets.GITHUB_TOKEN }} + relativePath: packages/stream_chat_flutter_core + - name: Check scores + env: + # NB: "analysis" is the id set above. Replace it with the one you used if different. + TOTAL: ${{ steps.analysis.outputs.total }} + TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} + run: | + PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) + if (( $PERCENTAGE < 90 )) + then + echo Score too low! + exit 1 + fi + stream_chat_flutter: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: axel-op/dart-package-analyzer@v3 + id: analysis + with: + githubToken: ${{ secrets.GITHUB_TOKEN }} + relativePath: packages/stream_chat_flutter + - name: Check scores + env: + # NB: "analysis" is the id set above. Replace it with the one you used if different. + TOTAL: ${{ steps.analysis.outputs.total }} + TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} + run: | + PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) + if (( $PERCENTAGE < 90 )) + then + echo Score too low! + exit 1 + fi \ No newline at end of file diff --git a/.github/workflows/stream_flutter_workflow.yml b/.github/workflows/stream_flutter_workflow.yml index 9e898eda..ce6d2c63 100644 --- a/.github/workflows/stream_flutter_workflow.yml +++ b/.github/workflows/stream_flutter_workflow.yml @@ -17,7 +17,7 @@ jobs: timeout-minutes: 15 runs-on: ubuntu-latest steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 0 - name: 'Install Flutter' @@ -40,7 +40,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 15 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 0 - name: 'Install Flutter' @@ -73,7 +73,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 5 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 0 - name: 'Install Flutter' @@ -89,7 +89,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 15 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 with: fetch-depth: 0 - name: 'Install Flutter' From c48f4861f9f076463ad2b1944b605cdc2169551d Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 15:19:02 +0100 Subject: [PATCH 05/16] update --- .github/workflows/pana.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pana.yml b/.github/workflows/pana.yml index 95e628aa..f162f292 100644 --- a/.github/workflows/pana.yml +++ b/.github/workflows/pana.yml @@ -4,12 +4,12 @@ env: ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true' on: - # pull_request: + pull_request: # branches: # - master # paths-ignore: # - 'docs/**' - push: + # push: # branches: # - master # paths-ignore: From 784ee16d10942d691902a40fa102008fb39b279c Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 15:26:59 +0100 Subject: [PATCH 06/16] update --- .github/workflows/pana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pana.yml b/.github/workflows/pana.yml index f162f292..053abbb9 100644 --- a/.github/workflows/pana.yml +++ b/.github/workflows/pana.yml @@ -34,7 +34,7 @@ jobs: PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) if (( $PERCENTAGE < 90 )) then - echo Score too low! + echo Score $PERCENTAGE is too low! exit 1 fi stream_chat_persistence: From 0dc6ba50d9c0ba71dad6355e45b6e3158a123da0 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 15:31:12 +0100 Subject: [PATCH 07/16] fix --- packages/stream_chat/lib/version.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/stream_chat/lib/version.dart b/packages/stream_chat/lib/version.dart index 2c9c2639..27294084 100644 --- a/packages/stream_chat/lib/version.dart +++ b/packages/stream_chat/lib/version.dart @@ -2,4 +2,4 @@ import 'package:stream_chat/src/client.dart'; /// Current package version /// Used in [StreamChatClient] to build the `x-stream-client` header -const PACKAGE_VERSION = '1.3.2-beta'; +const PACKAGE_VERSION = '1.3.2+1-beta'; From 9c672847082bad251fbf2191c9fba9936eace11e Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 15:31:28 +0100 Subject: [PATCH 08/16] update --- .github/workflows/pana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pana.yml b/.github/workflows/pana.yml index 053abbb9..f162f292 100644 --- a/.github/workflows/pana.yml +++ b/.github/workflows/pana.yml @@ -34,7 +34,7 @@ jobs: PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) if (( $PERCENTAGE < 90 )) then - echo Score $PERCENTAGE is too low! + echo Score too low! exit 1 fi stream_chat_persistence: From 12c7368d0ccb3531a9eebb6e06870def73aa3343 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 15:42:14 +0100 Subject: [PATCH 09/16] use textbutton --- .../lib/src/attachment/giphy_attachment.dart | 64 ++++++++++--------- .../lib/src/channel_list_view.dart | 4 +- .../lib/src/message_actions_modal.dart | 4 +- .../lib/src/message_input.dart | 2 +- .../lib/src/user_list_view.dart | 2 +- .../stream_chat_flutter/lib/src/utils.dart | 6 +- 6 files changed, 43 insertions(+), 39 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/attachment/giphy_attachment.dart b/packages/stream_chat_flutter/lib/src/attachment/giphy_attachment.dart index ed5a5750..8247661c 100644 --- a/packages/stream_chat_flutter/lib/src/attachment/giphy_attachment.dart +++ b/packages/stream_chat_flutter/lib/src/attachment/giphy_attachment.dart @@ -202,24 +202,26 @@ class GiphyAttachment extends AttachmentWidget { crossAxisAlignment: CrossAxisAlignment.center, children: [ Expanded( - child: FlatButton( + child: Container( height: 50, - onPressed: () { - streamChannel.channel.sendAction(message, { - 'image_action': 'cancel', - }); - }, - child: Text( - 'Cancel', - style: StreamChatTheme.of(context) - .textTheme - .bodyBold - .copyWith( - color: StreamChatTheme.of(context) - .colorTheme - .black - .withOpacity(0.5), - ), + child: TextButton( + onPressed: () { + streamChannel.channel.sendAction(message, { + 'image_action': 'cancel', + }); + }, + child: Text( + 'Cancel', + style: StreamChatTheme.of(context) + .textTheme + .bodyBold + .copyWith( + color: StreamChatTheme.of(context) + .colorTheme + .black + .withOpacity(0.5), + ), + ), ), ), ), @@ -232,20 +234,22 @@ class GiphyAttachment extends AttachmentWidget { height: 50.0, ), Expanded( - child: FlatButton( + child: Container( height: 50, - onPressed: () { - streamChannel.channel.sendAction(message, { - 'image_action': 'send', - }); - }, - child: Text( - 'Send', - style: TextStyle( - color: StreamChatTheme.of(context) - .colorTheme - .accentBlue, - fontWeight: FontWeight.bold), + child: TextButton( + onPressed: () { + streamChannel.channel.sendAction(message, { + 'image_action': 'send', + }); + }, + child: Text( + 'Send', + style: TextStyle( + color: StreamChatTheme.of(context) + .colorTheme + .accentBlue, + fontWeight: FontWeight.bold), + ), ), ), ), diff --git a/packages/stream_chat_flutter/lib/src/channel_list_view.dart b/packages/stream_chat_flutter/lib/src/channel_list_view.dart index 3bab76b2..1fb9885a 100644 --- a/packages/stream_chat_flutter/lib/src/channel_list_view.dart +++ b/packages/stream_chat_flutter/lib/src/channel_list_view.dart @@ -284,7 +284,7 @@ class _ChannelListViewState extends State { left: 0, bottom: 32, child: Center( - child: FlatButton( + child: TextButton( onPressed: widget.onStartChatPressed, child: Text( 'Start a chat', @@ -445,7 +445,7 @@ class _ChannelListViewState extends State { ), style: Theme.of(context).textTheme.headline6, ), - FlatButton( + TextButton( onPressed: () => _channelListController.loadData(), child: Text('Retry'), ), diff --git a/packages/stream_chat_flutter/lib/src/message_actions_modal.dart b/packages/stream_chat_flutter/lib/src/message_actions_modal.dart index d914afba..1546e66b 100644 --- a/packages/stream_chat_flutter/lib/src/message_actions_modal.dart +++ b/packages/stream_chat_flutter/lib/src/message_actions_modal.dart @@ -348,7 +348,7 @@ class _MessageActionsModalState extends State { Row( mainAxisAlignment: MainAxisAlignment.center, children: [ - FlatButton( + TextButton( child: Text( 'OK', style: StreamChatTheme.of(context) @@ -413,7 +413,7 @@ class _MessageActionsModalState extends State { Row( mainAxisAlignment: MainAxisAlignment.center, children: [ - FlatButton( + TextButton( child: Text( 'OK', style: StreamChatTheme.of(context) diff --git a/packages/stream_chat_flutter/lib/src/message_input.dart b/packages/stream_chat_flutter/lib/src/message_input.dart index ec6b9574..21424c2e 100644 --- a/packages/stream_chat_flutter/lib/src/message_input.dart +++ b/packages/stream_chat_flutter/lib/src/message_input.dart @@ -2139,7 +2139,7 @@ class MessageInputState extends State { Row( mainAxisAlignment: MainAxisAlignment.center, children: [ - FlatButton( + TextButton( child: Text( 'OK', style: StreamChatTheme.of(context) diff --git a/packages/stream_chat_flutter/lib/src/user_list_view.dart b/packages/stream_chat_flutter/lib/src/user_list_view.dart index 4b50559b..77537e59 100644 --- a/packages/stream_chat_flutter/lib/src/user_list_view.dart +++ b/packages/stream_chat_flutter/lib/src/user_list_view.dart @@ -242,7 +242,7 @@ class _UserListViewState extends State ), child: Text(message), ), - FlatButton( + TextButton( onPressed: () { _userListController.loadData(); }, diff --git a/packages/stream_chat_flutter/lib/src/utils.dart b/packages/stream_chat_flutter/lib/src/utils.dart index 424f1880..7a88ee6c 100644 --- a/packages/stream_chat_flutter/lib/src/utils.dart +++ b/packages/stream_chat_flutter/lib/src/utils.dart @@ -59,7 +59,7 @@ Future showConfirmationDialog( Row( mainAxisAlignment: MainAxisAlignment.spaceBetween, children: [ - FlatButton( + TextButton( child: Text( cancelText, style: StreamChatTheme.of(context) @@ -75,7 +75,7 @@ Future showConfirmationDialog( Navigator.of(context).pop(false); }, ), - FlatButton( + TextButton( child: Text( okText, style: StreamChatTheme.of(context) @@ -145,7 +145,7 @@ Future showInfoDialog( Row( mainAxisAlignment: MainAxisAlignment.spaceBetween, children: [ - FlatButton( + TextButton( child: Text( okText, style: TextStyle( From 411bfbb61059038cf92c01ee159bfd978695f994 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 15:52:38 +0100 Subject: [PATCH 10/16] use elevated button --- .../stream_chat_flutter/lib/src/message_search_list_view.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/stream_chat_flutter/lib/src/message_search_list_view.dart b/packages/stream_chat_flutter/lib/src/message_search_list_view.dart index da1144b8..165ed47b 100644 --- a/packages/stream_chat_flutter/lib/src/message_search_list_view.dart +++ b/packages/stream_chat_flutter/lib/src/message_search_list_view.dart @@ -195,7 +195,7 @@ class _MessageSearchListViewState extends State { padding: const EdgeInsets.only(top: 16.0), child: Text(message), ), - RaisedButton( + ElevatedButton( onPressed: () { _messageSearchListController.loadData(); }, From 5391919e3304426d0c0c0473c02edd080e3c6c75 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 16:09:49 +0100 Subject: [PATCH 11/16] fix --- .../stream_chat_persistence/lib/src/dao/channel_query_dao.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart b/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart index 7d4af560..c65a4d82 100644 --- a/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart +++ b/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart @@ -94,7 +94,7 @@ class ChannelQueryDao extends DatabaseAccessor ?.where((s) => possibleSortingFields.contains(s.field)) ?.toList(growable: false); - Comparator chainedComparator = (a, b) { + var chainedComparator = (a, b) { final dateA = a.lastMessageAt ?? a.createdAt; final dateB = b.lastMessageAt ?? b.createdAt; return dateB.compareTo(dateA); From e40240c8559af08503767c202093d3dedcb4c544 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 16:21:47 +0100 Subject: [PATCH 12/16] add flutter dependency in stream_chat_persistence --- packages/stream_chat_persistence/pubspec.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/stream_chat_persistence/pubspec.yaml b/packages/stream_chat_persistence/pubspec.yaml index bd32d8f3..6923e927 100644 --- a/packages/stream_chat_persistence/pubspec.yaml +++ b/packages/stream_chat_persistence/pubspec.yaml @@ -9,6 +9,8 @@ environment: sdk: ">=2.7.0 <3.0.0" dependencies: + flutter: + sdk: flutter moor: ^3.4.0 path: ^1.7.0 path_provider: ^1.6.27 From e7334dcf9bc49a97673cb400450e57b16d91a095 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 16:28:09 +0100 Subject: [PATCH 13/16] fix --- .../stream_chat_persistence/lib/src/dao/channel_query_dao.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart b/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart index c65a4d82..3f27cfd5 100644 --- a/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart +++ b/packages/stream_chat_persistence/lib/src/dao/channel_query_dao.dart @@ -94,7 +94,7 @@ class ChannelQueryDao extends DatabaseAccessor ?.where((s) => possibleSortingFields.contains(s.field)) ?.toList(growable: false); - var chainedComparator = (a, b) { + var chainedComparator = (ChannelModel a, ChannelModel b) { final dateA = a.lastMessageAt ?? a.createdAt; final dateB = b.lastMessageAt ?? b.createdAt; return dateB.compareTo(dateA); From 3889c07cc1c250c6969b55e21428031757004841 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 16:42:07 +0100 Subject: [PATCH 14/16] update min score --- .github/workflows/pana.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pana.yml b/.github/workflows/pana.yml index f162f292..5799952d 100644 --- a/.github/workflows/pana.yml +++ b/.github/workflows/pana.yml @@ -32,7 +32,7 @@ jobs: TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} run: | PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) - if (( $PERCENTAGE < 90 )) + if (( $PERCENTAGE < 110 )) then echo Score too low! exit 1 @@ -74,7 +74,7 @@ jobs: TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} run: | PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) - if (( $PERCENTAGE < 90 )) + if (( $PERCENTAGE < 110 )) then echo Score too low! exit 1 From 0084323fcab2388bc3f43ca875de43c14a76851a Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 16:46:38 +0100 Subject: [PATCH 15/16] update min score --- .github/workflows/pana.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pana.yml b/.github/workflows/pana.yml index 5799952d..fb166bc1 100644 --- a/.github/workflows/pana.yml +++ b/.github/workflows/pana.yml @@ -32,7 +32,7 @@ jobs: TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} run: | PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) - if (( $PERCENTAGE < 110 )) + if (( $PERCENTAGE < 100 )) then echo Score too low! exit 1 @@ -74,7 +74,7 @@ jobs: TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} run: | PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) - if (( $PERCENTAGE < 110 )) + if (( $PERCENTAGE < 100 )) then echo Score too low! exit 1 From 807d978ac96838c2c2f475aa811c9a78db00bac0 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 1 Mar 2021 16:52:06 +0100 Subject: [PATCH 16/16] update gh --- .github/workflows/pana.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pana.yml b/.github/workflows/pana.yml index fb166bc1..e698349c 100644 --- a/.github/workflows/pana.yml +++ b/.github/workflows/pana.yml @@ -5,15 +5,15 @@ env: on: pull_request: - # branches: - # - master - # paths-ignore: - # - 'docs/**' - # push: - # branches: - # - master - # paths-ignore: - # - 'docs/**' + branches: + - master + paths-ignore: + - 'docs/**' + push: + branches: + - master + paths-ignore: + - 'docs/**' jobs: stream_chat: