fix: on reply callback not used

This commit is contained in:
Gordon Hayes
2022-11-25 17:58:03 +01:00
parent ddd8310b96
commit 16615705b1
3 changed files with 8 additions and 3 deletions
@@ -2,6 +2,8 @@
🐞 Fixed 🐞 Fixed
- Fix render overflow issue with `MessageSearchListTileTitle`. It now uses `Text.rich` instead of `Row`. Better default behaviour and allows `TextOverflow`. - Fix render overflow issue with `MessageSearchListTileTitle`. It now uses `Text.rich` instead of `Row`. Better default behaviour and allows `TextOverflow`.
- Fix [[#1347]](https://github.com/GetStream/stream-chat-flutter/issues/1347) `onReply` not working in `AttachmentActionsModal` which is used by `StreamImageAttachment` and `StreamImageGroup`.
## 5.1.0 ## 5.1.0
🐞 Fixed 🐞 Fixed
@@ -300,6 +300,7 @@ class _ChannelPageState extends State<ChannelPage> {
@override @override
void dispose() { void dispose() {
focusNode.dispose(); focusNode.dispose();
messageInputController.dispose();
super.dispose(); super.dispose();
} }
} }
@@ -33,10 +33,10 @@ class AttachmentActionsModal extends StatelessWidget {
/// Callback to download [attachment]. /// Callback to download [attachment].
final AttachmentDownloader? attachmentDownloader; final AttachmentDownloader? attachmentDownloader;
/// Show reply option /// Show "reply" option
final bool showReply; final bool showReply;
/// Show show in chat option /// Show "show in chat" option
final bool showShowInChat; final bool showShowInChat;
/// Show save option /// Show save option
@@ -55,6 +55,7 @@ class AttachmentActionsModal extends StatelessWidget {
Attachment? attachment, Attachment? attachment,
Message? message, Message? message,
VoidCallback? onShowMessage, VoidCallback? onShowMessage,
VoidCallback? onReply,
AttachmentDownloader? attachmentDownloader, AttachmentDownloader? attachmentDownloader,
bool? showReply, bool? showReply,
bool? showShowInChat, bool? showShowInChat,
@@ -67,6 +68,7 @@ class AttachmentActionsModal extends StatelessWidget {
attachment: attachment ?? this.attachment, attachment: attachment ?? this.attachment,
message: message ?? this.message, message: message ?? this.message,
onShowMessage: onShowMessage ?? this.onShowMessage, onShowMessage: onShowMessage ?? this.onShowMessage,
onReply: onReply ?? this.onReply,
attachmentDownloader: attachmentDownloader ?? this.attachmentDownloader, attachmentDownloader: attachmentDownloader ?? this.attachmentDownloader,
showReply: showReply ?? this.showReply, showReply: showReply ?? this.showReply,
showShowInChat: showShowInChat ?? this.showShowInChat, showShowInChat: showShowInChat ?? this.showShowInChat,
@@ -112,7 +114,7 @@ class AttachmentActionsModal extends StatelessWidget {
size: 24, size: 24,
color: theme.colorTheme.textLowEmphasis, color: theme.colorTheme.textLowEmphasis,
), ),
() => Navigator.of(context).pop(ReturnActionType.reply), onReply,
), ),
if (showShowInChat) if (showShowInChat)
_buildButton( _buildButton(