From 0d12e701a0725946623af572c4196a9f5c299127 Mon Sep 17 00:00:00 2001 From: Salvatore Giordano Date: Mon, 26 Apr 2021 16:58:28 +0200 Subject: [PATCH] fix tests --- packages/stream_chat/analysis_options.yaml | 1 - packages/stream_chat/test/src/api/channel_test.dart | 10 ++++++++-- .../test/src/models/channel_state_test.dart | 6 +++--- .../stream_chat/test/src/models/channel_test.dart | 4 ++-- packages/stream_chat/test/version_test.dart | 12 ++++++------ .../test/src/dao/channel_query_dao_test.dart | 7 ++++++- 6 files changed, 25 insertions(+), 15 deletions(-) diff --git a/packages/stream_chat/analysis_options.yaml b/packages/stream_chat/analysis_options.yaml index ddc691d0..c0e14133 100644 --- a/packages/stream_chat/analysis_options.yaml +++ b/packages/stream_chat/analysis_options.yaml @@ -3,7 +3,6 @@ analyzer: - lib/**/*.g.dart - lib/**/*.freezed.dart - example/* - - test/* linter: rules: - always_use_package_imports diff --git a/packages/stream_chat/test/src/api/channel_test.dart b/packages/stream_chat/test/src/api/channel_test.dart index 49a12cb4..c3409b7e 100644 --- a/packages/stream_chat/test/src/api/channel_test.dart +++ b/packages/stream_chat/test/src/api/channel_test.dart @@ -223,7 +223,10 @@ void main() { final mockDio = MockDio(); final mockUploader = MockAttachmentUploader(); - const file = AttachmentFile(path: 'filePath/fileName.pdf'); + const file = AttachmentFile( + path: 'filePath/fileName.pdf', + size: 100, + ); const channelId = 'testId'; const channelType = 'messaging'; @@ -262,7 +265,10 @@ void main() { final mockDio = MockDio(); final mockUploader = MockAttachmentUploader(); - const image = AttachmentFile(path: 'imagePath/imageName.jpeg'); + const image = AttachmentFile( + path: 'imagePath/imageName.jpeg', + size: 100, + ); const channelId = 'testId'; const channelType = 'messaging'; diff --git a/packages/stream_chat/test/src/models/channel_state_test.dart b/packages/stream_chat/test/src/models/channel_state_test.dart index afe384f5..a93166b4 100644 --- a/packages/stream_chat/test/src/models/channel_state_test.dart +++ b/packages/stream_chat/test/src/models/channel_state_test.dart @@ -861,10 +861,10 @@ void main() { DateTime.parse('2019-04-03T18:43:33.213374Z')); expect(channelState.channel?.createdBy, isA()); expect(channelState.channel?.frozen, true); - expect(channelState.channel?.extraData!['example'], 1); - expect(channelState.channel?.extraData!['name'], '#dev'); + expect(channelState.channel?.extraData['example'], 1); + expect(channelState.channel?.extraData['name'], '#dev'); expect( - channelState.channel?.extraData!['image'], + channelState.channel?.extraData['image'], 'https://cdn.chrisshort.net/testing-certificate-chains-in-go/GOPHER_MIC_DROP.png', ); expect(channelState.messages, hasLength(25)); diff --git a/packages/stream_chat/test/src/models/channel_test.dart b/packages/stream_chat/test/src/models/channel_test.dart index 01c06fee..1e69565c 100644 --- a/packages/stream_chat/test/src/models/channel_test.dart +++ b/packages/stream_chat/test/src/models/channel_test.dart @@ -20,8 +20,8 @@ void main() { expect(channel.id, equals('test')); expect(channel.type, equals('livestream')); expect(channel.cid, equals('livestream:test')); - expect(channel.extraData!['cats'], equals(true)); - expect(channel.extraData!['fruit'], equals(['bananas', 'apples'])); + expect(channel.extraData['cats'], equals(true)); + expect(channel.extraData['fruit'], equals(['bananas', 'apples'])); }); test('should serialize to json correctly', () { diff --git a/packages/stream_chat/test/version_test.dart b/packages/stream_chat/test/version_test.dart index 9bbd446f..34ecc750 100644 --- a/packages/stream_chat/test/version_test.dart +++ b/packages/stream_chat/test/version_test.dart @@ -1,8 +1,7 @@ import 'dart:io'; -import 'package:rxdart/rxdart.dart'; -import 'package:test/test.dart'; import 'package:stream_chat/version.dart'; +import 'package:test/test.dart'; void prepareTest() { // https://github.com/flutter/flutter/issues/20907 @@ -14,10 +13,11 @@ void prepareTest() { void main() { prepareTest(); test('stream chat version matches pubspec', () { - final String pubspecPath = '${Directory.current.path}/pubspec.yaml'; - final String pubspec = File(pubspecPath).readAsStringSync(); - final RegExp regex = RegExp('version:\s*(.*)'); - final RegExpMatch? match = regex.firstMatch(pubspec); + final pubspecPath = '${Directory.current.path}/pubspec.yaml'; + final pubspec = File(pubspecPath).readAsStringSync(); + // ignore: unnecessary_string_escapes + final regex = RegExp('version:\s*(.*)'); + final match = regex.firstMatch(pubspec); expect(match, isNotNull); expect(PACKAGE_VERSION, match?.group(1)?.trim()); }); diff --git a/packages/stream_chat_persistence/test/src/dao/channel_query_dao_test.dart b/packages/stream_chat_persistence/test/src/dao/channel_query_dao_test.dart index 50ff7a7c..9b5e3470 100644 --- a/packages/stream_chat_persistence/test/src/dao/channel_query_dao_test.dart +++ b/packages/stream_chat_persistence/test/src/dao/channel_query_dao_test.dart @@ -168,7 +168,12 @@ void main() { // Should match with the inserted channels final updatedChannels = await channelQueryDao.getChannels( filter: filter, - sort: [SortOption('member_count', comparator: sortComparator)], + sort: [ + SortOption( + 'member_count', + comparator: sortComparator, + ) + ], ); expect(updatedChannels.length, insertedChannels.length);