From 9a4677a7b852c34344722455a64a20d5af462241 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Stolin=CC=81ski?= Date: Tue, 8 Feb 2022 15:47:42 +0100 Subject: [PATCH 01/12] decrease parent message reply count only once --- .../stream_chat/lib/src/client/channel.dart | 31 ++++++++++++------- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/packages/stream_chat/lib/src/client/channel.dart b/packages/stream_chat/lib/src/client/channel.dart index d3900842..84f0321e 100644 --- a/packages/stream_chat/lib/src/client/channel.dart +++ b/packages/stream_chat/lib/src/client/channel.dart @@ -1083,7 +1083,7 @@ class Channel { } else { // remove the passed message if response does // not contain message - state!.removeMessage(message); + state!.removeMessage(message, decreaseReplyCount: true); await _client.chatPersistenceClient?.deleteMessageById(messageId); } return res; @@ -1752,6 +1752,7 @@ class ChannelClientState { _subscriptions.add(_channel.on(EventType.messageDeleted).listen((event) { final message = event.message!; if (event.hardDelete == true) { + //do not decrease reply count here - it is done in _listenMessageUpdated removeMessage(message, hardDelete: true); } else { addMessage(message); @@ -1810,24 +1811,30 @@ class ChannelClientState { } /// Remove a [message] from this [channelState]. - void removeMessage(Message message, {bool hardDelete = false}) { + void removeMessage( + Message message, { + bool hardDelete = false, + bool decreaseReplyCount = false, + }) { final parentId = message.parentId; // i.e. it's a thread message // 1. Remove the thread message // 2. Reduce total reply count of parent message if (parentId != null) { - final allMessages = [...messages]; - final parentMessage = allMessages.firstWhereOrNull( - (it) => it.id == parentId, - ); + if (decreaseReplyCount) { + final allMessages = [...messages]; + final parentMessage = allMessages.firstWhereOrNull( + (it) => it.id == parentId, + ); - // return if message not available in the memory - if (parentMessage == null) return; - final replyCount = parentMessage.replyCount; - // return if reply count is null or zero - if (replyCount == null || replyCount == 0) return; + // return if message not available in the memory + if (parentMessage == null) return; + final replyCount = parentMessage.replyCount; + // return if reply count is null or zero + if (replyCount == null || replyCount == 0) return; - addMessage(parentMessage.copyWith(replyCount: replyCount - 1)); + addMessage(parentMessage.copyWith(replyCount: replyCount - 1)); + } updateThreadInfo( parentId, threads[parentId]! From 8f6bfd7b472acfbe007c4501b87c3b3584680fb7 Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Thu, 17 Feb 2022 17:17:52 +0530 Subject: [PATCH 02/12] fix(llc): improve removeMessage logic. --- .../stream_chat/lib/src/client/channel.dart | 116 ++++++++---------- .../lib/src/client/retry_queue.dart | 2 +- 2 files changed, 51 insertions(+), 67 deletions(-) diff --git a/packages/stream_chat/lib/src/client/channel.dart b/packages/stream_chat/lib/src/client/channel.dart index 84f0321e..b5bad6cb 100644 --- a/packages/stream_chat/lib/src/client/channel.dart +++ b/packages/stream_chat/lib/src/client/channel.dart @@ -407,7 +407,7 @@ class Channel { if (index != -1) { final newAttachments = [...message!.attachments]..[index] = attachment; final updatedMessage = message!.copyWith(attachments: newAttachments); - state?.addMessage(updatedMessage); + state?.updateMessage(updatedMessage); // updating original message for next iteration message = message!.merge(updatedMessage); } @@ -512,7 +512,7 @@ class Channel { ).toList(), ); - state!.addMessage(message); + state!.updateMessage(message); try { if (message.attachments.any((it) => !it.uploadState.isSuccess)) { @@ -535,7 +535,7 @@ class Channel { type, skipPush: skipPush, ); - state!.addMessage(response.message); + state!.updateMessage(response.message); if (cooldown > 0) cooldownStartedAt = DateTime.now(); return response; } catch (e) { @@ -571,7 +571,7 @@ class Channel { ).toList(), ); - state?.addMessage(message); + state?.updateMessage(message); try { if (message.attachments.any((it) => !it.uploadState.isSuccess)) { @@ -594,7 +594,7 @@ class Channel { ownReactions: message.ownReactions, ); - state?.addMessage(m); + state?.updateMessage(m); return response; } catch (e) { @@ -602,7 +602,7 @@ class Channel { if (e.isRetriable) { state!._retryQueue.add([message]); } else { - state?.addMessage(originalMessage); + state?.updateMessage(originalMessage); } } rethrow; @@ -630,7 +630,7 @@ class Channel { ownReactions: message.ownReactions, ); - state?.addMessage(updatedMessage); + state?.updateMessage(updatedMessage); return response; } catch (e) { @@ -646,7 +646,7 @@ class Channel { // Directly deleting the local messages which are not yet sent to server if (message.status == MessageSendingStatus.sending || message.status == MessageSendingStatus.failed) { - state!.addMessage(message.copyWith( + state!.updateMessage(message.copyWith( type: 'deleted', status: MessageSendingStatus.sent, )); @@ -667,11 +667,11 @@ class Channel { deletedAt: message.deletedAt ?? DateTime.now(), ); - state?.addMessage(message); + state?.updateMessage(message); final response = await _client.deleteMessage(message.id, hard: hard); - state?.addMessage(message.copyWith(status: MessageSendingStatus.sent)); + state?.updateMessage(message.copyWith(status: MessageSendingStatus.sent)); return response; } catch (e) { @@ -860,7 +860,7 @@ class Channel { ownReactions: ownReactions, ); - state?.addMessage(newMessage); + state?.updateMessage(newMessage); try { final reactionResp = await _client.sendReaction( @@ -872,7 +872,7 @@ class Channel { return reactionResp; } catch (_) { // Reset the message if the update fails - state?.addMessage(message); + state?.updateMessage(message); rethrow; } } @@ -912,7 +912,7 @@ class Channel { ownReactions: ownReactions, ); - state?.addMessage(newMessage); + state?.updateMessage(newMessage); try { final deleteResponse = await _client.deleteReaction( @@ -922,7 +922,7 @@ class Channel { return deleteResponse; } catch (_) { // Reset the message if the update fails - state?.addMessage(message); + state?.updateMessage(message); rethrow; } } @@ -1079,11 +1079,11 @@ class Channel { // update the passed message with response message if (res.message != null) { - state!.addMessage(res.message!); + state!.updateMessage(res.message!); } else { // remove the passed message if response does // not contain message - state!.removeMessage(message, decreaseReplyCount: true); + state!.removeMessage(message); await _client.chatPersistenceClient?.deleteMessageById(messageId); } return res; @@ -1322,7 +1322,8 @@ class Channel { /// Remove the ban for the user with given [userID] in the channel. @Deprecated( - "Use 'unbanMember' instead. This method will be removed in v4.0.0") + "Use 'unbanMember' instead. This method will be removed in v4.0.0", + ) Future unbanUser(String userID) => unbanMember(userID); /// Remove the ban for the member with given [userID] in the channel. @@ -1694,7 +1695,9 @@ class ChannelClientState { void _listenReactionDeleted() { _subscriptions.add(_channel.on(EventType.reactionDeleted).listen((event) { final oldMessage = - messages.firstWhereOrNull((it) => it.id == event.message?.id); + messages.firstWhereOrNull((it) => it.id == event.message?.id) ?? + threads[event.message?.parentId] + ?.firstWhereOrNull((e) => e.id == event.message?.id); final reaction = event.reaction; final ownReactions = oldMessage?.ownReactions ?.whereNot((it) => @@ -1707,18 +1710,20 @@ class ChannelClientState { final message = event.message!.copyWith( ownReactions: ownReactions, ); - addMessage(message); + updateMessage(message); })); } void _listenReactions() { _subscriptions.add(_channel.on(EventType.reactionNew).listen((event) { final oldMessage = - messages.firstWhereOrNull((it) => it.id == event.message?.id); + messages.firstWhereOrNull((it) => it.id == event.message?.id) ?? + threads[event.message?.parentId] + ?.firstWhereOrNull((e) => e.id == event.message?.id); final message = event.message!.copyWith( ownReactions: oldMessage?.ownReactions, ); - addMessage(message); + updateMessage(message); })); } @@ -1730,12 +1735,13 @@ class ChannelClientState { ) .listen((event) { final oldMessage = - messages.firstWhereOrNull((it) => it.id == event.message?.id); - + messages.firstWhereOrNull((it) => it.id == event.message?.id) ?? + threads[event.message?.parentId] + ?.firstWhereOrNull((e) => e.id == event.message?.id); final message = event.message!.copyWith( ownReactions: oldMessage?.ownReactions, ); - addMessage(message); + updateMessage(message); if (message.pinned) { _channelState = _channelState.copyWith( @@ -1752,10 +1758,9 @@ class ChannelClientState { _subscriptions.add(_channel.on(EventType.messageDeleted).listen((event) { final message = event.message!; if (event.hardDelete == true) { - //do not decrease reply count here - it is done in _listenMessageUpdated - removeMessage(message, hardDelete: true); + removeMessage(message); } else { - addMessage(message); + updateMessage(message); } })); } @@ -1770,7 +1775,7 @@ class ChannelClientState { final message = event.message!; if (isUpToDate || (message.parentId != null && message.showInChannel != true)) { - addMessage(message); + updateMessage(message); } if (_countMessageAsUnread(message)) { @@ -1780,9 +1785,13 @@ class ChannelClientState { } /// Add a [message] to this [channelState]. - void addMessage(Message message) { + @Deprecated('Use updateMessage instead') + void addMessage(Message message) => updateMessage(message); + + /// Updates the [message] in the state if it exists. Adds it otherwise. + void updateMessage(Message message) { if (message.parentId == null || message.showInChannel == true) { - final newMessages = List.from(_channelState.messages); + final newMessages = [...messages]; final oldIndex = newMessages.indexWhere((m) => m.id == message.id); if (oldIndex != -1) { Message? m; @@ -1811,47 +1820,22 @@ class ChannelClientState { } /// Remove a [message] from this [channelState]. - void removeMessage( - Message message, { - bool hardDelete = false, - bool decreaseReplyCount = false, - }) { + void removeMessage(Message message) { final parentId = message.parentId; - // i.e. it's a thread message - // 1. Remove the thread message - // 2. Reduce total reply count of parent message + // i.e. it's a thread message, Remove it if (parentId != null) { - if (decreaseReplyCount) { - final allMessages = [...messages]; - final parentMessage = allMessages.firstWhereOrNull( - (it) => it.id == parentId, - ); - - // return if message not available in the memory - if (parentMessage == null) return; - final replyCount = parentMessage.replyCount; - // return if reply count is null or zero - if (replyCount == null || replyCount == 0) return; - - addMessage(parentMessage.copyWith(replyCount: replyCount - 1)); - } - updateThreadInfo( + final threadMessages = [...threads[parentId]!]; + return updateThreadInfo( parentId, - threads[parentId]! - ..removeWhere( - (e) => e.id == message.id, - ), + threadMessages..removeWhere((e) => e.id == message.id), ); - } else { - // Remove regular message - final allMessages = [...messages]; - if (hardDelete) { - allMessages.removeWhere((e) => e.id == message.id); - _channelState = _channelState.copyWith(messages: allMessages); - } else if (allMessages.remove(message)) { - _channelState = _channelState.copyWith(messages: allMessages); - } } + + // Remove regular message + final allMessages = [...messages]; + _channelState = _channelState.copyWith( + messages: allMessages..removeWhere((e) => e.id == message.id), + ); } void _listenReadEvents() { diff --git a/packages/stream_chat/lib/src/client/retry_queue.dart b/packages/stream_chat/lib/src/client/retry_queue.dart index 17b019a5..5dfa9aa3 100644 --- a/packages/stream_chat/lib/src/client/retry_queue.dart +++ b/packages/stream_chat/lib/src/client/retry_queue.dart @@ -158,7 +158,7 @@ class RetryQueue { : message.status == MessageSendingStatus.updating ? MessageSendingStatus.failed_update : MessageSendingStatus.failed_delete; - channel.state?.addMessage(message.copyWith(status: newStatus)); + channel.state?.updateMessage(message.copyWith(status: newStatus)); } Future _retryMessage(Message message) async { From d2a0fd603dd5339fd1049a7be942007f594ee1e5 Mon Sep 17 00:00:00 2001 From: Gordon Hayes Date: Mon, 21 Feb 2022 11:00:54 +0100 Subject: [PATCH 03/12] fix: controllers not disposed --- packages/stream_chat_flutter/lib/src/full_screen_media.dart | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/full_screen_media.dart b/packages/stream_chat_flutter/lib/src/full_screen_media.dart index 83ae96b1..de4ee001 100644 --- a/packages/stream_chat_flutter/lib/src/full_screen_media.dart +++ b/packages/stream_chat_flutter/lib/src/full_screen_media.dart @@ -264,9 +264,11 @@ class _FullScreenMediaState extends State ); @override - void dispose() async { + void dispose() { + _controller.dispose(); + _pageController.dispose(); for (final package in videoPackages.values) { - await package.dispose(); + package.dispose(); } super.dispose(); } From ae44406b96ec39a9cc275c8d51ddf841bf7df9eb Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Mon, 21 Feb 2022 15:31:23 +0530 Subject: [PATCH 04/12] fix(llc): Fix `channelState.copyWith` with respect to pinnedMessages. Signed-off-by: xsahil03x --- packages/stream_chat/CHANGELOG.md | 1 + .../stream_chat/lib/src/core/models/channel_state.dart | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/stream_chat/CHANGELOG.md b/packages/stream_chat/CHANGELOG.md index 82225b27..ef66f835 100644 --- a/packages/stream_chat/CHANGELOG.md +++ b/packages/stream_chat/CHANGELOG.md @@ -10,6 +10,7 @@ - [[#890]](https://github.com/GetStream/stream-chat-flutter/pull/890) Fixed Reactions not updating on thread messages. Thanks [bstolinski](https://github.com/bstolinski). - [[#897]](https://github.com/GetStream/stream-chat-flutter/issues/897) Fixed error type mis-match in `AuthInterceptor`. +- Fix `channelState.copyWith` with respect to pinnedMessages. ## 3.4.0 diff --git a/packages/stream_chat/lib/src/core/models/channel_state.dart b/packages/stream_chat/lib/src/core/models/channel_state.dart index 3ddc2b68..8b500d18 100644 --- a/packages/stream_chat/lib/src/core/models/channel_state.dart +++ b/packages/stream_chat/lib/src/core/models/channel_state.dart @@ -67,9 +67,10 @@ class ChannelState { members: members ?? this.members, // Hack to avoid using the default value in case nothing is provided. // FIXME: Use non-nullable by default instead of empty list. - pinnedMessages: pinnedMessages == _emptyPinnedMessages - ? this.pinnedMessages - : pinnedMessages ?? _emptyPinnedMessages, + pinnedMessages: + pinnedMessages == null || pinnedMessages == _emptyPinnedMessages + ? this.pinnedMessages + : pinnedMessages, watcherCount: watcherCount ?? this.watcherCount, watchers: watchers ?? this.watchers, read: read ?? this.read, From 2cef5396397b828404e5fc8d78b2266b953232d6 Mon Sep 17 00:00:00 2001 From: Gordon Hayes Date: Mon, 21 Feb 2022 12:19:36 +0100 Subject: [PATCH 05/12] perf: improve full screen media animations --- .../lib/src/full_screen_media.dart | 232 +++++++++--------- 1 file changed, 117 insertions(+), 115 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/full_screen_media.dart b/packages/stream_chat_flutter/lib/src/full_screen_media.dart index de4ee001..aa185597 100644 --- a/packages/stream_chat_flutter/lib/src/full_screen_media.dart +++ b/packages/stream_chat_flutter/lib/src/full_screen_media.dart @@ -65,24 +65,35 @@ class FullScreenMedia extends StatefulWidget { class _FullScreenMediaState extends State with SingleTickerProviderStateMixin { - bool _optionsShown = true; - - late final AnimationController _controller; + late final AnimationController _animationController; late final PageController _pageController; - late int _currentPage; + late final _curvedAnimation = CurvedAnimation( + parent: _animationController, + curve: Curves.easeOut, + reverseCurve: Curves.easeIn, + ); + + final _opacityTween = Tween(begin: 1, end: 0); + late final _opacityAnimation = _opacityTween.animate( + CurvedAnimation( + parent: _animationController, + curve: const Interval(0, 0.6, curve: Curves.easeOut), + ), + ); + + late final ValueNotifier _currentPage = ValueNotifier(widget.startIndex); final videoPackages = {}; @override void initState() { super.initState(); - _controller = AnimationController( + _animationController = AnimationController( vsync: this, duration: const Duration(milliseconds: 300), ); _pageController = PageController(initialPage: widget.startIndex); - _currentPage = widget.startIndex; for (var i = 0; i < widget.mediaAttachments.length; i++) { final attachment = widget.mediaAttachments[i]; if (attachment.type != 'video') continue; @@ -116,41 +127,38 @@ class _FullScreenMediaState extends State resizeToAvoidBottomInset: false, body: Stack( children: [ - AnimatedBuilder( - animation: _controller, - builder: (context, snapshot) => PageView.builder( - controller: _pageController, - onPageChanged: (val) { - setState(() { - _currentPage = val; - }); + PageView.builder( + controller: _pageController, + onPageChanged: (val) { + _currentPage.value = val; - if (videoPackages.isEmpty) { - return; + if (videoPackages.isEmpty) { + return; + } + + final currentAttachment = widget.mediaAttachments[val]; + + for (final e in videoPackages.values) { + if (e._attachment != currentAttachment) { + e._chewieController?.pause(); } + } - final currentAttachment = widget.mediaAttachments[val]; - - for (final e in videoPackages.values) { - if (e._attachment != currentAttachment) { - e._chewieController?.pause(); - } - } - - if (widget.autoplayVideos && - currentAttachment.type == 'video') { - final controller = videoPackages[currentAttachment.id]!; - controller._chewieController?.play(); - } - }, - itemBuilder: (context, index) { - final attachment = widget.mediaAttachments[index]; - if (attachment.type == 'image' || - attachment.type == 'giphy') { - final imageUrl = attachment.imageUrl ?? - attachment.assetUrl ?? - attachment.thumbUrl; - return PhotoView( + if (widget.autoplayVideos && + currentAttachment.type == 'video') { + final controller = videoPackages[currentAttachment.id]!; + controller._chewieController?.play(); + } + }, + itemBuilder: (context, index) { + final attachment = widget.mediaAttachments[index]; + if (attachment.type == 'image' || attachment.type == 'giphy') { + final imageUrl = attachment.imageUrl ?? + attachment.assetUrl ?? + attachment.thumbUrl; + return AnimatedBuilder( + animation: _curvedAnimation, + builder: (context, child) => PhotoView( loadingBuilder: (context, image) => const Offstage(), imageProvider: (imageUrl == null && attachment.localUri != null && @@ -166,97 +174,91 @@ class _FullScreenMediaState extends State color: ColorTween( begin: ChannelHeaderTheme.of(context).color, end: Colors.black, - ).lerp(_controller.value), + ).lerp(_curvedAnimation.value), ), onTapUp: (a, b, c) { - setState(() { - _optionsShown = !_optionsShown; - }); - if (_controller.isCompleted) { - _controller.reverse(); + if (_animationController.isCompleted) { + _animationController.reverse(); } else { - _controller.forward(); + _animationController.forward(); } }, - ); - } else if (attachment.type == 'video') { - final controller = videoPackages[attachment.id]!; - if (!controller.initialized) { - return const Center( - child: CircularProgressIndicator(), - ); - } - return InkWell( - onTap: () { - setState(() { - _optionsShown = !_optionsShown; - }); - if (_controller.isCompleted) { - _controller.reverse(); - } else { - _controller.forward(); - } - }, - child: Padding( - padding: const EdgeInsets.symmetric( - vertical: 50, - ), - child: Chewie( - controller: controller.chewieController!, - ), - ), + ), + ); + } else if (attachment.type == 'video') { + final controller = videoPackages[attachment.id]!; + if (!controller.initialized) { + return const Center( + child: CircularProgressIndicator(), ); } - return Container(); - }, - itemCount: widget.mediaAttachments.length, - ), - ), - AnimatedOpacity( - opacity: _optionsShown ? 1.0 : 0.0, - duration: const Duration(milliseconds: 300), - child: Column( - mainAxisAlignment: MainAxisAlignment.spaceBetween, - children: [ - GalleryHeader( - userName: widget.userName, - sentAt: context.translations.sentAtText( - date: widget.message.createdAt, - time: widget.message.createdAt, + return InkWell( + onTap: () { + if (_animationController.isCompleted) { + _animationController.reverse(); + } else { + _animationController.forward(); + } + }, + child: Padding( + padding: const EdgeInsets.symmetric( + vertical: 50, + ), + child: Chewie( + controller: controller.chewieController!, + ), ), - onBackPressed: () { - Navigator.of(context).pop(); - }, - message: widget.message, - currentIndex: _currentPage, - onShowMessage: () { - widget.onShowMessage?.call( - widget.message, - StreamChannel.of(context).channel, - ); - }, - attachmentActionsModalBuilder: - widget.attachmentActionsModalBuilder, - ), - if (!widget.message.isEphemeral) - GalleryFooter( - currentPage: _currentPage, - totalPages: widget.mediaAttachments.length, - mediaAttachments: widget.mediaAttachments, + ); + } + return const SizedBox(); + }, + itemCount: widget.mediaAttachments.length, + ), + FadeTransition( + opacity: _opacityAnimation, + child: ValueListenableBuilder( + valueListenable: _currentPage, + builder: (context, value, child) => Column( + mainAxisAlignment: MainAxisAlignment.spaceBetween, + children: [ + GalleryHeader( + userName: widget.userName, + sentAt: context.translations.sentAtText( + date: widget.message.createdAt, + time: widget.message.createdAt, + ), + onBackPressed: () { + Navigator.of(context).pop(); + }, message: widget.message, - mediaSelectedCallBack: (val) { - setState(() { - _currentPage = val; + currentIndex: value, + onShowMessage: () { + widget.onShowMessage?.call( + widget.message, + StreamChannel.of(context).channel, + ); + }, + attachmentActionsModalBuilder: + widget.attachmentActionsModalBuilder, + ), + if (!widget.message.isEphemeral) + GalleryFooter( + currentPage: value, + totalPages: widget.mediaAttachments.length, + mediaAttachments: widget.mediaAttachments, + message: widget.message, + mediaSelectedCallBack: (val) { + _currentPage.value = val; _pageController.animateToPage( val, duration: const Duration(milliseconds: 300), curve: Curves.easeInOut, ); Navigator.pop(context); - }); - }, - ), - ], + }, + ), + ], + ), ), ), ], @@ -265,7 +267,7 @@ class _FullScreenMediaState extends State @override void dispose() { - _controller.dispose(); + _animationController.dispose(); _pageController.dispose(); for (final package in videoPackages.values) { package.dispose(); From e9626dc348ae9ecefe8df29b3667bf95de69de57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Stolin=CC=81ski?= Date: Tue, 22 Feb 2022 09:42:21 +0100 Subject: [PATCH 06/12] fix removing message from thread --- packages/stream_chat/CHANGELOG.md | 2 ++ .../stream_chat/lib/src/client/channel.dart | 18 +++++++++++++----- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/packages/stream_chat/CHANGELOG.md b/packages/stream_chat/CHANGELOG.md index 82225b27..59feb777 100644 --- a/packages/stream_chat/CHANGELOG.md +++ b/packages/stream_chat/CHANGELOG.md @@ -10,6 +10,8 @@ - [[#890]](https://github.com/GetStream/stream-chat-flutter/pull/890) Fixed Reactions not updating on thread messages. Thanks [bstolinski](https://github.com/bstolinski). - [[#897]](https://github.com/GetStream/stream-chat-flutter/issues/897) Fixed error type mis-match in `AuthInterceptor`. +- [[#891]](https://github.com/GetStream/stream-chat-flutter/pull/891). Fixed reply counter for parent message not + updating correctly after deleting thread message. ## 3.4.0 diff --git a/packages/stream_chat/lib/src/client/channel.dart b/packages/stream_chat/lib/src/client/channel.dart index c27f3634..2b311061 100644 --- a/packages/stream_chat/lib/src/client/channel.dart +++ b/packages/stream_chat/lib/src/client/channel.dart @@ -1826,11 +1826,19 @@ class ChannelClientState { final parentId = message.parentId; // i.e. it's a thread message, Remove it if (parentId != null) { - final threadMessages = [...threads[parentId]!]; - return updateThreadInfo( - parentId, - threadMessages..removeWhere((e) => e.id == message.id), - ); + if (!threads.containsKey(parentId)) { + return; + } + + final newThreads = Map>.from(threads); + + newThreads[parentId] = [ + ...newThreads[parentId]! + ..removeWhere((e) => e.id == message.id), + ]; + + _threads = newThreads; + return; } // Remove regular message From 52b035cb5fc226c63771bac75b44760116e11b50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Stolin=CC=81ski?= Date: Tue, 22 Feb 2022 09:49:18 +0100 Subject: [PATCH 07/12] fix formatting --- packages/stream_chat/CHANGELOG.md | 2 +- packages/stream_chat/lib/src/client/channel.dart | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/stream_chat/CHANGELOG.md b/packages/stream_chat/CHANGELOG.md index 59feb777..6bbc3b16 100644 --- a/packages/stream_chat/CHANGELOG.md +++ b/packages/stream_chat/CHANGELOG.md @@ -10,7 +10,7 @@ - [[#890]](https://github.com/GetStream/stream-chat-flutter/pull/890) Fixed Reactions not updating on thread messages. Thanks [bstolinski](https://github.com/bstolinski). - [[#897]](https://github.com/GetStream/stream-chat-flutter/issues/897) Fixed error type mis-match in `AuthInterceptor`. -- [[#891]](https://github.com/GetStream/stream-chat-flutter/pull/891). Fixed reply counter for parent message not +- [[#891]](https://github.com/GetStream/stream-chat-flutter/pull/891) Fixed reply counter for parent message not updating correctly after deleting thread message. ## 3.4.0 diff --git a/packages/stream_chat/lib/src/client/channel.dart b/packages/stream_chat/lib/src/client/channel.dart index 2b311061..072bb150 100644 --- a/packages/stream_chat/lib/src/client/channel.dart +++ b/packages/stream_chat/lib/src/client/channel.dart @@ -1833,8 +1833,7 @@ class ChannelClientState { final newThreads = Map>.from(threads); newThreads[parentId] = [ - ...newThreads[parentId]! - ..removeWhere((e) => e.id == message.id), + ...newThreads[parentId]!..removeWhere((e) => e.id == message.id), ]; _threads = newThreads; From a361e89abad9cc5e70980cf86067518a3392ce3f Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Wed, 23 Feb 2022 17:55:34 +0530 Subject: [PATCH 08/12] fix(llc): fix `pinnedMessage` inconsistencies. Signed-off-by: xsahil03x --- .../stream_chat/lib/src/client/channel.dart | 38 +++++++++++-------- .../lib/src/core/models/channel_state.dart | 9 ++--- 2 files changed, 27 insertions(+), 20 deletions(-) diff --git a/packages/stream_chat/lib/src/client/channel.dart b/packages/stream_chat/lib/src/client/channel.dart index 76fbab7a..dd6fcff1 100644 --- a/packages/stream_chat/lib/src/client/channel.dart +++ b/packages/stream_chat/lib/src/client/channel.dart @@ -1744,15 +1744,6 @@ class ChannelClientState { ownReactions: oldMessage?.ownReactions, ); addMessage(message); - - if (message.pinned) { - _channelState = _channelState.copyWith( - pinnedMessages: [ - ..._channelState.pinnedMessages, - message, - ], - ); - } })); } @@ -1804,8 +1795,24 @@ class ChannelClientState { newMessages.add(message); } + final newPinnedMessages = [...pinnedMessages]; + final oldPinnedIndex = + newPinnedMessages.indexWhere((m) => m.id == message.id); + + // Handle pinned messages + if (message.pinned) { + if (oldPinnedIndex != -1) { + newPinnedMessages[oldPinnedIndex] = message; + } else { + newPinnedMessages.add(message); + } + } else { + newPinnedMessages.removeWhere((m) => m.id == message.id); + } + _channelState = _channelState.copyWith( messages: newMessages..sort(_sortByCreatedAt), + pinnedMessages: newPinnedMessages, channel: _channelState.channel?.copyWith( lastMessageAt: message.createdAt, ), @@ -1898,11 +1905,12 @@ class ChannelClientState { .distinct(const ListEquality().equals); /// Channel pinned message list. - List get pinnedMessages => _channelState.pinnedMessages.toList(); + List get pinnedMessages => _channelState.pinnedMessages; /// Channel pinned message list as a stream. - Stream> get pinnedMessagesStream => - channelStateStream.map((cs) => cs.pinnedMessages.toList()); + Stream> get pinnedMessagesStream => channelStateStream + .map((cs) => cs.pinnedMessages) + .distinct(const ListEquality().equals); /// Get channel last message. Message? get lastMessage => @@ -2213,7 +2221,7 @@ class ChannelClientState { .toList(); updateChannelState(_channelState.copyWith( - pinnedMessages: pinnedMessages.where(_pinIsValid()).toList(), + pinnedMessages: pinnedMessages.where(_pinIsValid).toList(), messages: expiredMessages, )); } @@ -2250,7 +2258,7 @@ class ChannelClientState { } } -bool Function(Message) _pinIsValid() { +bool _pinIsValid(Message message) { final now = DateTime.now(); - return (Message m) => m.pinExpires!.isAfter(now); + return message.pinExpires!.isAfter(now); } diff --git a/packages/stream_chat/lib/src/core/models/channel_state.dart b/packages/stream_chat/lib/src/core/models/channel_state.dart index 8b500d18..17439dc0 100644 --- a/packages/stream_chat/lib/src/core/models/channel_state.dart +++ b/packages/stream_chat/lib/src/core/models/channel_state.dart @@ -56,7 +56,7 @@ class ChannelState { ChannelModel? channel, List? messages, List? members, - List? pinnedMessages, + List pinnedMessages = _emptyPinnedMessages, int? watcherCount, List? watchers, List? read, @@ -67,10 +67,9 @@ class ChannelState { members: members ?? this.members, // Hack to avoid using the default value in case nothing is provided. // FIXME: Use non-nullable by default instead of empty list. - pinnedMessages: - pinnedMessages == null || pinnedMessages == _emptyPinnedMessages - ? this.pinnedMessages - : pinnedMessages, + pinnedMessages: pinnedMessages == _emptyPinnedMessages + ? this.pinnedMessages + : pinnedMessages, watcherCount: watcherCount ?? this.watcherCount, watchers: watchers ?? this.watchers, read: read ?? this.read, From c7ba48a446902ccfb0debb615add836f056dd90c Mon Sep 17 00:00:00 2001 From: Ayush Shekhar Date: Thu, 24 Feb 2022 15:56:19 +0530 Subject: [PATCH 09/12] Pass null for onImageTap when no function is passed --- packages/stream_chat_flutter/lib/src/channel_list_view.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/stream_chat_flutter/lib/src/channel_list_view.dart b/packages/stream_chat_flutter/lib/src/channel_list_view.dart index 0ceff00e..bc4f4b19 100644 --- a/packages/stream_chat_flutter/lib/src/channel_list_view.dart +++ b/packages/stream_chat_flutter/lib/src/channel_list_view.dart @@ -599,7 +599,9 @@ class _ChannelListViewState extends State { child: ChannelPreview( onLongPress: widget.onChannelLongPress, channel: channel, - onImageTap: () => widget.onImageTap?.call(channel), + onImageTap: widget.onImageTap != null + ? () => widget.onImageTap!(channel) + : null, onTap: (channel) => onTap(channel, widget.channelWidget), ), ), From e7d8810722414fd0726796e1c36e605f42eb44b8 Mon Sep 17 00:00:00 2001 From: Ayush Shekhar Date: Thu, 24 Feb 2022 16:05:00 +0530 Subject: [PATCH 10/12] Added entry in changelog --- packages/stream_chat_flutter/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/stream_chat_flutter/CHANGELOG.md b/packages/stream_chat_flutter/CHANGELOG.md index 4bc77514..d4a64c1a 100644 --- a/packages/stream_chat_flutter/CHANGELOG.md +++ b/packages/stream_chat_flutter/CHANGELOG.md @@ -5,6 +5,7 @@ - [[#888]](https://github.com/GetStream/stream-chat-flutter/issues/888) Fix `unban` command not working in `MessageInput`. - [[#805]](https://github.com/GetStream/stream-chat-flutter/issues/805) Updated chewie dependency version to 1.3.0 - Fix `showScrollToBottom` in `MessageListView` not respecting false value. +- Fix default `Channel` route not opening from `ChannelListView` when `ChannelAvatar` is tapped ## 3.4.0 - Updated `stream_chat_flutter_core` dependency to [`3.4.0`](https://pub.dev/packages/stream_chat_flutter_core/changelog). From 8bfd93266eda2df7b9f93c8491929666b5361fc7 Mon Sep 17 00:00:00 2001 From: Ayush Shekhar Date: Thu, 24 Feb 2022 16:30:51 +0530 Subject: [PATCH 11/12] Fix: variable for channel was named client --- packages/stream_chat_flutter/lib/src/channel_list_view.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/stream_chat_flutter/lib/src/channel_list_view.dart b/packages/stream_chat_flutter/lib/src/channel_list_view.dart index bc4f4b19..648226ce 100644 --- a/packages/stream_chat_flutter/lib/src/channel_list_view.dart +++ b/packages/stream_chat_flutter/lib/src/channel_list_view.dart @@ -614,7 +614,7 @@ class _ChannelListViewState extends State { if (widget.onChannelTap != null) { onTap = widget.onChannelTap!; } else { - onTap = (client, _) { + onTap = (channel, _) { if (widget.channelWidget == null) { return; } @@ -622,7 +622,7 @@ class _ChannelListViewState extends State { context, MaterialPageRoute( builder: (context) => StreamChannel( - channel: client, + channel: channel, child: widget.channelWidget!, ), ), From 655da0ba33855a667108391fdd89a8f6d2ccfd6e Mon Sep 17 00:00:00 2001 From: Sahil Kumar Date: Tue, 1 Mar 2022 14:19:20 +0530 Subject: [PATCH 12/12] fix(llc): Remove regular message in case `showInChannel` is true. (#3) * fix(llc): also remove regular message in case `showInChannel` is true. * fix(llc): use `hard` param while removing message in channel state. --- .../stream_chat/lib/src/client/channel.dart | 48 ++++++++++++------- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/packages/stream_chat/lib/src/client/channel.dart b/packages/stream_chat/lib/src/client/channel.dart index 072bb150..b0f1bdd0 100644 --- a/packages/stream_chat/lib/src/client/channel.dart +++ b/packages/stream_chat/lib/src/client/channel.dart @@ -643,13 +643,18 @@ class Channel { /// Deletes the [message] from the channel. Future deleteMessage(Message message, {bool? hard}) async { + final hardDelete = hard ?? false; + // Directly deleting the local messages which are not yet sent to server if (message.status == MessageSendingStatus.sending || message.status == MessageSendingStatus.failed) { - state!.updateMessage(message.copyWith( - type: 'deleted', - status: MessageSendingStatus.sent, - )); + state!.deleteMessage( + message.copyWith( + type: 'deleted', + status: MessageSendingStatus.sent, + ), + hardDelete: hardDelete, + ); // Removing the attachments upload completer to stop the `sendMessage` // waiting for attachments to complete. @@ -667,11 +672,14 @@ class Channel { deletedAt: message.deletedAt ?? DateTime.now(), ); - state?.updateMessage(message); + state?.deleteMessage(message, hardDelete: hardDelete); final response = await _client.deleteMessage(message.id, hard: hard); - state?.updateMessage(message.copyWith(status: MessageSendingStatus.sent)); + state?.deleteMessage( + message.copyWith(status: MessageSendingStatus.sent), + hardDelete: hardDelete, + ); return response; } catch (e) { @@ -1826,27 +1834,33 @@ class ChannelClientState { final parentId = message.parentId; // i.e. it's a thread message, Remove it if (parentId != null) { - if (!threads.containsKey(parentId)) { - return; - } + final newThreads = {...threads}; + // Early return in case the thread is not available + if (!newThreads.containsKey(parentId)) return; - final newThreads = Map>.from(threads); + _threads = newThreads + ..update( + parentId, + (messages) => messages..removeWhere((e) => e.id == message.id), + ); - newThreads[parentId] = [ - ...newThreads[parentId]!..removeWhere((e) => e.id == message.id), - ]; - - _threads = newThreads; - return; + // Early return if the thread message is not shown in channel. + if (message.showInChannel == false) return; } - // Remove regular message + // Remove regular message, thread message shown in channel final allMessages = [...messages]; _channelState = _channelState.copyWith( messages: allMessages..removeWhere((e) => e.id == message.id), ); } + /// Removes/Updates the [message] based on the [hardDelete] value. + void deleteMessage(Message message, {bool hardDelete = false}) { + if (hardDelete) return removeMessage(message); + return updateMessage(message); + } + void _listenReadEvents() { if (_channelState.channel?.config.readEvents == false) { return;