From f9eb948fc3f92e53b6e09b977f451a1d042a08f1 Mon Sep 17 00:00:00 2001
From: talksik <patel.arjun50@gmail.com>
Date: Mon, 30 May 2022 09:05:22 -0500
Subject: [PATCH] globally using only user cache

---
 .../src/components/ConversationDetails.tsx    | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/packages/desktop/src/components/ConversationDetails.tsx b/packages/desktop/src/components/ConversationDetails.tsx
index 44a989c..298f373 100644
--- a/packages/desktop/src/components/ConversationDetails.tsx
+++ b/packages/desktop/src/components/ConversationDetails.tsx
@@ -24,7 +24,6 @@ import { useRendersCount } from 'react-use';
 export default function ConversationDetails() {
   const { user } = useAuth();
   const { getUser, selectedConversation, selectConversation, isCloudDoingMagic } = useTerminal();
-  const [conversationUsers, setConversationUsers] = useImmer<User[]>([]);
 
   const rendersCount = useRendersCount();
   console.warn('RENDER COUNT | CONVERSATION DETAILS | ', rendersCount);
@@ -70,20 +69,6 @@ export default function ConversationDetails() {
   // TODO: uncheck priority or not
   // soft max of 10...not going to enforce by counting all in database, but relying on client side list of convos
 
-  useEffect(() => {
-    (async () => {
-      const userPromises = selectedConversation.memberIdsList
-        // .filter((memberId) => memberId !== user.uid)
-        .map(async (memberId) => await getUser(memberId));
-
-      const userSettled = await Promise.all(userPromises);
-
-      setConversationUsers(userSettled);
-    })();
-
-    return;
-  }, [selectedConversation.memberIdsList, getUser, user, setConversationUsers]);
-
   return (
     <>
       <Stack
@@ -105,13 +90,13 @@ export default function ConversationDetails() {
 
         <Box sx={{ mr: 'auto', color: 'GrayText' }}>
           <ConversationLabel
-            users={conversationUsers}
+            users={selectedConversation.userCache ?? []}
             conversationName={selectedConversation.name}
           />
         </Box>
 
         <AvatarGroup variant={'rounded'} sx={{ ml: 'auto' }}>
-          {conversationUsers.map((conversationUser, index) => (
+          {selectedConversation.userCache?.map((conversationUser, index) => (
             <Avatar
               key={`${selectedConversation.id}-${conversationUser.uid}-convoIcon`}
               alt={conversationUser?.displayName}