From 70e78dd00b9e1d33bd09d33a8deb36c010f5bb23 Mon Sep 17 00:00:00 2001
From: talksik <patel.arjun50@gmail.com>
Date: Sun, 29 May 2022 12:31:34 -0500
Subject: [PATCH] on unmount take care although every should disconnect on
 firebase since we don't mount and unmount this component much

---
 packages/desktop/src/components/Terminal.tsx | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/desktop/src/components/Terminal.tsx b/packages/desktop/src/components/Terminal.tsx
index 8fd6918..c283fc0 100644
--- a/packages/desktop/src/components/Terminal.tsx
+++ b/packages/desktop/src/components/Terminal.tsx
@@ -227,7 +227,11 @@ export function TerminalProvider({ children }: { children?: React.ReactNode }) {
 
     // TODO: future work/optimization
     // if we removed a conversation, unsubscribe from content listener as well
-  }, [conversationMap, updatecontentMap, enqueueSnackbar, setContentListeners]);
+
+    return () => {
+      Object.values(contentListeners).forEach((unsub) => unsub());
+    };
+  }, [conversationMap, updatecontentMap, enqueueSnackbar, setContentListeners, contentListeners]);
 
   // cache of selected conversation
   const selectedConversation: Conversation | undefined = useMemo(() => {