From c98e564098ec765b361514ca7dad8293a8910b5c Mon Sep 17 00:00:00 2001
From: talksik <patel.arjun50@gmail.com>
Date: Sat, 11 Jun 2022 08:33:25 -0500
Subject: [PATCH] more error handling for create conversation routre

---
 packages/api/routes/conversations.ts | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/packages/api/routes/conversations.ts b/packages/api/routes/conversations.ts
index a96f686..a9e7084 100644
--- a/packages/api/routes/conversations.ts
+++ b/packages/api/routes/conversations.ts
@@ -16,7 +16,7 @@ export default function getConversationRoutes() {
   router.get('/:conversationId', authCheck);
 
   // get all conversations that I am in
-  router.get('/conversations', authCheck);
+  router.get('/', authCheck);
 
   // get a one on one conversation based on other user Id
 
@@ -31,15 +31,23 @@ export default function getConversationRoutes() {
 const createConversation = async (req: Request, res: Response, next: NextFunction) => {
   const createRequest = req.body as CreateConversationRequest;
 
-  next(Error('test this shit'));
+  console.log(createRequest.conversation);
 
-  // console.log(createRequest.conversation);
+  if (!createRequest.conversation) {
+    return next(new Error('must pass in a conversation'));
+  }
 
-  // const insertResult = await ConversationService.createConversation(createRequest.conversation);
+  const insertResult = await ConversationService.createConversation(createRequest.conversation);
 
-  // if (!insertResult?.acknowledged) {
-  //   throw Error('nothing inserted');
-  // }
+  if (!insertResult) {
+    return next(Error('unale to create a conversation'));
+  }
 
-  // return res.json(new CreateConversationResponse(insertResult.insertedId));
+  const responseObj = new NirvanaResponse<CreateConversationResponse>(
+    new CreateConversationResponse(insertResult.insertedId),
+    undefined,
+    'created conversation!',
+  );
+
+  return res.json(responseObj);
 };