From 227d596f0139040ac408b8c75926d7a4da2a5782 Mon Sep 17 00:00:00 2001
From: talksik <patel.arjun50@gmail.com>
Date: Tue, 3 May 2022 10:25:31 -0500
Subject: [PATCH] further clean up with trick

---
 packages/desktop/index.d.ts                          |  1 -
 .../src/components/lines/lineRow.tsx/index.tsx       |  4 +++-
 packages/desktop/src/pages/overlay/index.tsx         | 11 +++++++++--
 packages/desktop/src/pages/terminal/index.tsx        | 12 ++++++++++--
 4 files changed, 22 insertions(+), 6 deletions(-)
 delete mode 100644 packages/desktop/index.d.ts

diff --git a/packages/desktop/index.d.ts b/packages/desktop/index.d.ts
deleted file mode 100644
index 8bfc621..0000000
--- a/packages/desktop/index.d.ts
+++ /dev/null
@@ -1 +0,0 @@
-declare module "@carbon/react";
diff --git a/packages/desktop/src/components/lines/lineRow.tsx/index.tsx b/packages/desktop/src/components/lines/lineRow.tsx/index.tsx
index b185fc7..2de21a7 100644
--- a/packages/desktop/src/components/lines/lineRow.tsx/index.tsx
+++ b/packages/desktop/src/components/lines/lineRow.tsx/index.tsx
@@ -6,9 +6,11 @@ import { ILineDetails } from "../../../pages/router/index";
 import LineIcon from "../lineIcon";
 
 export default function LineRow({
+  id,
   lineDetails,
   onClick,
 }: {
+  id: string;
   lineDetails: ILineDetails;
   onClick: (lineId: string) => void;
 }) {
@@ -80,7 +82,7 @@ export default function LineRow({
   return (
     <div
       onClick={handleSelectLine}
-      id={lineDetails.lineId}
+      id={id}
       className="flex flex-row items-center justify-start gap-2 p-2 px-4 h-14 hover:bg-gray-200 cursor-pointer transition-all
   last:border-b-0 border-b border-b-gray-200"
     >
diff --git a/packages/desktop/src/pages/overlay/index.tsx b/packages/desktop/src/pages/overlay/index.tsx
index 8f0fab6..abd1ed5 100644
--- a/packages/desktop/src/pages/overlay/index.tsx
+++ b/packages/desktop/src/pages/overlay/index.tsx
@@ -87,11 +87,12 @@ export default function Overlay() {
               var localPeerInitiator = new Peer({
                 initiator: true,
                 stream: localStream,
+                trickle: false, // prevents the multiple tries on different ice servers and signal from getting called a bunch of times
               });
 
               localPeerInitiator.on("signal", (signal) => {
                 console.log(
-                  "sending a signal to all users connected and adding local peer object",
+                  "created local initiator peer and sending signal to: ",
                   userSocketId
                 );
 
@@ -130,9 +131,15 @@ export default function Overlay() {
             console.log("ooo newbie joined room, I guess I will accept it ");
 
             // if we are answering a received signal
-            var peerToCallerPeer = new Peer({ initiator: false });
+            var peerToCallerPeer = new Peer({
+              initiator: false,
+              trickle: false, // prevents the multiple tries on different ice servers and signal from getting called a bunch of times
+            });
 
             peerToCallerPeer.on("signal", (signal) => {
+              console.log(
+                "as the answerer, I am going to send back my signal so that the newbie can update his local peer for me"
+              );
               socket.emit(SocketChannels.SEND_SIGNAL, {
                 userSocketIdToSignal: payload.senderUserSocketId,
                 simplePeerSignal: signal,
diff --git a/packages/desktop/src/pages/terminal/index.tsx b/packages/desktop/src/pages/terminal/index.tsx
index 05df6fb..6836ded 100644
--- a/packages/desktop/src/pages/terminal/index.tsx
+++ b/packages/desktop/src/pages/terminal/index.tsx
@@ -58,7 +58,11 @@ export default function NirvanaTerminal({
         {/* list of all lines */}
         <div className="flex flex-col mt-2">
           {toggleTunedLines.map((line) => (
-            <LineRow lineDetails={line} onClick={handleSelectLine} />
+            <LineRow
+              id={line.lineId}
+              lineDetails={line}
+              onClick={handleSelectLine}
+            />
           ))}
         </div>
       </div>
@@ -67,7 +71,11 @@ export default function NirvanaTerminal({
 
       <div className={"flex flex-col"}>
         {restLines.map((line) => (
-          <LineRow lineDetails={line} onClick={handleSelectLine} />
+          <LineRow
+            id={line.lineId}
+            lineDetails={line}
+            onClick={handleSelectLine}
+          />
         ))}
       </div>
     </div>