From 226ca56eeba412c6a5510e3fd3d57e3546bb7bb0 Mon Sep 17 00:00:00 2001 From: talksik Date: Sun, 19 Jun 2022 09:44:11 -0500 Subject: [PATCH] cleanup --- packages/api/services/socket.service.ts | 3 +-- .../src/providers/ConversationProvider.tsx | 18 ++++++------------ 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/packages/api/services/socket.service.ts b/packages/api/services/socket.service.ts index 9877467..c6c3c70 100644 --- a/packages/api/services/socket.service.ts +++ b/packages/api/services/socket.service.ts @@ -66,8 +66,6 @@ export default function InitializeWs(io: any) { console.log('asdf'); }); - // ?verification that user is in a particular line to be tuned into it or just generally in it? - /** CONNECT | User wants to subscribe to live emissions of a line */ socket.on(ServerRequestChannels.CONNECT_TO_LINE, (req: ConnectToLineRequest) => { // add this user to the room @@ -125,6 +123,7 @@ export default function InitializeWs(io: any) { ); }); + // ============== STREAMING ================ socket.on(ServerRequestChannels.RTC_CALL_SOMEONE_FOR_LINE, (req: RtcCallRequest) => { console.log('slave calling a master'); diff --git a/packages/desktop/src/providers/ConversationProvider.tsx b/packages/desktop/src/providers/ConversationProvider.tsx index e081184..e1662ec 100644 --- a/packages/desktop/src/providers/ConversationProvider.tsx +++ b/packages/desktop/src/providers/ConversationProvider.tsx @@ -541,20 +541,14 @@ function Room({ }); }; } + + // ======= LISTEN FOR INCOMING CALLS AND ACCEPT THEM + + return () => { + localPeersForRoom.forEach((peerToClose) => peerToClose.destroy()); + }; }); - const handleJoinRoom = useCallback((roomId: string) => { - // call up folks and then have listeners for the peer connection objects that we created - // such as when peer connection closes, we want to remove from our list of peers for such conversation - // error handler as well for the peer connection - // rest endpoint to get all of the folks in a certain room - }, []); - - const handleLeaveRoom = useCallback(() => { - // untune from line - // destroy peer connections - }, []); - // share audio to foreground conversation | either push to talk or toggle broadcasting const handleStartTalking = useCallback((record = false) => { // if record, then start recording