From 6e54d8c204ec720a3aeeddad01012d5b47d4c821 Mon Sep 17 00:00:00 2001
From: MediaPipe Team <mediapipe-team@google.com>
Date: Wed, 2 Aug 2023 05:08:34 -0700
Subject: [PATCH] Log stack traces for combined CalculatorGraph statuses

PiperOrigin-RevId: 553111356
---
 mediapipe/framework/calculator_graph.cc | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/mediapipe/framework/calculator_graph.cc b/mediapipe/framework/calculator_graph.cc
index 33ca41fb..05559a01 100644
--- a/mediapipe/framework/calculator_graph.cc
+++ b/mediapipe/framework/calculator_graph.cc
@@ -75,6 +75,11 @@ namespace {
 constexpr int kMaxNumAccumulatedErrors = 1000;
 constexpr char kApplicationThreadExecutorType[] = "ApplicationThreadExecutor";
 
+// Do not log status payloads, but do include stack traces.
+constexpr absl::StatusToStringMode kStatusLogFlags =
+    absl::StatusToStringMode::kWithEverything &
+    (~absl::StatusToStringMode::kWithPayload);
+
 }  // namespace
 
 void CalculatorGraph::ScheduleAllOpenableNodes() {
@@ -707,7 +712,7 @@ absl::Status CalculatorGraph::PrepareForRun(
   absl::Status error_status;
   if (has_error_) {
     GetCombinedErrors(&error_status);
-    LOG(ERROR) << error_status;
+    LOG(ERROR) << error_status.ToString(kStatusLogFlags);
     return error_status;
   }
 
@@ -786,7 +791,7 @@ absl::Status CalculatorGraph::PrepareForRun(
   }
 
   if (GetCombinedErrors(&error_status)) {
-    LOG(ERROR) << error_status;
+    LOG(ERROR) << error_status.ToString(kStatusLogFlags);
     CleanupAfterRun(&error_status);
     return error_status;
   }
@@ -850,7 +855,7 @@ absl::Status CalculatorGraph::WaitUntilIdle() {
   VLOG(2) << "Scheduler idle.";
   absl::Status status = absl::OkStatus();
   if (GetCombinedErrors(&status)) {
-    LOG(ERROR) << status;
+    LOG(ERROR) << status.ToString(kStatusLogFlags);
   }
   return status;
 }
@@ -1052,8 +1057,7 @@ void CalculatorGraph::RecordError(const absl::Status& error) {
 }
 
 bool CalculatorGraph::GetCombinedErrors(absl::Status* error_status) {
-  return GetCombinedErrors("CalculatorGraph::Run() failed in Run: ",
-                           error_status);
+  return GetCombinedErrors("CalculatorGraph::Run() failed: ", error_status);
 }
 
 bool CalculatorGraph::GetCombinedErrors(const std::string& error_prefix,