Revise the Halide Bazel build rules to be cleaner and more correct. The initial version we landed happened to work (at least in most cases) but had known workarounds in it. AFAICT, the issue seemed to be that the MediaPipe config_setting() values we were using didn't always resolve to the right thing when detecting the host cpu (vs the compile-target cpu), which is critical for Halide. I fixed this by avoiding the use of the MediaPipe config_settings entirely, using instead the public Bazel settings hosted at https://github.com/bazelbuild/platforms.

This revision builds and runs //mediapipe/util/frame_buffer:all correctly on my mac x86-64 laptop; I haven't yet attempted to build or test on any other platform, so there may well still be glitches, but I think this is more fundamentally sound than what we had before. PiperOrigin-RevId: 515682507
2023-03-10 10:59:17 -08:00
parent 05b505c8e2
commit 296c343332
3 changed files with 36 additions and 25 deletions
@@ -42,7 +42,7 @@ cc_library(
 cc_library(
    name = "lib_halide_static",
    srcs = select({
-        "@mediapipe//mediapipe:windows": [
+        "@halide//:halide_config_windows_x86_64": [
            "lib/Release/Halide.lib",
            "bin/Release/Halide.dll",
        ],