Just little changes.

This commit is contained in:
claudemiro
2015-01-15 07:53:18 -03:00
parent 414c1d98ee
commit 874c07267f
2 changed files with 5 additions and 10 deletions
+4 -8
View File
@@ -126,7 +126,7 @@ func (c *Channel) Subscribe(a *App, s *Subscriber, channelData string) error {
a.TriggerMemberAddedHook(c, subscription) a.TriggerMemberAddedHook(c, subscription)
// pusher_internal:subscription_succeeded // pusher_internal:subscription_succeeded
data := make(map[string]SubscriptionSucceeedEventPresenceData, 1) data := make(map[string]SubscriptionSucceeedEventPresenceData)
data["presence"] = NewSubscriptionSucceedEventPresenceData(c) data["presence"] = NewSubscriptionSucceedEventPresenceData(c)
js, err = json.Marshal(data) js, err = json.Marshal(data)
@@ -180,7 +180,7 @@ func (c *Channel) Unsubscribe(a *App, s *Subscriber) error {
} }
// WebHook // WebHook
if c.TotalSubscriptions() == 0 { if !c.IsOccupied() {
a.TriggerChannelVacatedHook(c) a.TriggerChannelVacatedHook(c)
} }
@@ -202,25 +202,21 @@ func NewSubscriber(socketID string, s *websocket.Conn) *Subscriber {
} }
// Publish a MemberAddedEvent to all subscriptions // Publish a MemberAddedEvent to all subscriptions
func (c *Channel) PublishMemberAddedEvent(a *App, data string, subscription *Subscription) error { func (c *Channel) PublishMemberAddedEvent(a *App, data string, subscription *Subscription) {
for _, subs := range c.Subscriptions { for _, subs := range c.Subscriptions {
if subs != subscription { if subs != subscription {
subs.Subscriber.Publish(NewMemberAddedEvent(c.ChannelID, data)) subs.Subscriber.Publish(NewMemberAddedEvent(c.ChannelID, data))
} }
} }
return nil
} }
// Publish a MemberRemovedEvent to all subscriptions // Publish a MemberRemovedEvent to all subscriptions
func (c *Channel) PublishMemberRemovedEvent(a *App, subscription *Subscription) error { func (c *Channel) PublishMemberRemovedEvent(a *App, subscription *Subscription) {
for _, subs := range c.Subscriptions { for _, subs := range c.Subscriptions {
if subs != subscription { if subs != subscription {
subs.Subscriber.Publish(NewMemberRemovedEvent(c.ChannelID, subscription)) subs.Subscriber.Publish(NewMemberRemovedEvent(c.ChannelID, subscription))
} }
} }
return nil
} }
// Publish messages to all Subscribers // Publish messages to all Subscribers
+1 -2
View File
@@ -121,7 +121,7 @@ func (a *App) TriggerMemberRemovedHook(c *Channel, s *Subscription) {
func triggerHook(name string, app *App, c *Channel, event HookEvent) { func triggerHook(name string, app *App, c *Channel, event HookEvent) {
if !app.WebHooks { if !app.WebHooks {
log.Infof("Checking webhooks enabled for app: %s", app.Name) log.Infof("Webhooks are not enabled for app: %s", app.Name)
return return
} }
@@ -145,7 +145,6 @@ func triggerHook(name string, app *App, c *Channel, event HookEvent) {
var req *http.Request var req *http.Request
req, err = http.NewRequest("POST", app.URLWebHook, bytes.NewReader(js)) req, err = http.NewRequest("POST", app.URLWebHook, bytes.NewReader(js))
if err != nil { if err != nil {
log.Errorf("Error creating request: %+v", err) log.Errorf("Error creating request: %+v", err)
return return