Ben Kraft
700392315a
## Summary: It would be nice to have some linting beyond `go vet`! Now we do. I started by copying the config from Khan/webapp. I did remove a couple of staticcheck checks that I didn't feel were useful. (Note also that exportloopref is the replacement for scopelint in newer golangci-lint.) Included are all the needed lint fixes; most are stylistic but the changes in the example are a (minor) bugfix. Fixes #22. Issue: https://github.com/Khan/genqlient/issues/22 ## Test plan: make check Author: benjaminjkraft Reviewers: aberkan, dnerdy, benjaminjkraft, csilvers, MiguelCastillo Required Reviewers: Approved by: aberkan, dnerdy Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Test (1.13), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Test (1.13), ✅ Lint Pull request URL: https://github.com/Khan/genqlient/pull/49
13 lines
269 B
Makefile
13 lines
269 B
Makefile
example:
|
|
go generate ./...
|
|
go run ./example/cmd/example/main.go
|
|
|
|
check:
|
|
go run github.com/golangci/golangci-lint/cmd/golangci-lint run ./...
|
|
go test -cover ./...
|
|
|
|
genqlient.png: genqlient.svg
|
|
convert -density 600 -background transparent "$<" "$@"
|
|
|
|
.PHONY: example
|