e6b1984d44
## Summary:
In this commit I add support for inline fragments
(`... on MyType { fields }`) to genqlient. This will make interfaces a
lot more useful! In future commits I'll add named fragments, for which
we'll generate slightly different types, as discussed in DESIGN.md.
In general, implementing the flattening approach described in DESIGN.md
was... surprisingly easy. All we have to do is recurse on applicable
fragments when generating our selection-set. The refactor to
selection-set handling this encouraged was, I think, quite beneficial.
It did reveal two tricky pre-existing issues.
One issue is that GraphQL allows for duplicate selections, as long as
they match. (In practice, this is only useful in the context of
fragments, although GraphQL allows it even without.) I decided to handle
the simple case (duplicate leaf fields; we just deduplicate) but leave
to the future the complex cases where we need to merge different
sub-selections (now #64). For now we just forbid that; we can see how
much it comes up.
The other issue is that we are generating type-names incorrectly for
interface types; I had intended to do `MyInterfaceMyFieldMyType` for
shared fields and `MyImplMyFieldMyType` for non-shared ones, but instead
I did `MyFieldMyType`, which is inconsistent already and can result in
conflicts in the presence of fragments. I'm going to fix this in a
separate commit, though, because it's going to require some refactoring
and is irrelevant to the main logic of this commit; I left some TODOs in
the tests related to this.
Issue: https://github.com/Khan/genqlient/issues/8
## Test plan:
make check
Author: benjaminjkraft
Reviewers: dnerdy, aberkan, MiguelCastillo
Required Reviewers:
Approved by: dnerdy
Checks: ⌛ Test (1.17), ⌛ Test (1.16), ⌛ Test (1.15), ⌛ Test (1.14), ⌛ Test (1.13), ✅ Lint, ⌛ Test (1.17), ⌛ Test (1.16), ⌛ Test (1.15), ⌛ Test (1.14), ⌛ Test (1.13), ✅ Lint
Pull request URL: https://github.com/Khan/genqlient/pull/65
187 lines
5.9 KiB
Go
187 lines
5.9 KiB
Go
package test
|
|
|
|
// Code generated by github.com/Khan/genqlient, DO NOT EDIT.
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"github.com/Khan/genqlient/graphql"
|
|
"github.com/Khan/genqlient/internal/testutil"
|
|
)
|
|
|
|
// SimpleInlineFragmentRandomItemArticle includes the requested fields of the GraphQL type Article.
|
|
type SimpleInlineFragmentRandomItemArticle struct {
|
|
Typename string `json:"__typename"`
|
|
// ID is the identifier of the content.
|
|
Id testutil.ID `json:"id"`
|
|
Name string `json:"name"`
|
|
Text string `json:"text"`
|
|
}
|
|
|
|
// SimpleInlineFragmentRandomItemContent includes the requested fields of the GraphQL interface Content.
|
|
//
|
|
// SimpleInlineFragmentRandomItemContent is implemented by the following types:
|
|
// SimpleInlineFragmentRandomItemArticle
|
|
// SimpleInlineFragmentRandomItemVideo
|
|
// SimpleInlineFragmentRandomItemTopic
|
|
//
|
|
// The GraphQL type's documentation follows.
|
|
//
|
|
// Content is implemented by various types like Article, Video, and Topic.
|
|
type SimpleInlineFragmentRandomItemContent interface {
|
|
implementsGraphQLInterfaceSimpleInlineFragmentRandomItemContent()
|
|
// GetTypename returns the receiver's concrete GraphQL type-name (see interface doc for possible values).
|
|
GetTypename() string
|
|
// GetId returns the interface-field "id" from its implementation.
|
|
// The GraphQL interface field's documentation follows.
|
|
//
|
|
// ID is the identifier of the content.
|
|
GetId() testutil.ID
|
|
// GetName returns the interface-field "name" from its implementation.
|
|
GetName() string
|
|
}
|
|
|
|
func (v *SimpleInlineFragmentRandomItemArticle) implementsGraphQLInterfaceSimpleInlineFragmentRandomItemContent() {
|
|
}
|
|
|
|
// GetTypename is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemArticle) GetTypename() string { return v.Typename }
|
|
|
|
// GetId is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemArticle) GetId() testutil.ID { return v.Id }
|
|
|
|
// GetName is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemArticle) GetName() string { return v.Name }
|
|
|
|
func (v *SimpleInlineFragmentRandomItemVideo) implementsGraphQLInterfaceSimpleInlineFragmentRandomItemContent() {
|
|
}
|
|
|
|
// GetTypename is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemVideo) GetTypename() string { return v.Typename }
|
|
|
|
// GetId is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemVideo) GetId() testutil.ID { return v.Id }
|
|
|
|
// GetName is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemVideo) GetName() string { return v.Name }
|
|
|
|
func (v *SimpleInlineFragmentRandomItemTopic) implementsGraphQLInterfaceSimpleInlineFragmentRandomItemContent() {
|
|
}
|
|
|
|
// GetTypename is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemTopic) GetTypename() string { return v.Typename }
|
|
|
|
// GetId is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemTopic) GetId() testutil.ID { return v.Id }
|
|
|
|
// GetName is a part of, and documented with, the interface SimpleInlineFragmentRandomItemContent.
|
|
func (v *SimpleInlineFragmentRandomItemTopic) GetName() string { return v.Name }
|
|
|
|
func __unmarshalSimpleInlineFragmentRandomItemContent(v *SimpleInlineFragmentRandomItemContent, m json.RawMessage) error {
|
|
if string(m) == "null" {
|
|
return nil
|
|
}
|
|
|
|
var tn struct {
|
|
TypeName string `json:"__typename"`
|
|
}
|
|
err := json.Unmarshal(m, &tn)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
switch tn.TypeName {
|
|
case "Article":
|
|
*v = new(SimpleInlineFragmentRandomItemArticle)
|
|
return json.Unmarshal(m, *v)
|
|
case "Video":
|
|
*v = new(SimpleInlineFragmentRandomItemVideo)
|
|
return json.Unmarshal(m, *v)
|
|
case "Topic":
|
|
*v = new(SimpleInlineFragmentRandomItemTopic)
|
|
return json.Unmarshal(m, *v)
|
|
default:
|
|
return fmt.Errorf(
|
|
`Unexpected concrete type for SimpleInlineFragmentRandomItemContent: "%v"`, tn.TypeName)
|
|
}
|
|
}
|
|
|
|
// SimpleInlineFragmentRandomItemTopic includes the requested fields of the GraphQL type Topic.
|
|
type SimpleInlineFragmentRandomItemTopic struct {
|
|
Typename string `json:"__typename"`
|
|
// ID is the identifier of the content.
|
|
Id testutil.ID `json:"id"`
|
|
Name string `json:"name"`
|
|
}
|
|
|
|
// SimpleInlineFragmentRandomItemVideo includes the requested fields of the GraphQL type Video.
|
|
type SimpleInlineFragmentRandomItemVideo struct {
|
|
Typename string `json:"__typename"`
|
|
// ID is the identifier of the content.
|
|
Id testutil.ID `json:"id"`
|
|
Name string `json:"name"`
|
|
Duration int `json:"duration"`
|
|
}
|
|
|
|
// SimpleInlineFragmentResponse is returned by SimpleInlineFragment on success.
|
|
type SimpleInlineFragmentResponse struct {
|
|
RandomItem SimpleInlineFragmentRandomItemContent `json:"-"`
|
|
}
|
|
|
|
func (v *SimpleInlineFragmentResponse) UnmarshalJSON(b []byte) error {
|
|
|
|
type SimpleInlineFragmentResponseWrapper SimpleInlineFragmentResponse
|
|
|
|
var firstPass struct {
|
|
*SimpleInlineFragmentResponseWrapper
|
|
RandomItem json.RawMessage `json:"randomItem"`
|
|
}
|
|
firstPass.SimpleInlineFragmentResponseWrapper = (*SimpleInlineFragmentResponseWrapper)(v)
|
|
|
|
err := json.Unmarshal(b, &firstPass)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
{
|
|
target := &v.RandomItem
|
|
raw := firstPass.RandomItem
|
|
err = __unmarshalSimpleInlineFragmentRandomItemContent(
|
|
target, raw)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func SimpleInlineFragment(
|
|
client graphql.Client,
|
|
) (*SimpleInlineFragmentResponse, error) {
|
|
var retval SimpleInlineFragmentResponse
|
|
err := client.MakeRequest(
|
|
nil,
|
|
"SimpleInlineFragment",
|
|
`
|
|
query SimpleInlineFragment {
|
|
randomItem {
|
|
__typename
|
|
id
|
|
name
|
|
... on Article {
|
|
text
|
|
}
|
|
... on Video {
|
|
duration
|
|
}
|
|
}
|
|
}
|
|
`,
|
|
&retval,
|
|
nil,
|
|
)
|
|
return &retval, err
|
|
}
|
|
|