## Summary:
One common use of fragment spreads is as the entirety of a field's
selection, e.g.
```graphql
query MyQuery {
myField {
...MyFragment
}
}
```
In this case, by default, genqlient generates a wrapper type
`MyQueryMyFieldMyType`, which just embeds `MyFragment`. This makes
sense if you later want to add more fields in addition to the fragment
spread. But if you don't -- and you did the fragment because you want
to share types, it's an extra layer of indirection. (Which becomes
especially onerous if `myField` has list type (`[MyType!]`), such that
it's not just an extra attribute-access to get to `MyFragment`.)
The new option `# @genqlient(flatten: true)` simplifies this situation:
if applied to `myField` is skips the wrapper type;
`MyQueryResponse.MyField` will simply have type `MyFragment` (or
`[]MyFragment`, or whatever). This should hopefully make the `typename`
option, which has more limitations, less necessary.
Note that in #30 the initial idea was to support this for fields as
well. This would require significant additional complexity in the
JSON-(un)marshaling code, and has proven less necessary, so I
implemented this option only for fragment-spreads for now. With that
restriction, it was shockingly simple; we have to hook into a bunch of
different places, but they're all quite simple, since the structure of
the Go types still matches the structure in GraphQL.
Issue: https://github.com/Khan/genqlient/issues/30
## Test plan:
make check
Author: benjaminjkraft
Reviewers: csilvers, dnerdy, aberkan, jvoll, mahtabsabet, MiguelCastillo, StevenACoffman
Required Reviewers:
Approved By: csilvers, dnerdy
Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint
Pull Request URL: https://github.com/Khan/genqlient/pull/121
333 lines
10 KiB
Go
333 lines
10 KiB
Go
package generate
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/vektah/gqlparser/v2/ast"
|
|
"github.com/vektah/gqlparser/v2/parser"
|
|
)
|
|
|
|
// Represents the genqlient directive, described in detail in
|
|
// docs/genqlient_directive.graphql.
|
|
type genqlientDirective struct {
|
|
pos *ast.Position
|
|
Omitempty *bool
|
|
Pointer *bool
|
|
Struct *bool
|
|
Flatten *bool
|
|
Bind string
|
|
TypeName string
|
|
}
|
|
|
|
func newGenqlientDirective(pos *ast.Position) *genqlientDirective {
|
|
return &genqlientDirective{
|
|
pos: pos,
|
|
}
|
|
}
|
|
|
|
func (dir *genqlientDirective) GetOmitempty() bool { return dir.Omitempty != nil && *dir.Omitempty }
|
|
func (dir *genqlientDirective) GetPointer() bool { return dir.Pointer != nil && *dir.Pointer }
|
|
func (dir *genqlientDirective) GetStruct() bool { return dir.Struct != nil && *dir.Struct }
|
|
func (dir *genqlientDirective) GetFlatten() bool { return dir.Flatten != nil && *dir.Flatten }
|
|
|
|
func setBool(optionName string, dst **bool, v *ast.Value, pos *ast.Position) error {
|
|
if *dst != nil {
|
|
return errorf(pos, "conflicting values for %v", optionName)
|
|
}
|
|
ei, err := v.Value(nil) // no vars allowed
|
|
if err != nil {
|
|
return errorf(pos, "invalid boolean value %v: %v", v, err)
|
|
}
|
|
if b, ok := ei.(bool); ok {
|
|
*dst = &b
|
|
return nil
|
|
}
|
|
return errorf(pos, "expected boolean, got non-boolean value %T(%v)", ei, ei)
|
|
}
|
|
|
|
func setString(optionName string, dst *string, v *ast.Value, pos *ast.Position) error {
|
|
if *dst != "" {
|
|
return errorf(pos, "conflicting values for %v", optionName)
|
|
}
|
|
ei, err := v.Value(nil) // no vars allowed
|
|
if err != nil {
|
|
return errorf(pos, "invalid string value %v: %v", v, err)
|
|
}
|
|
if b, ok := ei.(string); ok {
|
|
*dst = b
|
|
return nil
|
|
}
|
|
return errorf(pos, "expected string, got non-string value %T(%v)", ei, ei)
|
|
}
|
|
|
|
// add adds to this genqlientDirective struct the settings from then given
|
|
// GraphQL directive.
|
|
//
|
|
// If there are multiple genqlient directives are applied to the same node,
|
|
// e.g.
|
|
// # @genqlient(...)
|
|
// # @genqlient(...)
|
|
// add will be called several times. In this case, conflicts between the
|
|
// options are an error.
|
|
func (dir *genqlientDirective) add(graphQLDirective *ast.Directive, pos *ast.Position) error {
|
|
if graphQLDirective.Name != "genqlient" {
|
|
// Actually we just won't get here; we only get here if the line starts
|
|
// with "# @genqlient", unless there's some sort of bug.
|
|
return errorf(pos, "the only valid comment-directive is @genqlient, got %v", graphQLDirective.Name)
|
|
}
|
|
|
|
var err error
|
|
for _, arg := range graphQLDirective.Arguments {
|
|
switch arg.Name {
|
|
// TODO(benkraft): Use reflect and struct tags?
|
|
case "omitempty":
|
|
err = setBool("omitempty", &dir.Omitempty, arg.Value, pos)
|
|
case "pointer":
|
|
err = setBool("pointer", &dir.Pointer, arg.Value, pos)
|
|
case "struct":
|
|
err = setBool("struct", &dir.Struct, arg.Value, pos)
|
|
case "flatten":
|
|
err = setBool("flatten", &dir.Flatten, arg.Value, pos)
|
|
case "bind":
|
|
err = setString("bind", &dir.Bind, arg.Value, pos)
|
|
case "typename":
|
|
err = setString("typename", &dir.TypeName, arg.Value, pos)
|
|
default:
|
|
return errorf(pos, "unknown argument %v for @genqlient", arg.Name)
|
|
}
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (dir *genqlientDirective) validate(node interface{}, schema *ast.Schema) error {
|
|
switch node := node.(type) {
|
|
case *ast.OperationDefinition:
|
|
if dir.Bind != "" {
|
|
return errorf(dir.pos, "bind may not be applied to the entire operation")
|
|
}
|
|
|
|
// Anything else is valid on the entire operation; it will just apply
|
|
// to whatever it is relevant to.
|
|
return nil
|
|
case *ast.FragmentDefinition:
|
|
if dir.Bind != "" {
|
|
// TODO(benkraft): Implement this if people find it useful.
|
|
return errorf(dir.pos, "bind is not implemented for named fragments")
|
|
}
|
|
|
|
if dir.Struct != nil {
|
|
return errorf(dir.pos, "struct is only applicable to fields, not frragment-definitions")
|
|
}
|
|
|
|
// Like operations, anything else will just apply to the entire
|
|
// fragment.
|
|
return nil
|
|
case *ast.VariableDefinition:
|
|
if dir.Omitempty != nil && node.Type.NonNull {
|
|
return errorf(dir.pos, "omitempty may only be used on optional arguments")
|
|
}
|
|
|
|
if dir.Struct != nil {
|
|
return errorf(dir.pos, "struct is only applicable to fields, not variable-definitions")
|
|
}
|
|
|
|
if dir.Flatten != nil {
|
|
return errorf(dir.pos, "flatten is only applicable to fields, not variable-definitions")
|
|
}
|
|
|
|
return nil
|
|
case *ast.Field:
|
|
if dir.Omitempty != nil {
|
|
return errorf(dir.pos, "omitempty is not applicable to variables, not fields")
|
|
}
|
|
|
|
typ := schema.Types[node.Definition.Type.Name()]
|
|
if dir.Struct != nil {
|
|
if err := validateStructOption(typ, node.SelectionSet, dir.pos); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if dir.Flatten != nil {
|
|
if _, err := validateFlattenOption(typ, node.SelectionSet, dir.pos); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
default:
|
|
return errorf(dir.pos, "invalid @genqlient directive location: %T", node)
|
|
}
|
|
}
|
|
|
|
func validateStructOption(
|
|
typ *ast.Definition,
|
|
selectionSet ast.SelectionSet,
|
|
pos *ast.Position,
|
|
) error {
|
|
if typ.Kind != ast.Interface && typ.Kind != ast.Union {
|
|
return errorf(pos, "struct is only applicable to interface-typed fields")
|
|
}
|
|
|
|
// Make sure that all the requested fields apply to the interface itself
|
|
// (not just certain implementations).
|
|
for _, selection := range selectionSet {
|
|
switch selection.(type) {
|
|
case *ast.Field:
|
|
// fields are fine.
|
|
case *ast.InlineFragment, *ast.FragmentSpread:
|
|
// Fragments aren't allowed. In principle we could allow them under
|
|
// the condition that the fragment applies to the whole interface
|
|
// (not just one implementation; and so on recursively), and for
|
|
// fragment spreads additionally that the fragment has the same
|
|
// option applied to it, but it seems more trouble than it's worth
|
|
// right now.
|
|
return errorf(pos, "struct is not allowed for types with fragments")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func validateFlattenOption(
|
|
typ *ast.Definition,
|
|
selectionSet ast.SelectionSet,
|
|
pos *ast.Position,
|
|
) (index int, err error) {
|
|
index = -1
|
|
if len(selectionSet) == 0 {
|
|
return -1, errorf(pos, "flatten is not allowed for leaf fields")
|
|
}
|
|
|
|
for i, selection := range selectionSet {
|
|
switch selection := selection.(type) {
|
|
case *ast.Field:
|
|
// If the field is auto-added __typename, ignore it for flattening
|
|
// purposes.
|
|
if selection.Name == "__typename" && selection.Position == nil {
|
|
continue
|
|
}
|
|
// Type-wise, it's no harder to implement flatten for fields, but
|
|
// it requires new logic in UnmarshalJSON. We can add that if it
|
|
// proves useful relative to its complexity.
|
|
return -1, errorf(pos, "flatten is not yet supported for fields (only fragment spreads)")
|
|
|
|
case *ast.InlineFragment:
|
|
// Inline fragments aren't allowed. In principle there's nothing
|
|
// stopping us from allowing them (under the same type-match
|
|
// conditions as fragment spreads), but there's little value to it.
|
|
return -1, errorf(pos, "flatten is not allowed for selections with inline fragments")
|
|
|
|
case *ast.FragmentSpread:
|
|
if index != -1 {
|
|
return -1, errorf(pos, "flatten is not allowed for fields with multiple selections")
|
|
} else if !fragmentMatches(typ, selection.Definition.Definition) {
|
|
// We don't let you flatten
|
|
// field { # type: FieldType
|
|
// ...Fragment # type: FragmentType
|
|
// }
|
|
// unless FragmentType implements FieldType, because otherwise
|
|
// what do we do if we get back a type that doesn't implement
|
|
// FragmentType?
|
|
return -1, errorf(pos,
|
|
"flatten is not allowed for fields with fragment-spreads "+
|
|
"unless the field-type implements the fragment-type; "+
|
|
"field-type %s does not implement fragment-type %s",
|
|
typ.Name, selection.Definition.Definition.Name)
|
|
}
|
|
index = i
|
|
}
|
|
}
|
|
return index, nil
|
|
}
|
|
|
|
// merge joins the directive applied to this node (the argument) and the one
|
|
// applied to the entire operation (the receiver) and returns a new
|
|
// directive-object representing the options to apply to this node (where in
|
|
// general we take the node's option, then the operation's, then the default).
|
|
func (dir *genqlientDirective) merge(other *genqlientDirective) *genqlientDirective {
|
|
retval := *dir
|
|
if other.Omitempty != nil {
|
|
retval.Omitempty = other.Omitempty
|
|
}
|
|
if other.Pointer != nil {
|
|
retval.Pointer = other.Pointer
|
|
}
|
|
if other.Struct != nil {
|
|
retval.Struct = other.Struct
|
|
}
|
|
if other.Flatten != nil {
|
|
retval.Flatten = other.Flatten
|
|
}
|
|
if other.Bind != "" {
|
|
retval.Bind = other.Bind
|
|
}
|
|
// For typename, the local directive always wins: when specified on the query
|
|
// options typename applies to the response-struct, not to all parts of the
|
|
// query.
|
|
retval.TypeName = other.TypeName
|
|
return &retval
|
|
}
|
|
|
|
// parsePrecedingComment looks at the comment right before this node, and
|
|
// returns the genqlient directive applied to it (or an empty one if there is
|
|
// none), the remaining human-readable comment (or "" if there is none), and an
|
|
// error if the directive is invalid.
|
|
func (g *generator) parsePrecedingComment(
|
|
node interface{},
|
|
pos *ast.Position,
|
|
) (comment string, directive *genqlientDirective, err error) {
|
|
directive = newGenqlientDirective(pos)
|
|
hasDirective := false
|
|
if pos == nil || pos.Src == nil { // node was added by genqlient itself
|
|
return "", directive, nil // treated as if there were no comment
|
|
}
|
|
|
|
var commentLines []string
|
|
sourceLines := strings.Split(pos.Src.Input, "\n")
|
|
for i := pos.Line - 1; i > 0; i-- {
|
|
line := strings.TrimSpace(sourceLines[i-1])
|
|
trimmed := strings.TrimSpace(strings.TrimPrefix(line, "#"))
|
|
if strings.HasPrefix(line, "# @genqlient") {
|
|
hasDirective = true
|
|
var graphQLDirective *ast.Directive
|
|
graphQLDirective, err = parseDirective(trimmed, pos)
|
|
if err != nil {
|
|
return "", nil, err
|
|
}
|
|
err = directive.add(graphQLDirective, pos)
|
|
if err != nil {
|
|
return "", nil, err
|
|
}
|
|
} else if strings.HasPrefix(line, "#") {
|
|
commentLines = append(commentLines, trimmed)
|
|
} else {
|
|
break
|
|
}
|
|
}
|
|
|
|
if hasDirective { // (else directive is empty)
|
|
err = directive.validate(node, g.schema)
|
|
if err != nil {
|
|
return "", nil, err
|
|
}
|
|
}
|
|
|
|
reverse(commentLines)
|
|
|
|
return strings.TrimSpace(strings.Join(commentLines, "\n")), directive, nil
|
|
}
|
|
|
|
func parseDirective(line string, pos *ast.Position) (*ast.Directive, error) {
|
|
// HACK: parse the "directive" by making a fake query containing it.
|
|
fakeQuery := fmt.Sprintf("query %v { field }", line)
|
|
doc, err := parser.ParseQuery(&ast.Source{Input: fakeQuery})
|
|
if err != nil {
|
|
return nil, errorf(pos, "invalid genqlient directive: %v", err)
|
|
}
|
|
return doc.Operations[0].Directives[0], nil
|
|
}
|