Files
genqlient/generate/parse.go
T
Ben Kraft e38a212de2 Be more precise in deciding whether to add the schema prelude (#205)
GraphQL schemas have some builtin types, like `String`. The spec says
your SDL must not include those, but in practice some schemas do. (This
is probably because introspection must include them, and some tools that
create SDL from introspection don't know they're supposed to filter them
out.) Anyway, we've since #145 had logic to handle this; we just parse
with and without the prelude that defines them and see which works.

The problem is that this makes for very confusing error messages if you
have an invalid schema. (Or if you have a schema that you think is valid
but gqlparser doesn't, which is the more common case in the wild; see
for example #200.) Right now if both ways error we take the
without-prelude error, which if you didn't define the builtins is just
`undefined type String`; if we took the with-prelude error then if you
did define the builtins you'd just get `type String defined twice`. So
we actually have to be smart if we want good error messages for
everyone.

So in this commit we are smart: we check if your schema defines
`String`, and include the prelude only if it does not. To do this I
basically inlined `gqlparser.LoadSchema` (twice), so that in between
parsing and validation we can check if you have `String` and if not add
the prelude. This should in theory be both more efficient (we don't
have to do everything twice) and give better error messages,
although it's a bit more code.

Fixes #175.

Test plan: make check
2022-06-06 16:50:16 -07:00

221 lines
6.1 KiB
Go

package generate
import (
"fmt"
goAst "go/ast"
goParser "go/parser"
goToken "go/token"
"os"
"path/filepath"
"strconv"
"strings"
"github.com/vektah/gqlparser/v2/ast"
"github.com/vektah/gqlparser/v2/parser"
"github.com/vektah/gqlparser/v2/validator"
_ "github.com/vektah/gqlparser/v2/validator/rules"
)
func getSchema(globs StringList) (*ast.Schema, error) {
filenames, err := expandFilenames(globs)
if err != nil {
return nil, err
}
sources := make([]*ast.Source, len(filenames))
for i, filename := range filenames {
text, err := os.ReadFile(filename)
if err != nil {
return nil, errorf(nil, "unreadable schema file %v: %v", filename, err)
}
sources[i] = &ast.Source{Name: filename, Input: string(text)}
}
// Ideally here we'd just call gqlparser.LoadSchema. But the schema we are
// given may or may not contain the builtin types String, Int, etc. (The
// spec says it shouldn't, but introspection will return those types, and
// some introspection-to-SDL tools aren't smart enough to remove them.) So
// we inline LoadSchema and insert some checks.
document, graphqlError := parser.ParseSchemas(sources...)
if graphqlError != nil {
// Schema doesn't even parse.
return nil, errorf(nil, "invalid schema: %v", graphqlError)
}
// Check if we have a builtin type. (String is an arbitrary choice.)
hasBuiltins := false
for _, def := range document.Definitions {
if def.Name == "String" {
hasBuiltins = true
break
}
}
if !hasBuiltins {
// modified from parser.ParseSchemas
var preludeAST *ast.SchemaDocument
preludeAST, graphqlError = parser.ParseSchema(validator.Prelude)
if graphqlError != nil {
return nil, errorf(nil, "invalid prelude (probably a gqlparser bug): %v", graphqlError)
}
document.Merge(preludeAST)
}
schema, graphqlError := validator.ValidateSchemaDocument(document)
if graphqlError != nil {
return nil, errorf(nil, "invalid schema: %v", graphqlError)
}
return schema, nil
}
func getAndValidateQueries(basedir string, filenames StringList, schema *ast.Schema) (*ast.QueryDocument, error) {
queryDoc, err := getQueries(basedir, filenames)
if err != nil {
return nil, err
}
// Cf. gqlparser.LoadQuery
graphqlErrors := validator.Validate(schema, queryDoc)
if graphqlErrors != nil {
return nil, errorf(nil, "query-spec does not match schema: %v", graphqlErrors)
}
return queryDoc, nil
}
func expandFilenames(globs []string) ([]string, error) {
uniqFilenames := make(map[string]bool, len(globs))
for _, glob := range globs {
matches, err := filepath.Glob(glob)
if err != nil {
return nil, errorf(nil, "can't expand file-glob %v: %v", glob, err)
}
if len(matches) == 0 {
return nil, errorf(nil, "%v did not match any files", glob)
}
for _, match := range matches {
uniqFilenames[match] = true
}
}
filenames := make([]string, 0, len(uniqFilenames))
for filename := range uniqFilenames {
filenames = append(filenames, filename)
}
return filenames, nil
}
func getQueries(basedir string, globs StringList) (*ast.QueryDocument, error) {
// We merge all the queries into a single query-document, since operations
// in one might reference fragments in another.
//
// TODO(benkraft): It might be better to merge just within a filename, so
// that fragment-names don't need to be unique across files. (Although
// then we may have other problems; and query-names still need to be.)
mergedQueryDoc := new(ast.QueryDocument)
addQueryDoc := func(queryDoc *ast.QueryDocument) {
mergedQueryDoc.Operations = append(mergedQueryDoc.Operations, queryDoc.Operations...)
mergedQueryDoc.Fragments = append(mergedQueryDoc.Fragments, queryDoc.Fragments...)
}
filenames, err := expandFilenames(globs)
if err != nil {
return nil, err
}
for _, filename := range filenames {
text, err := os.ReadFile(filename)
if err != nil {
return nil, errorf(nil, "unreadable query-spec file %v: %v", filename, err)
}
switch filepath.Ext(filename) {
case ".graphql":
queryDoc, err := getQueriesFromString(string(text), basedir, filename)
if err != nil {
return nil, err
}
addQueryDoc(queryDoc)
case ".go":
queryDocs, err := getQueriesFromGo(string(text), basedir, filename)
if err != nil {
return nil, err
}
for _, queryDoc := range queryDocs {
addQueryDoc(queryDoc)
}
default:
return nil, errorf(nil, "unknown file type: %v", filename)
}
}
return mergedQueryDoc, nil
}
func getQueriesFromString(text string, basedir, filename string) (*ast.QueryDocument, error) {
// make path relative to the config-directory
relname, err := filepath.Rel(basedir, filename)
if err == nil {
filename = relname
}
// Cf. gqlparser.LoadQuery
document, graphqlError := parser.ParseQuery(
&ast.Source{Name: filename, Input: text})
if graphqlError != nil { // ParseQuery returns type *graphql.Error, yuck
return nil, errorf(nil, "invalid query-spec file %v: %v", filename, graphqlError)
}
return document, nil
}
func getQueriesFromGo(text string, basedir, filename string) ([]*ast.QueryDocument, error) {
fset := goToken.NewFileSet()
f, err := goParser.ParseFile(fset, filename, text, 0)
if err != nil {
return nil, errorf(nil, "invalid Go file %v: %v", filename, err)
}
var retval []*ast.QueryDocument
goAst.Inspect(f, func(node goAst.Node) bool {
if err != nil {
return false // don't bother to recurse if something already failed
}
basicLit, ok := node.(*goAst.BasicLit)
if !ok || basicLit.Kind != goToken.STRING {
return true // recurse
}
var value string
value, err = strconv.Unquote(basicLit.Value)
if err != nil {
return false
}
if !strings.HasPrefix(strings.TrimSpace(value), "# @genqlient") {
return true
}
// We put the filename as <real filename>:<line>, which errors.go knows
// how to parse back out (since it's what gqlparser will give to us in
// our errors).
pos := fset.Position(basicLit.Pos())
fakeFilename := fmt.Sprintf("%v:%v", pos.Filename, pos.Line)
var query *ast.QueryDocument
query, err = getQueriesFromString(value, basedir, fakeFilename)
if err != nil {
return false
}
retval = append(retval, query)
return true
})
return retval, err
}