## Summary:
There were a few bugs here, one of which Craig came across when pulling
the custom-unmarshaler change into webapp:
1. If you have an optional field with a custom unmarshaler, and the
server omits the field from the response entirely (i.e. does not
write `"myField": null`), we would still call your unmarshaler with
an input of `[]byte(nil)`. This is just wrong; it's our job to do
the nil-check. (This is the one Craig found; in practice gqlgen
servers do not do this and I think the spec says not to although it's
a bit fuzzy on the matter of serialization. But in practice we have
mocks that do it -- for required fields even! -- and it seems better
to handle it than pass you data on which you'll probably err or even
panic.)
2. If you have an optional field with a custom unmarshaler, and the
server returns an explicit null (i.e. `"myField": null`), we would
call your unmarshaler with `[]byte("null")`. In principle the intent
was you're supposed to implement that, as [`json.Unmarshaler`
advises][1]. But (a) I forgot to document that, and (b) in practice
`json.Unmarshal` [does *not* call you in that case][2], i.e. its
advice is unnecessary. So I think it's better for us to just match
it, and not call you. (And in that case I see no reason to bother
documenting the advice.)
3. If you have an optional, `pointer: true` field with a custom
marshaler, the reverse of (2) applies: if the pointer is nil, we
shouldn't really call you. (Indeed if you were a real
`json.Marshaler` with a value-method rather than a pointer-method,
trying to call you might panic!) Note we don't need to explicitly
write "null"; we just leave the `json.RawMessage` as nil, and
`json.Marshal` [handles that][3].
4. We handle interface types effectively the same as custom
unmarshalers, just we generate the unmarshaler. So if you have an
optional field with interface type, (1) would also apply there; our
generated unmarshaler returns an error in this case.
5. While (2) doesn't apply to such optional interface fields (because we
do the customary `if string(b) == "null"` check -- this I at least
thought to test), if you set `pointer: true` on the field, we would
still call the unmarshaler on the value, and it would no-op, but only
*after* we initialized the pointer. Put more simply, we'd return a
non-nil pointer to nil interface, rather than a nil pointer; this is
wrong since the whole point of `pointer: true` is you only get a
non-nil pointer if your value is nil! Of course, in practice there's
little reason to use `pointer: true` on interface fields, and indeed
this stuff gets so confusing my test was even wrong.
In this commit I fix all the bugs, by adding appropriate nil-checks to
wrap the unmarshaler-calls. The templates are, as always, a bit
confusing, but the generated code makes it clear what changed.
Note we'll want to land this before cutting a release with custom
marshaler/unmarshaler support, because the first three bugs are
potentially quite noticeable. (The latter two are in `v0.1.0`, but
presumably quite rare.)
[1]: https://pkg.go.dev/encoding/json#Unmarshaler
[2]: https://play.golang.org/p/Pw6zNN8trGO
[3]: https://play.golang.org/p/crTfnT7ePte
Issue: https://phabricator.khanacademy.org/D74453#inline-558571
## Test plan:
make tesc
Author: benjaminjkraft
Reviewers: csilvers, StevenACoffman, benjaminjkraft, aberkan, dnerdy, jvoll, mahtabsabet, MiguelCastillo
Required Reviewers:
Approved By: csilvers, StevenACoffman
Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint
Pull Request URL: https://github.com/Khan/genqlient/pull/116
183 lines
4.7 KiB
Go
183 lines
4.7 KiB
Go
package test
|
|
|
|
// Code generated by github.com/Khan/genqlient, DO NOT EDIT.
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/Khan/genqlient/graphql"
|
|
"github.com/Khan/genqlient/internal/testutil"
|
|
)
|
|
|
|
// UserQueryInput is the argument to Query.users.
|
|
//
|
|
// Ideally this would support anything and everything!
|
|
// Or maybe ideally it wouldn't.
|
|
// Really I'm just talking to make this documentation longer.
|
|
type MyInput struct {
|
|
Email *string `json:"email"`
|
|
Name *string `json:"name"`
|
|
// id looks the user up by ID. It's a great way to look up users.
|
|
Id *testutil.ID `json:"id"`
|
|
Role *Role `json:"role"`
|
|
Names []*string `json:"names"`
|
|
HasPokemon *testutil.Pokemon `json:"hasPokemon"`
|
|
Birthdate *time.Time `json:"-"`
|
|
}
|
|
|
|
func (v *MyInput) MarshalJSON() ([]byte, error) {
|
|
|
|
var fullObject struct {
|
|
*MyInput
|
|
Birthdate json.RawMessage `json:"birthdate"`
|
|
graphql.NoMarshalJSON
|
|
}
|
|
fullObject.MyInput = v
|
|
|
|
{
|
|
|
|
dst := &fullObject.Birthdate
|
|
src := v.Birthdate
|
|
if src != nil {
|
|
var err error
|
|
*dst, err = testutil.MarshalDate(
|
|
src)
|
|
if err != nil {
|
|
return nil, fmt.Errorf(
|
|
"Unable to marshal MyInput.Birthdate: %w", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
return json.Marshal(&fullObject)
|
|
}
|
|
|
|
// MyMultipleDirectivesResponse is returned by MultipleDirectives on success.
|
|
type MyMultipleDirectivesResponse struct {
|
|
// user looks up a user by some stuff.
|
|
//
|
|
// See UserQueryInput for what stuff is supported.
|
|
// If query is null, returns the current user.
|
|
User *MyMultipleDirectivesResponseUser `json:"user"`
|
|
Users []*MyMultipleDirectivesResponseUsersUser `json:"users"`
|
|
}
|
|
|
|
// MyMultipleDirectivesResponseUser includes the requested fields of the GraphQL type User.
|
|
// The GraphQL type's documentation follows.
|
|
//
|
|
// A User is a user!
|
|
type MyMultipleDirectivesResponseUser struct {
|
|
// id is the user's ID.
|
|
//
|
|
// It is stable, unique, and opaque, like all good IDs.
|
|
Id *testutil.ID `json:"id"`
|
|
}
|
|
|
|
// MyMultipleDirectivesResponseUsersUser includes the requested fields of the GraphQL type User.
|
|
// The GraphQL type's documentation follows.
|
|
//
|
|
// A User is a user!
|
|
type MyMultipleDirectivesResponseUsersUser struct {
|
|
// id is the user's ID.
|
|
//
|
|
// It is stable, unique, and opaque, like all good IDs.
|
|
Id *testutil.ID `json:"id"`
|
|
}
|
|
|
|
// Role is a type a user may have.
|
|
type Role string
|
|
|
|
const (
|
|
// What is a student?
|
|
//
|
|
// A student is primarily a person enrolled in a school or other educational institution and who is under learning with goals of acquiring knowledge, developing professions and achieving employment at desired field. In the broader sense, a student is anyone who applies themselves to the intensive intellectual engagement with some matter necessary to master it as part of some practical affair in which such mastery is basic or decisive.
|
|
//
|
|
// (from [Wikipedia](https://en.wikipedia.org/wiki/Student))
|
|
RoleStudent Role = "STUDENT"
|
|
// Teacher is a teacher, who teaches the students.
|
|
RoleTeacher Role = "TEACHER"
|
|
)
|
|
|
|
// UserQueryInput is the argument to Query.users.
|
|
//
|
|
// Ideally this would support anything and everything!
|
|
// Or maybe ideally it wouldn't.
|
|
// Really I'm just talking to make this documentation longer.
|
|
type UserQueryInput struct {
|
|
Email *string `json:"email"`
|
|
Name *string `json:"name"`
|
|
// id looks the user up by ID. It's a great way to look up users.
|
|
Id *testutil.ID `json:"id"`
|
|
Role *Role `json:"role"`
|
|
Names []*string `json:"names"`
|
|
HasPokemon *testutil.Pokemon `json:"hasPokemon"`
|
|
Birthdate *time.Time `json:"-"`
|
|
}
|
|
|
|
func (v *UserQueryInput) MarshalJSON() ([]byte, error) {
|
|
|
|
var fullObject struct {
|
|
*UserQueryInput
|
|
Birthdate json.RawMessage `json:"birthdate"`
|
|
graphql.NoMarshalJSON
|
|
}
|
|
fullObject.UserQueryInput = v
|
|
|
|
{
|
|
|
|
dst := &fullObject.Birthdate
|
|
src := v.Birthdate
|
|
if src != nil {
|
|
var err error
|
|
*dst, err = testutil.MarshalDate(
|
|
src)
|
|
if err != nil {
|
|
return nil, fmt.Errorf(
|
|
"Unable to marshal UserQueryInput.Birthdate: %w", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
return json.Marshal(&fullObject)
|
|
}
|
|
|
|
// __MultipleDirectivesInput is used internally by genqlient
|
|
type __MultipleDirectivesInput struct {
|
|
Query MyInput `json:"query,omitempty"`
|
|
Queries []*UserQueryInput `json:"queries,omitempty"`
|
|
}
|
|
|
|
func MultipleDirectives(
|
|
client graphql.Client,
|
|
query MyInput,
|
|
queries []*UserQueryInput,
|
|
) (*MyMultipleDirectivesResponse, error) {
|
|
__input := __MultipleDirectivesInput{
|
|
Query: query,
|
|
Queries: queries,
|
|
}
|
|
var err error
|
|
|
|
var retval MyMultipleDirectivesResponse
|
|
err = client.MakeRequest(
|
|
nil,
|
|
"MultipleDirectives",
|
|
`
|
|
query MultipleDirectives ($query: UserQueryInput, $queries: [UserQueryInput]) {
|
|
user(query: $query) {
|
|
id
|
|
}
|
|
users(query: $queries) {
|
|
id
|
|
}
|
|
}
|
|
`,
|
|
&retval,
|
|
&__input,
|
|
)
|
|
return &retval, err
|
|
}
|
|
|