Ben KraftandGitHub
6fdb170b99
## Summary: When adding support for interfaces, I did not do the type-names as I intended: they came out to be `MyFieldMyType`, not `MyInterfaceMyFieldMyType`, which is inconsistent, but not strictly wrong. But once supporting fragments, this is also now incorrect. (Exactly why is described in the comments inline.) In this commit, in any case, I fix it. To do that, I finally did the last of the refactors I've been hoping to do but unable to successfully implement, which is to make the type-name and type-name-prefix management clearer. In the past it was kind of spread out, and each caller would have to pass the right name into `convertDefinition`, which go quite unwieldy. Now, the case that really wanted that -- the operation toplevel -- just does it own thing; and the main name-generation code is factored out into a separate file with tests, and with a long comment that goes into all the details of the algorithm that the design-doc didn't cover. (I even had some fun using a linked list to implement the prefix-stack!) This allowed me to fix the above bug fairly easily -- actually the fix was pretty much automatic once I understood how to organize things. There is one change which is that if your query name is unexported, we no longer do the same with the input-type names; it's unclear to me if anyone will actually care about this behavior (Khan always makes the queries exported) but if they did it was very inconsistent (only at the query toplevel, and only for input-objects, not enums), so we can reimplement it properly if that comes up. As a bonus fix, we now better handle the case where your type-names are lowercase, which is legal if nonstandard GraphQL. Issue: https://github.com/Khan/genqlient/issues/8 ## Test plan: make tesc Author: benjaminjkraft Reviewers: dnerdy, benjaminjkraft, aberkan, MiguelCastillo Required Reviewers: Approved by: dnerdy Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Test (1.13), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Test (1.13), ✅ Lint Pull request URL: https://github.com/Khan/genqlient/pull/71
84 lines
2.3 KiB
Go
84 lines
2.3 KiB
Go
package test
|
|
|
|
// Code generated by github.com/Khan/genqlient, DO NOT EDIT.
|
|
|
|
import (
|
|
"github.com/Khan/genqlient/graphql"
|
|
"github.com/Khan/genqlient/internal/testutil"
|
|
)
|
|
|
|
// Role is a type a user may have.
|
|
type Role string
|
|
|
|
const (
|
|
// What is a student?
|
|
//
|
|
// A student is primarily a person enrolled in a school or other educational institution and who is under learning with goals of acquiring knowledge, developing professions and achieving employment at desired field. In the broader sense, a student is anyone who applies themselves to the intensive intellectual engagement with some matter necessary to master it as part of some practical affair in which such mastery is basic or decisive.
|
|
//
|
|
// (from [Wikipedia](https://en.wikipedia.org/wiki/Student))
|
|
RoleStudent Role = "STUDENT"
|
|
// Teacher is a teacher, who teaches the students.
|
|
RoleTeacher Role = "TEACHER"
|
|
)
|
|
|
|
// UserQueryInput is the argument to Query.users.
|
|
//
|
|
// Ideally this would support anything and everything!
|
|
// Or maybe ideally it wouldn't.
|
|
// Really I'm just talking to make this documentation longer.
|
|
type UserQueryInput struct {
|
|
Email string `json:"email"`
|
|
Name string `json:"name"`
|
|
// id looks the user up by ID. It's a great way to look up users.
|
|
Id testutil.ID `json:"id"`
|
|
Role Role `json:"role"`
|
|
Names []string `json:"names"`
|
|
HasPokemon testutil.Pokemon `json:"hasPokemon"`
|
|
}
|
|
|
|
// unexportedResponse is returned by unexported on success.
|
|
type unexportedResponse struct {
|
|
// user looks up a user by some stuff.
|
|
//
|
|
// See UserQueryInput for what stuff is supported.
|
|
// If query is null, returns the current user.
|
|
User unexportedUser `json:"user"`
|
|
}
|
|
|
|
// unexportedUser includes the requested fields of the GraphQL type User.
|
|
// The GraphQL type's documentation follows.
|
|
//
|
|
// A User is a user!
|
|
type unexportedUser struct {
|
|
// id is the user's ID.
|
|
//
|
|
// It is stable, unique, and opaque, like all good IDs.
|
|
Id testutil.ID `json:"id"`
|
|
}
|
|
|
|
func unexported(
|
|
client graphql.Client,
|
|
query UserQueryInput,
|
|
) (*unexportedResponse, error) {
|
|
variables := map[string]interface{}{
|
|
"query": query,
|
|
}
|
|
|
|
var retval unexportedResponse
|
|
err := client.MakeRequest(
|
|
nil,
|
|
"unexported",
|
|
`
|
|
query unexported ($query: UserQueryInput) {
|
|
user(query: $query) {
|
|
id
|
|
}
|
|
}
|
|
`,
|
|
&retval,
|
|
variables,
|
|
)
|
|
return &retval, err
|
|
}
|
|
|