## Summary: This is useful if you want to bind to a type you don't control (or use for other things) but need different serialization than its default. This is a feature gqlgen has and we've found it very useful. For example, in webapp we want to bind `DateTime` to `time.Time`, but its default serialization is not compatible with Python, so currently we have to bind to a wrapper type and cast all over the place, which is exactly the sort of boilerplate genqlient is supposed to avoid. For unmarshaling, the implementation basically just follows the existing support for abstract types; instead of calling our own generated helper, we now call your specified function. This required some refactoring to abstract the handling of custom unmarshalers generally from abstract types specifically, and to wire in not only the unmarshaler-name but also the `generator` (in order to compute the right import alias). For marshaling, I had to implement all that stuff over again; it's mostly parallel to unmarshaling (and I made a few minor changes to unmarshaling to make the two more parallel). Luckily, after #103 I at least only had to do it once, rather than implementing the same functionality for arguments and for input-type fields. It was still quite a bit of code; I didn't try to be quite as completionist about the tests as with unmarshal but still had to add a few. Issue: https://github.com/Khan/genqlient/issues/38 ## Test plan: make check Author: benjaminjkraft Reviewers: StevenACoffman, dnerdy, benjaminjkraft, aberkan, jvoll, mahtabsabet, MiguelCastillo Required Reviewers: Approved By: StevenACoffman, dnerdy Checks: ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint, ✅ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint Pull Request URL: https://github.com/Khan/genqlient/pull/104
127 lines
5.6 KiB
Cheetah
127 lines
5.6 KiB
Cheetah
{{/* (the blank lines at the start are intentional, to separate
|
|
UnmarshalJSON from the function it follows) */}}
|
|
|
|
func (v *{{.GoName}}) UnmarshalJSON(b []byte) error {
|
|
{{/* Standard convention for unmarshalers is to no-op on null. */}}
|
|
if string(b) == "null" {
|
|
return nil
|
|
}
|
|
|
|
{{/* We want to specially handle certain fields, but unmarshal everything
|
|
else normally. To handle abstract fields and fields with custom
|
|
unmarshalers, first we unmarshal them into a json.RawMessage, and then
|
|
handle those further, below. Embedded fields don't need the
|
|
json.RawMessage; we just use our input again. Either way, we first
|
|
want to call json.Unmarshal on the receiver (v). But if we do that
|
|
naively on a value of type `.Type`, it will call this function again,
|
|
and recurse infinitely. So we make a wrapper type which embeds both
|
|
this type and NoUmnarshalJSON, which prevents either's UnmarshalJSON
|
|
method from being promoted. For more on why this is so difficult, see
|
|
https://github.com/benjaminjkraft/notes/blob/master/go-json-interfaces.md.
|
|
(Note there are a few different ways "hide" the method, but this one
|
|
seems to be the best option that works if this type has embedded types
|
|
with UnmarshalJSON methods.)
|
|
*/}}
|
|
|
|
{{/* TODO(benkraft): Omit/simplify the first pass if all fields are
|
|
embedded/abstract. */ -}}
|
|
var firstPass struct{
|
|
*{{.GoName}}
|
|
{{range .Fields -}}
|
|
{{if and .NeedsUnmarshaler (not .IsEmbedded) -}}
|
|
{{.GoName}} {{repeat .GoType.SliceDepth "[]"}}{{ref "encoding/json.RawMessage"}} `json:"{{.JSONName}}"`
|
|
{{end -}}
|
|
{{end -}}
|
|
{{/* TODO(benkraft): In principle you might have a field-name that
|
|
conflicts with this one; avoid that. */ -}}
|
|
{{ref "github.com/Khan/genqlient/graphql.NoUnmarshalJSON"}}
|
|
}
|
|
firstPass.{{.GoName}} = v
|
|
|
|
err := {{ref "encoding/json.Unmarshal"}}(b, &firstPass)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
{{/* Now, handle the fields needing special handling. */}}
|
|
{{range $field := .Fields -}}
|
|
{{if $field.NeedsUnmarshaler -}}
|
|
{{if $field.IsEmbedded -}}
|
|
{{/* Embedded fields are easier: we just unmarshal the same input into
|
|
them. (They're also easier because they can't be lists, since they
|
|
arise from GraphQL fragment spreads.) */ -}}
|
|
err = {{$field.Unmarshaler $.Generator}}(
|
|
b, &v.{{$field.GoType.Unwrap.Reference}})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
{{else -}}
|
|
{{/* For other fields (abstract or custom unmarshaler), first, call the
|
|
unmarshaler (our unmarshal-helper, or the user-specified one,
|
|
respectively). This gets a little complicated because we may have
|
|
a slice field. So what we do is basically, for each field of type
|
|
`[][]...[]MyType`:
|
|
|
|
dst := &v.MyField // *[][]...[]MyType
|
|
src := firstPass.MyField // [][]...[]json.RawMessage
|
|
|
|
// repeat the following three lines n times; each time, inside
|
|
// the loop we have one less layer of slice on src and dst
|
|
*dst = make([][]...[]MyType, len(src))
|
|
for i, src := range src {
|
|
// We need the &(*dst)[i] because at each stage we want to
|
|
// keep dst as a pointer. (It only really has to be a
|
|
// pointer at the innermost level, but it's easiest to be
|
|
// consistent.)
|
|
dst := &(*dst)[i]
|
|
|
|
// (now we have `dst *MyType` and `src json.RawMessage`)
|
|
__unmarshalMyType(dst, src)
|
|
|
|
} // (also n times)
|
|
|
|
Note that if the field also uses a pointer (`[][]...[]*MyType`), we
|
|
now pass around `*[][]...[]*MyType`; again in principle
|
|
`[][]...[]*MyType` would work but require more special-casing. Thus
|
|
in the innermost loop, `dst` is of type `**MyType`, so we have to
|
|
pass `*dst` to the unmarshaler. Of course, since MyType is an
|
|
interface, I'm not sure why you'd any of that anyway.
|
|
|
|
One additional trick is we wrap everything above in a block ({ ... }),
|
|
so that the variables dst and src may take on different types for
|
|
each field we are handling, which would otherwise conflict. (We could
|
|
instead suffix the names, but that makes things much harder to read.)
|
|
*/}}
|
|
{
|
|
dst := &v.{{$field.GoName}}
|
|
src := firstPass.{{$field.GoName}}
|
|
{{range $i := intRange $field.GoType.SliceDepth -}}
|
|
*dst = make(
|
|
{{repeat (sub $field.GoType.SliceDepth $i) "[]"}}{{if $field.GoType.IsPointer}}*{{end}}{{$field.GoType.Unwrap.Reference}},
|
|
len(src))
|
|
for i, src := range src {
|
|
dst := &(*dst)[i]
|
|
{{end -}}
|
|
{{if $field.GoType.IsPointer -}}
|
|
{{/* In this case, the parent for loop did `make([]*MyType, ...)` and
|
|
we have a pointer into that list. But we actually still need to
|
|
initialize the *elements* of the list. */ -}}
|
|
*dst = new({{$field.GoType.Unwrap.Reference}})
|
|
{{end -}}
|
|
err = {{$field.Unmarshaler $.Generator}}(
|
|
src, {{if $field.GoType.IsPointer}}*{{end}}dst)
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"Unable to unmarshal {{$.GoName}}.{{$field.GoName}}: %w", err)
|
|
}
|
|
{{range $i := intRange $field.GoType.SliceDepth -}}
|
|
}
|
|
{{end -}}
|
|
}
|
|
{{end -}}{{/* end if/else .IsEmbedded */ -}}
|
|
{{end -}}{{/* end if .NeedsUnmarshaler */ -}}
|
|
{{end}}{{/* end range .Fields */ -}}
|
|
|
|
return nil
|
|
}
|